diff mbox series

[1/2] dt-bindings: interconnect: qcom-bwmon: Document SA8775p bwmon compatibles

Message ID 20240730-add_sa8775p_bwmon-v1-1-f4f878da29ae@quicinc.com (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series arm64: qcom: Add BWMON support for SA8775p | expand

Commit Message

Tengfei Fan July 30, 2024, 7:16 a.m. UTC
Document the compatibles used to describe the bwmons present on the
SA8775p platform.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski July 31, 2024, 9:23 a.m. UTC | #1
On 30/07/2024 09:16, Tengfei Fan wrote:
> Document the compatibles used to describe the bwmons present on the
> SA8775p platform.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 ++
>  1 file changed, 2 insertions(+)

I admit I don't know what to do with all these sa8775p patches. I am
afraid now you say these are valid but in half a year this will change.
If I give Ack, I feel like I am agreeing to such approach, which I do not.

Best regards,
Krzysztof
Trilok Soni July 31, 2024, 7:30 p.m. UTC | #2
On 7/31/2024 2:23 AM, Krzysztof Kozlowski wrote:
> On 30/07/2024 09:16, Tengfei Fan wrote:
>> Document the compatibles used to describe the bwmons present on the
>> SA8775p platform.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>  Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> I admit I don't know what to do with all these sa8775p patches. I am
> afraid now you say these are valid but in half a year this will change.
> If I give Ack, I feel like I am agreeing to such approach, which I do not.

Are you referring to sa8775p moving to scmi later in the year? sa8755p will not move to scmi
as per the latest discussions. We will have another SOC SKU to start adding
the SCMI.
Krzysztof Kozlowski Aug. 1, 2024, 7:51 a.m. UTC | #3
On 31/07/2024 21:30, Trilok Soni wrote:
> On 7/31/2024 2:23 AM, Krzysztof Kozlowski wrote:
>> On 30/07/2024 09:16, Tengfei Fan wrote:
>>> Document the compatibles used to describe the bwmons present on the
>>> SA8775p platform.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>>  Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 ++
>>>  1 file changed, 2 insertions(+)
>>
>> I admit I don't know what to do with all these sa8775p patches. I am
>> afraid now you say these are valid but in half a year this will change.
>> If I give Ack, I feel like I am agreeing to such approach, which I do not.
> 
> Are you referring to sa8775p moving to scmi later in the year? sa8755p will not move to scmi
> as per the latest discussions. We will have another SOC SKU to start adding
> the SCMI. 

Yeah, thanks for clarification.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
index 2cd1f5590fd9..189f5900ee50 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
@@ -26,6 +26,7 @@  properties:
       - items:
           - enum:
               - qcom,qcm2290-cpu-bwmon
+              - qcom,sa8775p-cpu-bwmon
               - qcom,sc7180-cpu-bwmon
               - qcom,sc7280-cpu-bwmon
               - qcom,sc8280xp-cpu-bwmon
@@ -39,6 +40,7 @@  properties:
           - const: qcom,sdm845-bwmon    # BWMON v4, unified register space
       - items:
           - enum:
+              - qcom,sa8775p-llcc-bwmon
               - qcom,sc7180-llcc-bwmon
               - qcom,sc8280xp-llcc-bwmon
               - qcom,sm6350-cpu-bwmon