mbox series

[0/6] Add Additional algo mode for inline encryption

Message ID 20240730115838.3507302-1-quic_mdalam@quicinc.com (mailing list archive)
Headers show
Series Add Additional algo mode for inline encryption | expand

Message

Md Sadre Alam July 30, 2024, 11:58 a.m. UTC 
This series of patches add additional modes for inline encryption

This series of patches depends on [1] Add inline encryption support for dm-crypt

[1]: https://lore.kernel.org/all/b45d3b40-2587-04dc-9601-a9251dacf806@opensource.wdc.com/T/#ma01f08a941107217c93680fa25e96e8d406df790

These patches tested on IPQ9574 with eMMC ICE for raw partition
encryption/decryption.

e.g:

dmsetup create test-crypt --table '0 251904 crypt aes128-xts-plain64 a7f67ad520bd83b9725df6ebd76c3eeea7f67ad520bd83b9725df6ebd76c3eee 0 /dev/mmcblk0p27 0 1 inline_crypt'

dd if=/dev/urandom of=/tmp/data bs=1M count=1

dd if=/tmp/data of=/dev/mapper/test-crypt bs=1M count=1

dd of=/tmp/data1 if=/dev/mapper/test-crypt bs=1M count=1

dd of=/tmp/data2 if=/dev/mmcblk0p27 bs=1M count=1

md5sum /tmp/data*
b45d728bfb499b6de9b12c98fbb652dd  /tmp/data
b45d728bfb499b6de9b12c98fbb652dd  /tmp/data1
bc4107e19cf6fc012c5b997bdd3f0de4  /tmp/data2

dmsetup remove /dev/mapper/test-crypt

Md Sadre Alam (6):
  md: dm-crypt: Fix compilation issue
  md: dm-crypt: Set cc->iv_size to 4 bytes
  blk-crypto: Add additional algo modes for Inline encryption
  md: dm-crypt: Add additional algo modes for inline encryption
  mmc: cqhci: Add additional algo mode for inline encryption
  mmc: sdhci-msm: Add additional algo mode for inline encryption

 block/blk-crypto.c              | 18 +++++++++
 drivers/md/dm-crypt.c           | 26 ++++++-------
 drivers/mmc/host/cqhci-crypto.c | 12 ++++++
 drivers/mmc/host/sdhci-msm.c    | 10 +----
 drivers/soc/qcom/ice.c          | 65 ++++++++++++++++++++++++++++-----
 include/linux/blk-crypto.h      |  3 ++
 6 files changed, 103 insertions(+), 31 deletions(-)

Comments

Mikulas Patocka July 31, 2024, 12:48 p.m. UTC | #1 
On Tue, 30 Jul 2024, Md Sadre Alam wrote:

> This series of patches add additional modes for inline encryption
> 
> This series of patches depends on [1] Add inline encryption support for dm-crypt
> 
> [1]: https://lore.kernel.org/all/b45d3b40-2587-04dc-9601-a9251dacf806@opensource.wdc.com/T/#ma01f08a941107217c93680fa25e96e8d406df790
> 
> These patches tested on IPQ9574 with eMMC ICE for raw partition
> encryption/decryption.

Hi

I discussed it with Milan Broz <gmazyland@gmail.com> and we concluded that 
there is no need to bloat dm-crypt with this logic.

We believe that you should create your own target (like 
"dm-inline-crypt"), it would work like a linear target and it will attach 
encryption requests to the bios that it processes.

Mikulas
Kamal Dasu July 31, 2024, 2:18 p.m. UTC | #2 
This is not related to emulation, but was. upstream linux development

Kamal

On Wed, Jul 31, 2024 at 8:50 AM Mikulas Patocka <mpatocka@redhat.com> wrote:
>
>
>
> On Tue, 30 Jul 2024, Md Sadre Alam wrote:
>
> > This series of patches add additional modes for inline encryption
> >
> > This series of patches depends on [1] Add inline encryption support for dm-crypt
> >
> > [1]: https://lore.kernel.org/all/b45d3b40-2587-04dc-9601-a9251dacf806@opensource.wdc.com/T/#ma01f08a941107217c93680fa25e96e8d406df790
> >
> > These patches tested on IPQ9574 with eMMC ICE for raw partition
> > encryption/decryption.
>
> Hi
>
> I discussed it with Milan Broz <gmazyland@gmail.com> and we concluded that
> there is no need to bloat dm-crypt with this logic.
>
> We believe that you should create your own target (like
> "dm-inline-crypt"), it would work like a linear target and it will attach
> encryption requests to the bios that it processes.
>
> Mikulas
>
>
Md Sadre Alam Aug. 2, 2024, 4:23 a.m. UTC | #3 
On 7/31/2024 6:18 PM, Mikulas Patocka wrote:
> 
> 
> On Tue, 30 Jul 2024, Md Sadre Alam wrote:
> 
>> This series of patches add additional modes for inline encryption
>>
>> This series of patches depends on [1] Add inline encryption support for dm-crypt
>>
>> [1]: https://lore.kernel.org/all/b45d3b40-2587-04dc-9601-a9251dacf806@opensource.wdc.com/T/#ma01f08a941107217c93680fa25e96e8d406df790
>>
>> These patches tested on IPQ9574 with eMMC ICE for raw partition
>> encryption/decryption.
> 
> Hi
> 
> I discussed it with Milan Broz <gmazyland@gmail.com> and we concluded that
> there is no need to bloat dm-crypt with this logic.
> 
> We believe that you should create your own target (like
> "dm-inline-crypt"), it would work like a linear target and it will attach
> encryption requests to the bios that it processes.
> 
   Thanks for reviewing. Will create new target driver "dm-inline-crypt".

> Mikulas
>