| Message ID | 20240731063630.3592046-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f9c141fc33393923451bdd190c67d9d4f5d2c67f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] RDS: IB: Remove unused declarations | expand |
+CC Simon Horman <horms@kernel.org> On 2024/7/31 14:36, Yue Haibing wrote: > Commit f4f943c958a2 ("RDS: IB: ack more receive completions to improve performance") > removed rds_ib_recv_tasklet_fn() implementation but not the declaration. > And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but never implemented > other functions. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > Reviewed-by: Simon Horman <horms@kernel.org> > --- > net/rds/ib.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/net/rds/ib.h b/net/rds/ib.h > index 2ba71102b1f1..8ef3178ed4d6 100644 > --- a/net/rds/ib.h > +++ b/net/rds/ib.h > @@ -369,9 +369,6 @@ int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp); > void rds_ib_conn_free(void *arg); > int rds_ib_conn_path_connect(struct rds_conn_path *cp); > void rds_ib_conn_path_shutdown(struct rds_conn_path *cp); > -void rds_ib_state_change(struct sock *sk); > -int rds_ib_listen_init(void); > -void rds_ib_listen_stop(void); > __printf(2, 3) > void __rds_ib_conn_error(struct rds_connection *conn, const char *, ...); > int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id, > @@ -402,7 +399,6 @@ void rds_ib_inc_free(struct rds_incoming *inc); > int rds_ib_inc_copy_to_user(struct rds_incoming *inc, struct iov_iter *to); > void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic, struct ib_wc *wc, > struct rds_ib_ack_state *state); > -void rds_ib_recv_tasklet_fn(unsigned long data); > void rds_ib_recv_init_ring(struct rds_ib_connection *ic); > void rds_ib_recv_clear_ring(struct rds_ib_connection *ic); > void rds_ib_recv_init_ack(struct rds_ib_connection *ic);
On Wed, 2024-07-31 at 14:36 +0800, Yue Haibing wrote: > Commit f4f943c958a2 ("RDS: IB: ack more receive completions to > improve performance") > removed rds_ib_recv_tasklet_fn() implementation but not the > declaration. > And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but > never implemented > other functions. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > Reviewed-by: Simon Horman <horms@kernel.org> Hello Yue, Thanks for finding these. The declarations do appear unused, so I think it is fine to remove them. Thanks for the clean up. Reviewed-by: Allison Henderson <allison.henderson@oracle.com> > --- > net/rds/ib.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/net/rds/ib.h b/net/rds/ib.h > index 2ba71102b1f1..8ef3178ed4d6 100644 > --- a/net/rds/ib.h > +++ b/net/rds/ib.h > @@ -369,9 +369,6 @@ int rds_ib_conn_alloc(struct rds_connection > *conn, gfp_t gfp); > void rds_ib_conn_free(void *arg); > int rds_ib_conn_path_connect(struct rds_conn_path *cp); > void rds_ib_conn_path_shutdown(struct rds_conn_path *cp); > -void rds_ib_state_change(struct sock *sk); > -int rds_ib_listen_init(void); > -void rds_ib_listen_stop(void); > __printf(2, 3) > void __rds_ib_conn_error(struct rds_connection *conn, const char *, > ...); > int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id, > @@ -402,7 +399,6 @@ void rds_ib_inc_free(struct rds_incoming *inc); > int rds_ib_inc_copy_to_user(struct rds_incoming *inc, struct > iov_iter *to); > void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic, struct > ib_wc *wc, > struct rds_ib_ack_state *state); > -void rds_ib_recv_tasklet_fn(unsigned long data); > void rds_ib_recv_init_ring(struct rds_ib_connection *ic); > void rds_ib_recv_clear_ring(struct rds_ib_connection *ic); > void rds_ib_recv_init_ack(struct rds_ib_connection *ic);
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 31 Jul 2024 14:36:30 +0800 you wrote: > Commit f4f943c958a2 ("RDS: IB: ack more receive completions to improve performance") > removed rds_ib_recv_tasklet_fn() implementation but not the declaration. > And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but never implemented > other functions. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > Reviewed-by: Simon Horman <horms@kernel.org> > > [...] Here is the summary with links: - [net-next] RDS: IB: Remove unused declarations https://git.kernel.org/netdev/net-next/c/f9c141fc3339 You are awesome, thank you!
diff --git a/net/rds/ib.h b/net/rds/ib.h index 2ba71102b1f1..8ef3178ed4d6 100644 --- a/net/rds/ib.h +++ b/net/rds/ib.h @@ -369,9 +369,6 @@ int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp); void rds_ib_conn_free(void *arg); int rds_ib_conn_path_connect(struct rds_conn_path *cp); void rds_ib_conn_path_shutdown(struct rds_conn_path *cp); -void rds_ib_state_change(struct sock *sk); -int rds_ib_listen_init(void); -void rds_ib_listen_stop(void); __printf(2, 3) void __rds_ib_conn_error(struct rds_connection *conn, const char *, ...); int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id, @@ -402,7 +399,6 @@ void rds_ib_inc_free(struct rds_incoming *inc); int rds_ib_inc_copy_to_user(struct rds_incoming *inc, struct iov_iter *to); void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic, struct ib_wc *wc, struct rds_ib_ack_state *state); -void rds_ib_recv_tasklet_fn(unsigned long data); void rds_ib_recv_init_ring(struct rds_ib_connection *ic); void rds_ib_recv_clear_ring(struct rds_ib_connection *ic); void rds_ib_recv_init_ack(struct rds_ib_connection *ic);
Commit f4f943c958a2 ("RDS: IB: ack more receive completions to improve performance") removed rds_ib_recv_tasklet_fn() implementation but not the declaration. And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but never implemented other functions. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org> --- net/rds/ib.h | 4 ---- 1 file changed, 4 deletions(-)