| Message ID | 20240731014313.113417-2-hpchen0nvt@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for nuvoton ma35 usb2 phy | expand |
On 31/07/2024 03:43, Hui-Ping Chen wrote: > Add dt-bindings for USB2 PHY found on the Nuvoton MA35 SoC. > > Signed-off-by: Hui-Ping Chen <hpchen0nvt@gmail.com> > --- > .../bindings/phy/nuvoton,ma35d1-usb2-phy.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml > new file mode 100644 > index 000000000000..88e297ba4ecf > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/nuvoton,ma35d1-usb2-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35D1 USB2 phy > + > +maintainers: > + - Hui-Ping Chen <hpchen0nvt@gmail.com> > + > +properties: > + compatible: > + enum: > + - nuvoton,ma35d1-usb2-phy > + > + "#phy-cells": > + const: 0 > + > + clocks: > + maxItems: 1 > + > + nuvoton,sys: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle of the system-management node. > + This driver has some status bits located in the sys, Do not reference drivers, but hardware. > + it is necessary to reference the sys link. This tells me nothing. You must be specific - WHAT IS THE PURPOSE of this syscon usage in USB2 PHY? Best regards, Krzysztof
Dear Krzysztof, Thank you for your reply. On 2024/7/31 下午 01:31, Krzysztof Kozlowski wrote: > On 31/07/2024 03:43, Hui-Ping Chen wrote: >> Add dt-bindings for USB2 PHY found on the Nuvoton MA35 SoC. >> >> Signed-off-by: Hui-Ping Chen <hpchen0nvt@gmail.com> >> --- >> .../bindings/phy/nuvoton,ma35d1-usb2-phy.yaml | 47 +++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml >> >> diff --git a/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml >> new file mode 100644 >> index 000000000000..88e297ba4ecf >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml >> @@ -0,0 +1,47 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/phy/nuvoton,ma35d1-usb2-phy.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Nuvoton MA35D1 USB2 phy >> + >> +maintainers: >> + - Hui-Ping Chen <hpchen0nvt@gmail.com> >> + >> +properties: >> + compatible: >> + enum: >> + - nuvoton,ma35d1-usb2-phy >> + >> + "#phy-cells": >> + const: 0 >> + >> + clocks: >> + maxItems: 1 >> + >> + nuvoton,sys: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + phandle of the system-management node. >> + This driver has some status bits located in the sys, > Do not reference drivers, but hardware. Okay. I will revise the description. >> + it is necessary to reference the sys link. > This tells me nothing. You must be specific - WHAT IS THE PURPOSE of > this syscon usage in USB2 PHY? Sorry, I misunderstood. I will correct the description. Thank you for the reminder. > Best regards, > Krzysztof Best regards, Hui-Ping Chen
diff --git a/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml new file mode 100644 index 000000000000..88e297ba4ecf --- /dev/null +++ b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/nuvoton,ma35d1-usb2-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton MA35D1 USB2 phy + +maintainers: + - Hui-Ping Chen <hpchen0nvt@gmail.com> + +properties: + compatible: + enum: + - nuvoton,ma35d1-usb2-phy + + "#phy-cells": + const: 0 + + clocks: + maxItems: 1 + + nuvoton,sys: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle of the system-management node. + This driver has some status bits located in the sys, + it is necessary to reference the sys link. + +required: + - compatible + - "#phy-cells" + - clocks + - nuvoton,sys + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h> + + usb_phy: usb-phy { + compatible = "nuvoton,ma35d1-usb2-phy"; + clocks = <&clk USBD_GATE>; + nuvoton,sys = <&sys>; + #phy-cells = <0>; + };
Add dt-bindings for USB2 PHY found on the Nuvoton MA35 SoC. Signed-off-by: Hui-Ping Chen <hpchen0nvt@gmail.com> --- .../bindings/phy/nuvoton,ma35d1-usb2-phy.yaml | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml