mbox series

[0/3] Bluetooth: hci_qca: fix post merge window regressions

Message ID 20240731-hci_qca_fixes-v1-0-59dad830b243@linaro.org (mailing list archive)
Headers show
Series Bluetooth: hci_qca: fix post merge window regressions | expand

Message

Bartosz Golaszewski July 31, 2024, 3:20 p.m. UTC
Here are the fixes for regressions reported by Wren and Dmitry. I could
reproduce the crash on db820c and so I was able to test it but patch 2/3
could use a Tested-by from Wren on QCA6390.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (3):
      Bluetooth: hci_qca: don't call pwrseq_power_off() twice for QCA6390
      Bluetooth: hci_qca: fix QCA6390 support on non-DT platforms
      Bluetooth: hci_qca: fix a NULL-pointer derefence at shutdown

 drivers/bluetooth/hci_qca.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)
---
base-commit: cd19ac2f903276b820f5d0d89de0c896c27036ed
change-id: 20240731-hci_qca_fixes-8e7a8ed3ad83

Best regards,

Comments

Luiz Augusto von Dentz July 31, 2024, 4:32 p.m. UTC | #1
Hi Wren,

On Wed, Jul 31, 2024 at 11:21 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> Here are the fixes for regressions reported by Wren and Dmitry. I could
> reproduce the crash on db820c and so I was able to test it but patch 2/3
> could use a Tested-by from Wren on QCA6390.

Can you give this set a try and report back?

> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Bartosz Golaszewski (3):
>       Bluetooth: hci_qca: don't call pwrseq_power_off() twice for QCA6390
>       Bluetooth: hci_qca: fix QCA6390 support on non-DT platforms
>       Bluetooth: hci_qca: fix a NULL-pointer derefence at shutdown
>
>  drivers/bluetooth/hci_qca.c | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
> ---
> base-commit: cd19ac2f903276b820f5d0d89de0c896c27036ed
> change-id: 20240731-hci_qca_fixes-8e7a8ed3ad83
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
Wren Turkal Aug. 1, 2024, 3:57 a.m. UTC | #2
Luiz and Bartosz,

On 7/31/24 9:32 AM, Luiz Augusto von Dentz wrote:
> Hi Wren,
> 
> On Wed, Jul 31, 2024 at 11:21 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>
>> Here are the fixes for regressions reported by Wren and Dmitry. I could
>> reproduce the crash on db820c and so I was able to test it but patch 2/3
>> could use a Tested-by from Wren on QCA6390.
> 
> Can you give this set a try and report back?

I'll give it a shot tonight or tomorrow and report back.

Bartosz, thanks for looking into this.

>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>> ---
>> Bartosz Golaszewski (3):
>>        Bluetooth: hci_qca: don't call pwrseq_power_off() twice for QCA6390
>>        Bluetooth: hci_qca: fix QCA6390 support on non-DT platforms
>>        Bluetooth: hci_qca: fix a NULL-pointer derefence at shutdown
>>
>>   drivers/bluetooth/hci_qca.c | 19 +++++++++----------
>>   1 file changed, 9 insertions(+), 10 deletions(-)
>> ---
>> base-commit: cd19ac2f903276b820f5d0d89de0c896c27036ed
>> change-id: 20240731-hci_qca_fixes-8e7a8ed3ad83
>>
>> Best regards,
>> --
>> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>
> 
>
Wren Turkal Aug. 1, 2024, 7:23 a.m. UTC | #3
Bartosz,

On 7/31/24 8:57 PM, Wren Turkal wrote:
> Luiz and Bartosz,
> 
> On 7/31/24 9:32 AM, Luiz Augusto von Dentz wrote:
>> Hi Wren,
>>
>> On Wed, Jul 31, 2024 at 11:21 AM Bartosz Golaszewski <brgl@bgdev.pl> 
>> wrote:
>>>
>>> Here are the fixes for regressions reported by Wren and Dmitry. I could
>>> reproduce the crash on db820c and so I was able to test it but patch 2/3
>>> could use a Tested-by from Wren on QCA6390.
>>
>> Can you give this set a try and report back?
> 
> I'll give it a shot tonight or tomorrow and report back.
> 
> Bartosz, thanks for looking into this.
> 
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>> ---
>>> Bartosz Golaszewski (3):
>>>        Bluetooth: hci_qca: don't call pwrseq_power_off() twice for 
>>> QCA6390
>>>        Bluetooth: hci_qca: fix QCA6390 support on non-DT platforms
>>>        Bluetooth: hci_qca: fix a NULL-pointer derefence at shutdown
>>>
>>>   drivers/bluetooth/hci_qca.c | 19 +++++++++----------
>>>   1 file changed, 9 insertions(+), 10 deletions(-)
>>> ---
>>> base-commit: cd19ac2f903276b820f5d0d89de0c896c27036ed
>>> change-id: 20240731-hci_qca_fixes-8e7a8ed3ad83
>>>
>>> Best regards,
>>> -- 
>>> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>
>>
> 

+Tested-by: Wren Turkal <wt@penguintechs.org>

It works. Thanks for chasing this down.

wt
patchwork-bot+bluetooth@kernel.org Aug. 1, 2024, 8:20 a.m. UTC | #4
Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 31 Jul 2024 17:20:47 +0200 you wrote:
> Here are the fixes for regressions reported by Wren and Dmitry. I could
> reproduce the crash on db820c and so I was able to test it but patch 2/3
> could use a Tested-by from Wren on QCA6390.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Bartosz Golaszewski (3):
>       Bluetooth: hci_qca: don't call pwrseq_power_off() twice for QCA6390
>       Bluetooth: hci_qca: fix QCA6390 support on non-DT platforms
>       Bluetooth: hci_qca: fix a NULL-pointer derefence at shutdown
> 
> [...]

Here is the summary with links:
  - [1/3] Bluetooth: hci_qca: don't call pwrseq_power_off() twice for QCA6390
    https://git.kernel.org/bluetooth/bluetooth-next/c/3c9b2c902da0
  - [2/3] Bluetooth: hci_qca: fix QCA6390 support on non-DT platforms
    https://git.kernel.org/bluetooth/bluetooth-next/c/786cd197c92b
  - [3/3] Bluetooth: hci_qca: fix a NULL-pointer derefence at shutdown
    https://git.kernel.org/bluetooth/bluetooth-next/c/9fba2e3f4ac1

You are awesome, thank you!