| Message ID | 20240731135718.429604-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 549d38852f665d8251b2c0c0e8c9f3d5574ac99b |
| Headers | show |
| Series | [BlueZ,v1,1/4] client/player: Fix not setting config target_latency with edpoint.config | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (87>80): "[BlueZ,v1,1/4] client/player: Fix not setting config target_latency with edpoint.config" |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING monitor/att.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.src/shared/bap.c:288:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:288:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:288:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=875511 ---Test result--- Test Summary: CheckPatch PASS 1.87 seconds GitLint FAIL 4.72 seconds BuildEll PASS 25.15 seconds BluezMake PASS 1690.11 seconds MakeCheck PASS 13.56 seconds MakeDistcheck PASS 177.39 seconds CheckValgrind PASS 251.75 seconds CheckSmatch WARNING 352.40 seconds bluezmakeextell PASS 119.37 seconds IncrementalBuild PASS 6230.29 seconds ScanBuild PASS 981.65 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [BlueZ,v1,1/4] client/player: Fix not setting config target_latency with edpoint.config WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (87>80): "[BlueZ,v1,1/4] client/player: Fix not setting config target_latency with edpoint.config" ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: monitor/att.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.src/shared/bap.c:288:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:288:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:288:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 31 Jul 2024 14:57:15 +0100 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > This fixes not setting target_latency with endpoint.config command. > --- > client/player.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Here is the summary with links: - [BlueZ,v1,1/4] client/player: Fix not setting config target_latency with edpoint.config https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=549d38852f66 - [BlueZ,v1,2/4] monitor: Fix crash parsing notification (no matching commit) - [BlueZ,v1,3/4] shared/bap: Fix not setting metadata (no matching commit) - [BlueZ,v1,4/4] bap: Fix not setting metatada (no matching commit) You are awesome, thank you!
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 31 Jul 2024 14:57:15 +0100 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > This fixes not setting target_latency with endpoint.config command. > --- > client/player.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Here is the summary with links: - [BlueZ,v1,1/4] client/player: Fix not setting config target_latency with edpoint.config (no matching commit) - [BlueZ,v1,2/4] monitor: Fix crash parsing notification https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8a708aa5f046 - [BlueZ,v1,3/4] shared/bap: Fix not setting metadata https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=fe703a0058d8 - [BlueZ,v1,4/4] bap: Fix not setting metatada https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=998104507ba1 You are awesome, thank you!
diff --git a/client/player.c b/client/player.c index 3c3587f2c..93d6b62e2 100644 --- a/client/player.c +++ b/client/player.c @@ -1790,9 +1790,9 @@ static void append_ucast_qos(DBusMessageIter *iter, struct endpoint_config *cfg) DBUS_TYPE_UINT32, &qos->delay); if (cfg->target_latency) { - bt_shell_printf("TargetLatency 0x%02x\n", qos->target_latency); + bt_shell_printf("TargetLatency 0x%02x\n", cfg->target_latency); g_dbus_dict_append_entry(iter, "TargetLatency", DBUS_TYPE_BYTE, - &qos->target_latency); + &cfg->target_latency); } append_io_qos(iter, &qos->io_qos); @@ -3765,6 +3765,7 @@ static void cmd_config_endpoint(int argc, char *argv[]) /* Copy capabilities */ util_iov_append(cfg->caps, preset->data.iov_base, preset->data.iov_len); + cfg->target_latency = preset->target_latency; /* Set QoS parameters */ cfg->qos = preset->qos; @@ -3960,7 +3961,7 @@ static void custom_target_latency(const char *input, void *user_data) else if (!strcasecmp(input, "Balance")) p->target_latency = 0x02; else if (!strcasecmp(input, "High")) - p->target_latency = 0x02; + p->target_latency = 0x03; else { char *endptr = NULL;
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> This fixes not setting target_latency with endpoint.config command. --- client/player.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)