mbox series

[v2,0/2] arm64: dts: renesas: Add CAN-FD support for R-Car V4M and Gray Hawk Single

Message ID cover.1722519717.git.geert+renesas@glider.be (mailing list archive)
Headers show
Series arm64: dts: renesas: Add CAN-FD support for R-Car V4M and Gray Hawk Single | expand

Message

Geert Uytterhoeven Aug. 1, 2024, 1:54 p.m. UTC
Hi all,

This patch series adds support for CAN-FD on the R-Car V4M SoC and the
Gray Hawk Single development board.

The CAN-FD module on R-Car V4M is very similar to the one on R-Car V4H,
but differs in some hardware parameters, as reflected by the Parameter
Status Information part of the Global IP Version Register.  However,
none of this parameterization should have any impact on the driver, as
the driver does not access any register that is impacted by the
parameterization (except for the number of channels).

Just like on R-Car V4H and on the White Hawk development board, channels
0 and 1 work fine, while channel 2 does not seem to work at all, and
channel 3 works for transmit only.  Hence this patch keeps channels 2
and 3 disabled.

Changes compared to v1[1]:
  - Spun off clock and DT binding patches,
  - Add missing pinctrl-names,
  - Correct TJR1443AT Enable GPIO,
  - Reword now channels 0 and 1 work.

I plan to queue this is renesas-devel for v6.12.

Thanks for your comments!

[1] https://lore.kernel.org/cover.1715956819.git.geert+renesas@glider.be

Duy Nguyen (1):
  arm64: dts: renesas: r8a779h0: Add CAN-FD node

Geert Uytterhoeven (1):
  arm64: dts: renesas: gray-hawk-single: Add CAN-FD support

 .../dts/renesas/r8a779h0-gray-hawk-single.dts | 41 +++++++++++++++++++
 arch/arm64/boot/dts/renesas/r8a779h0.dtsi     | 41 +++++++++++++++++++
 2 files changed, 82 insertions(+)

Comments

Rob Herring (Arm) Aug. 1, 2024, 3:29 p.m. UTC | #1
On Thu, 01 Aug 2024 15:54:34 +0200, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> This patch series adds support for CAN-FD on the R-Car V4M SoC and the
> Gray Hawk Single development board.
> 
> The CAN-FD module on R-Car V4M is very similar to the one on R-Car V4H,
> but differs in some hardware parameters, as reflected by the Parameter
> Status Information part of the Global IP Version Register.  However,
> none of this parameterization should have any impact on the driver, as
> the driver does not access any register that is impacted by the
> parameterization (except for the number of channels).
> 
> Just like on R-Car V4H and on the White Hawk development board, channels
> 0 and 1 work fine, while channel 2 does not seem to work at all, and
> channel 3 works for transmit only.  Hence this patch keeps channels 2
> and 3 disabled.
> 
> Changes compared to v1[1]:
>   - Spun off clock and DT binding patches,
>   - Add missing pinctrl-names,
>   - Correct TJR1443AT Enable GPIO,
>   - Reword now channels 0 and 1 work.
> 
> I plan to queue this is renesas-devel for v6.12.
> 
> Thanks for your comments!
> 
> [1] https://lore.kernel.org/cover.1715956819.git.geert+renesas@glider.be
> 
> Duy Nguyen (1):
>   arm64: dts: renesas: r8a779h0: Add CAN-FD node
> 
> Geert Uytterhoeven (1):
>   arm64: dts: renesas: gray-hawk-single: Add CAN-FD support
> 
>  .../dts/renesas/r8a779h0-gray-hawk-single.dts | 41 +++++++++++++++++++
>  arch/arm64/boot/dts/renesas/r8a779h0.dtsi     | 41 +++++++++++++++++++
>  2 files changed, 82 insertions(+)
> 
> --
> 2.34.1
> 
> Gr{oetje,eeting}s,
> 
> 						Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y renesas/r8a779h0-gray-hawk-single.dtb' for cover.1722519717.git.geert+renesas@glider.be:

arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dtb: can@e6660000: compatible: 'oneOf' conditional failed, one must be fixed:
	'renesas,r8a779h0-canfd' is not one of ['renesas,r8a774a1-canfd', 'renesas,r8a774b1-canfd', 'renesas,r8a774c0-canfd', 'renesas,r8a774e1-canfd', 'renesas,r8a7795-canfd', 'renesas,r8a7796-canfd', 'renesas,r8a77961-canfd', 'renesas,r8a77965-canfd', 'renesas,r8a77970-canfd', 'renesas,r8a77980-canfd', 'renesas,r8a77990-canfd', 'renesas,r8a77995-canfd']
	'renesas,r8a779h0-canfd' is not one of ['renesas,r8a779a0-canfd', 'renesas,r8a779g0-canfd']
	'renesas,r8a779h0-canfd' is not one of ['renesas,r9a07g043-canfd', 'renesas,r9a07g044-canfd', 'renesas,r9a07g054-canfd']
	'renesas,rcar-gen3-canfd' was expected
	'renesas,rzg2l-canfd' was expected
	from schema $id: http://devicetree.org/schemas/net/can/renesas,rcar-canfd.yaml#
arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dtb: can@e6660000: Unevaluated properties are not allowed ('compatible' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/can/renesas,rcar-canfd.yaml#