| Message ID | xmqq7cd0ulen.fsf_-_@gitster.g (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7c7516b8db8b2e6d03379c0e81292cc11e7836bf |
| Headers | show |
| Series | t0018: remove leftover debugging cruft | expand |
On Thursday, August 1, 2024 2:51 PM, Junio C Hamano wrote: >The actual file is copied out to /tmp, presumably so that the tester can inspect it >after the test is done, which may have been a useful debugging aid. > >But in the final shape of the test suite, such a code should not exist. We cannot >even assume that we are allowed to write into /tmp (our TMPDIR may not even be >pointing at it) or read from it for that matter. > >Noticed-by: Randall S. Becker <rsbecker@nexbridge.com> >Signed-off-by: Junio C Hamano <gitster@pobox.com> >--- > t/t0018-advice.sh | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/t/t0018-advice.sh b/t/t0018-advice.sh index b02448ea16..040a08be07 >100755 >--- a/t/t0018-advice.sh >+++ b/t/t0018-advice.sh >@@ -93,7 +93,6 @@ EOF > >README && > GIT_ADVICE=true git status > ) >actual && >- cat actual > /tmp/actual && > test_cmp expect actual > ' > >-- >2.46.0-179-g92bab5172e Verified to work correctly. Thanks.
diff --git a/t/t0018-advice.sh b/t/t0018-advice.sh index b02448ea16..040a08be07 100755 --- a/t/t0018-advice.sh +++ b/t/t0018-advice.sh @@ -93,7 +93,6 @@ EOF >README && GIT_ADVICE=true git status ) >actual && - cat actual > /tmp/actual && test_cmp expect actual '
The actual file is copied out to /tmp, presumably so that the tester can inspect it after the test is done, which may have been a useful debugging aid. But in the final shape of the test suite, such a code should not exist. We cannot even assume that we are allowed to write into /tmp (our TMPDIR may not even be pointing at it) or read from it for that matter. Noticed-by: Randall S. Becker <rsbecker@nexbridge.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/t0018-advice.sh | 1 - 1 file changed, 1 deletion(-)