| Message ID | 20240628-dpu-msm8953-msm8996-v1-0-a31c77248db7@mainlining.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add MSM8996/MSM8953 dpu catalog | expand |
Should i resend this patch set? On June 28, 2024 4:39:38 PM GMT+02:00, "Barnabás Czémán" <barnabas.czeman@mainlining.org> wrote: >This patch series add dpu support for MSM8996/MSM8953 devices. > >Note, by default these platforms are still handled by the MDP5 driver >unless the `msm.prefer_mdp5=false' parameter is provided. > >Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> >--- >Dmitry Baryshkov (1): > drm/msm/dpu: add support for MSM8953 > >Konrad Dybcio (1): > drm/msm/dpu: Add MSM8996 support > > .../drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 218 +++++++++++++ > .../drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h | 348 +++++++++++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 106 +++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + > drivers/gpu/drm/msm/msm_drv.c | 2 + > 6 files changed, 678 insertions(+) >--- >base-commit: df9574a57d02b265322e77fb8628d4d33641dda9 >change-id: 20240528-dpu-msm8953-msm8996-5d0fb7e387b8 > >Best regards,
On Thu, Aug 01, 2024 at 06:45:03PM GMT, Barnabás Czémán wrote: > Should i resend this patch set? No. It was the merge window. > > On June 28, 2024 4:39:38 PM GMT+02:00, "Barnabás Czémán" <barnabas.czeman@mainlining.org> wrote: > >This patch series add dpu support for MSM8996/MSM8953 devices. > > > >Note, by default these platforms are still handled by the MDP5 driver > >unless the `msm.prefer_mdp5=false' parameter is provided. > > > >Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> > >--- > >Dmitry Baryshkov (1): > > drm/msm/dpu: add support for MSM8953 > > > >Konrad Dybcio (1): > > drm/msm/dpu: Add MSM8996 support > > > > .../drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 218 +++++++++++++ > > .../drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h | 348 +++++++++++++++++++++ > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 106 +++++++ > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 + > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + > > drivers/gpu/drm/msm/msm_drv.c | 2 + > > 6 files changed, 678 insertions(+) > >--- > >base-commit: df9574a57d02b265322e77fb8628d4d33641dda9 > >change-id: 20240528-dpu-msm8953-msm8996-5d0fb7e387b8 > > > >Best regards,
On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: > This patch series add dpu support for MSM8996/MSM8953 devices. > > Note, by default these platforms are still handled by the MDP5 driver > unless the `msm.prefer_mdp5=false' parameter is provided. Could you please provide a summary of features actually tested with the DPU driver? Have you tested YUV output? Have you tested RGB planes? Which LMs have you tested? > Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> > --- > Dmitry Baryshkov (1): > drm/msm/dpu: add support for MSM8953 > > Konrad Dybcio (1): > drm/msm/dpu: Add MSM8996 support > > .../drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 218 +++++++++++++ > .../drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h | 348 +++++++++++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 106 +++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + > drivers/gpu/drm/msm/msm_drv.c | 2 + > 6 files changed, 678 insertions(+) > --- > base-commit: df9574a57d02b265322e77fb8628d4d33641dda9 > change-id: 20240528-dpu-msm8953-msm8996-5d0fb7e387b8 > > Best regards, > -- > Barnabás Czémán <barnabas.czeman@mainlining.org> >
On 2024-08-01 21:25, Dmitry Baryshkov wrote: > On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: >> This patch series add dpu support for MSM8996/MSM8953 devices. >> >> Note, by default these platforms are still handled by the MDP5 driver >> unless the `msm.prefer_mdp5=false' parameter is provided. > > Could you please provide a summary of features actually tested with the > DPU driver? Have you tested YUV output? Have you tested RGB planes? > Which LMs have you tested? > It was tested in usage on multiple msm8953 (sdm450, msm8953, sdm632) devices like - Samsung A6+ LTE (sdm450, cmd panel) - Xiaomi Redmi 7 (sdm632, video panel) - Xiaomi Redmi 5 (sdm450, video panel) - Xiaomi Redmi 5 Plus (msm8953, video panel) - Xiaomi Redmi Note 4 (msm8953, video panel) - Xiaomi Mi A1 (msm8953, video panel) - Xiaomi Mi A2 Lite/Redmi 6 Pro (msm8953, video panel) - Xiaomi Redmi S2 (msm8953, video panel) - Motorola G5 Plus (msm8953, video panel) and couple of msm8996 devices like - Xiaomi Mi Note 2 (video panel) - Xiaomi Mi5s (cmd panel) It was tested with glmark2 and with mobile shells like plasma-mobile (dpu fixes night light) and phosh. If you can help how can I test specific features i will do it. How can I find out which LM is in use? >> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> >> --- >> Dmitry Baryshkov (1): >> drm/msm/dpu: add support for MSM8953 >> >> Konrad Dybcio (1): >> drm/msm/dpu: Add MSM8996 support >> >> .../drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 218 >> +++++++++++++ >> .../drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h | 348 >> +++++++++++++++++++++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 106 +++++++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 + >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + >> drivers/gpu/drm/msm/msm_drv.c | 2 + >> 6 files changed, 678 insertions(+) >> --- >> base-commit: df9574a57d02b265322e77fb8628d4d33641dda9 >> change-id: 20240528-dpu-msm8953-msm8996-5d0fb7e387b8 >> >> Best regards, >> -- >> Barnabás Czémán <barnabas.czeman@mainlining.org> >>
On 2024-08-01 21:25, Dmitry Baryshkov wrote: > On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: >> This patch series add dpu support for MSM8996/MSM8953 devices. >> >> Note, by default these platforms are still handled by the MDP5 driver >> unless the `msm.prefer_mdp5=false' parameter is provided. > > Could you please provide a summary of features actually tested with the > DPU driver? Have you tested YUV output? Have you tested RGB planes? > Which LMs have you tested? How can i check specific feature? I have set echo 0x32 > /sys/module/drm/parameters/debug DRIVER+ATOMIC+VERBOSE ATOMIC log is pretty verbose and big this way. For lm i have found this kind of message in log: [ 1027.577132] [drm:_dpu_crtc_blend_setup [msm]] lm 0, op_mode 0x2, ctl 0 > >> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> >> --- >> Dmitry Baryshkov (1): >> drm/msm/dpu: add support for MSM8953 >> >> Konrad Dybcio (1): >> drm/msm/dpu: Add MSM8996 support >> >> .../drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 218 >> +++++++++++++ >> .../drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h | 348 >> +++++++++++++++++++++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 106 +++++++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 + >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + >> drivers/gpu/drm/msm/msm_drv.c | 2 + >> 6 files changed, 678 insertions(+) >> --- >> base-commit: df9574a57d02b265322e77fb8628d4d33641dda9 >> change-id: 20240528-dpu-msm8953-msm8996-5d0fb7e387b8 >> >> Best regards, >> -- >> Barnabás Czémán <barnabas.czeman@mainlining.org> >>
On Wed, 25 Sept 2024 at 23:28, <barnabas.czeman@mainlining.org> wrote: > > On 2024-08-01 21:25, Dmitry Baryshkov wrote: > > On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: > >> This patch series add dpu support for MSM8996/MSM8953 devices. > >> > >> Note, by default these platforms are still handled by the MDP5 driver > >> unless the `msm.prefer_mdp5=false' parameter is provided. > > > > Could you please provide a summary of features actually tested with the > > DPU driver? Have you tested YUV output? Have you tested RGB planes? > > Which LMs have you tested? > > How can i check specific feature? > I have set echo 0x32 > /sys/module/drm/parameters/debug > DRIVER+ATOMIC+VERBOSE ATOMIC log is pretty verbose and big this way. > For lm i have found this kind of message in log: [ 1027.577132] > [drm:_dpu_crtc_blend_setup [msm]] lm 0, op_mode 0x2, ctl 0 I think the easiest way to test other LMs is by temporarily commenting out LM_0 / LM_1 in the lms array. > > > >> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> > >> --- > >> Dmitry Baryshkov (1): > >> drm/msm/dpu: add support for MSM8953 > >> > >> Konrad Dybcio (1): > >> drm/msm/dpu: Add MSM8996 support > >> > >> .../drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 218 > >> +++++++++++++ > >> .../drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h | 348 > >> +++++++++++++++++++++ > >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 106 +++++++ > >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 + > >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + > >> drivers/gpu/drm/msm/msm_drv.c | 2 + > >> 6 files changed, 678 insertions(+) > >> --- > >> base-commit: df9574a57d02b265322e77fb8628d4d33641dda9 > >> change-id: 20240528-dpu-msm8953-msm8996-5d0fb7e387b8 > >> > >> Best regards, > >> -- > >> Barnabás Czémán <barnabas.czeman@mainlining.org> > >>
On 2024-08-01 21:25, Dmitry Baryshkov wrote: > On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: >> This patch series add dpu support for MSM8996/MSM8953 devices. >> >> Note, by default these platforms are still handled by the MDP5 driver >> unless the `msm.prefer_mdp5=false' parameter is provided. > > Could you please provide a summary of features actually tested with the > DPU driver? Have you tested YUV output? Have you tested RGB planes? I have checked all planes they are working fine. > Which LMs have you tested? I have done some more testing and msm8953 LMs are fine but i have found out on msmm8996 LM_3 and LM_4 is not working as i see in downstream sde code they are not exists. This kind of messages i got for LM_3 and LM_4 [ 34.751091] [drm:_dpu_rm_make_reservation] [dpu error]unable to find appropriate mixers [ 34.751112] [drm:dpu_rm_reserve] [dpu error]failed to reserve hw resources: -119 > >> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> >> --- >> Dmitry Baryshkov (1): >> drm/msm/dpu: add support for MSM8953 >> >> Konrad Dybcio (1): >> drm/msm/dpu: Add MSM8996 support >> >> .../drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 218 >> +++++++++++++ >> .../drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h | 348 >> +++++++++++++++++++++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 106 +++++++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 + >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + >> drivers/gpu/drm/msm/msm_drv.c | 2 + >> 6 files changed, 678 insertions(+) >> --- >> base-commit: df9574a57d02b265322e77fb8628d4d33641dda9 >> change-id: 20240528-dpu-msm8953-msm8996-5d0fb7e387b8 >> >> Best regards, >> -- >> Barnabás Czémán <barnabas.czeman@mainlining.org> >>
On Fri, 27 Sept 2024 at 17:39, <barnabas.czeman@mainlining.org> wrote: > > On 2024-08-01 21:25, Dmitry Baryshkov wrote: > > On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: > >> This patch series add dpu support for MSM8996/MSM8953 devices. > >> > >> Note, by default these platforms are still handled by the MDP5 driver > >> unless the `msm.prefer_mdp5=false' parameter is provided. > > > > Could you please provide a summary of features actually tested with the > > DPU driver? Have you tested YUV output? Have you tested RGB planes? > I have checked all planes they are working fine. > > > Which LMs have you tested? > I have done some more testing and msm8953 LMs are fine but i have found > out > on msmm8996 LM_3 and LM_4 is not working as i see in downstream sde code > they are not exists. > This kind of messages i got for LM_3 and LM_4 > [ 34.751091] [drm:_dpu_rm_make_reservation] [dpu error]unable to find > appropriate mixers > [ 34.751112] [drm:dpu_rm_reserve] [dpu error]failed to reserve hw > resources: -119 I think LM_3 / LM_4 are WB-only, but I didn't have time to check that. Maybe it's easier to omit them for now. I hope to get back to those platforms during the forthcoming or the next development cycle, after (hopefully) finishing the HDMI conversion story.
On 2024-09-27 18:02, Dmitry Baryshkov wrote: > On Fri, 27 Sept 2024 at 17:39, <barnabas.czeman@mainlining.org> wrote: >> >> On 2024-08-01 21:25, Dmitry Baryshkov wrote: >> > On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: >> >> This patch series add dpu support for MSM8996/MSM8953 devices. >> >> >> >> Note, by default these platforms are still handled by the MDP5 driver >> >> unless the `msm.prefer_mdp5=false' parameter is provided. >> > >> > Could you please provide a summary of features actually tested with the >> > DPU driver? Have you tested YUV output? Have you tested RGB planes? >> I have checked all planes they are working fine. >> >> > Which LMs have you tested? >> I have done some more testing and msm8953 LMs are fine but i have >> found >> out >> on msmm8996 LM_3 and LM_4 is not working as i see in downstream sde >> code >> they are not exists. >> This kind of messages i got for LM_3 and LM_4 >> [ 34.751091] [drm:_dpu_rm_make_reservation] [dpu error]unable to >> find >> appropriate mixers >> [ 34.751112] [drm:dpu_rm_reserve] [dpu error]failed to reserve hw >> resources: -119 > > I think LM_3 / LM_4 are WB-only, but I didn't have time to check that. > Maybe it's easier to omit them for now. > > I hope to get back to those platforms during the forthcoming or the > next development cycle, after (hopefully) finishing the HDMI > conversion story. I have tested MSM8917 and MSM8937 patches they are also working fine at least with video mode panels, maybe they can be added for next iteration intr_start also should be removed from CTLs.
This patch series add dpu support for MSM8996/MSM8953 devices. Note, by default these platforms are still handled by the MDP5 driver unless the `msm.prefer_mdp5=false' parameter is provided. Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> --- Dmitry Baryshkov (1): drm/msm/dpu: add support for MSM8953 Konrad Dybcio (1): drm/msm/dpu: Add MSM8996 support .../drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 218 +++++++++++++ .../drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h | 348 +++++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 106 +++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + drivers/gpu/drm/msm/msm_drv.c | 2 + 6 files changed, 678 insertions(+) --- base-commit: df9574a57d02b265322e77fb8628d4d33641dda9 change-id: 20240528-dpu-msm8953-msm8996-5d0fb7e387b8 Best regards,