[v3,0/3] Rework mce_setup()

Message

Yazen Ghannam July 30, 2024, 6:29 p.m. UTC

Hi all,

This revision drops the topology export idea from v2. It seemed to add
more complexity than just doing a local search. 

Thanks,
Yazen

Link:
https://lkml.kernel.org/r/[e-mail]

Yazen Ghannam (3):
  x86/mce: Rename mce_setup() to mce_prep_record()
  x86/mce: Define mce_prep_record() helpers for common and per-CPU
    fields
  x86/mce: Use mce_prep_record() helpers for
    apei_smca_report_x86_error()

 arch/x86/include/asm/mce.h         |  2 +-
 arch/x86/kernel/cpu/mce/amd.c      |  2 +-
 arch/x86/kernel/cpu/mce/apei.c     | 18 +++++++-------
 arch/x86/kernel/cpu/mce/core.c     | 38 ++++++++++++++++++++----------
 arch/x86/kernel/cpu/mce/internal.h |  2 ++
 5 files changed, 38 insertions(+), 24 deletions(-)


base-commit: 1cd27e88888d54de5fefbeb0b44c26194ffa83ce

Comments

Nikolay Borisov July 31, 2024, 1:02 p.m. UTC | #1

On 30.07.24 г. 21:29 ч., Yazen Ghannam wrote:
> Hi all,
> 
> This revision drops the topology export idea from v2. It seemed to add
> more complexity than just doing a local search.
> 
> Thanks,
> Yazen
> 
> Link:
> https://lkml.kernel.org/r/[e-mail]
> 
> Yazen Ghannam (3):
>    x86/mce: Rename mce_setup() to mce_prep_record()
>    x86/mce: Define mce_prep_record() helpers for common and per-CPU
>      fields
>    x86/mce: Use mce_prep_record() helpers for
>      apei_smca_report_x86_error()
> 
>   arch/x86/include/asm/mce.h         |  2 +-
>   arch/x86/kernel/cpu/mce/amd.c      |  2 +-
>   arch/x86/kernel/cpu/mce/apei.c     | 18 +++++++-------
>   arch/x86/kernel/cpu/mce/core.c     | 38 ++++++++++++++++++++----------
>   arch/x86/kernel/cpu/mce/internal.h |  2 ++
>   5 files changed, 38 insertions(+), 24 deletions(-)
> 
> 
> base-commit: 1cd27e88888d54de5fefbeb0b44c26194ffa83ce


Reviewed-by: Nikolay Borisov <[e-mail]>

Naik, Avadhut Aug. 1, 2024, 9:02 p.m. UTC | #2

On 7/30/24 13:29, Yazen Ghannam wrote:
> Hi all,
> 
> This revision drops the topology export idea from v2. It seemed to add
> more complexity than just doing a local search. 
> 
> Thanks,
> Yazen
> 
> Link:
> https://lkml.kernel.org/r/[e-mail]
> 
> Yazen Ghannam (3):
>   x86/mce: Rename mce_setup() to mce_prep_record()
>   x86/mce: Define mce_prep_record() helpers for common and per-CPU
>     fields
>   x86/mce: Use mce_prep_record() helpers for
>     apei_smca_report_x86_error()
> 
>  arch/x86/include/asm/mce.h         |  2 +-
>  arch/x86/kernel/cpu/mce/amd.c      |  2 +-
>  arch/x86/kernel/cpu/mce/apei.c     | 18 +++++++-------
>  arch/x86/kernel/cpu/mce/core.c     | 38 ++++++++++++++++++++----------
>  arch/x86/kernel/cpu/mce/internal.h |  2 ++
>  5 files changed, 38 insertions(+), 24 deletions(-)
> 
> 
> base-commit: 1cd27e88888d54de5fefbeb0b44c26194ffa83ce

LGTM.

Reviewed-by: Avadhut Naik <[e-mail]>