| Message ID | 20240731175919.20333-4-danila@jiaxyga.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add SM8475 clock controller drivers | expand |
Hello Danila. On 7/31/24 20:59, Danila Tikhonov wrote: > Add SM8475 DISPCC bindings, which are simply a symlink to the SM8450 > bindings. Update the documentation with the new compatible. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > --- > .../devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 5 ++++- > include/dt-bindings/clock/qcom,sm8475-dispcc.h | 1 + > 2 files changed, 5 insertions(+), 1 deletion(-) > create mode 120000 include/dt-bindings/clock/qcom,sm8475-dispcc.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml > index 4794c53793a8..76f5a8cc42cc 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml > @@ -13,12 +13,15 @@ description: | > Qualcomm display clock control module provides the clocks, resets and power > domains on SM8450. > > - See also:: include/dt-bindings/clock/qcom,sm8450-dispcc.h > + See also:: > + include/dt-bindings/clock/qcom,sm8450-dispcc.h > + include/dt-bindings/clock/qcom,sm8475-dispcc.h Here a new header file is not needed. > properties: > compatible: > enum: > - qcom,sm8450-dispcc > + - qcom,sm8475-dispcc This added line shall be kept though. > clocks: > minItems: 3 > diff --git a/include/dt-bindings/clock/qcom,sm8475-dispcc.h b/include/dt-bindings/clock/qcom,sm8475-dispcc.h > new file mode 120000 > index 000000000000..21a9db2d0f09 > --- /dev/null > +++ b/include/dt-bindings/clock/qcom,sm8475-dispcc.h > @@ -0,0 +1 @@ > +qcom,sm8450-dispcc.h > \ No newline at end of file Please remove the symlink, it will not be used. -- Best wishes, Vladimir
On 31/07/2024 19:59, Danila Tikhonov wrote: > Add SM8475 DISPCC bindings, which are simply a symlink to the SM8450 > bindings. Update the documentation with the new compatible. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > --- Same comments as for patch #1. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml index 4794c53793a8..76f5a8cc42cc 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml @@ -13,12 +13,15 @@ description: | Qualcomm display clock control module provides the clocks, resets and power domains on SM8450. - See also:: include/dt-bindings/clock/qcom,sm8450-dispcc.h + See also:: + include/dt-bindings/clock/qcom,sm8450-dispcc.h + include/dt-bindings/clock/qcom,sm8475-dispcc.h properties: compatible: enum: - qcom,sm8450-dispcc + - qcom,sm8475-dispcc clocks: minItems: 3 diff --git a/include/dt-bindings/clock/qcom,sm8475-dispcc.h b/include/dt-bindings/clock/qcom,sm8475-dispcc.h new file mode 120000 index 000000000000..21a9db2d0f09 --- /dev/null +++ b/include/dt-bindings/clock/qcom,sm8475-dispcc.h @@ -0,0 +1 @@ +qcom,sm8450-dispcc.h \ No newline at end of file
Add SM8475 DISPCC bindings, which are simply a symlink to the SM8450 bindings. Update the documentation with the new compatible. Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> --- .../devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 5 ++++- include/dt-bindings/clock/qcom,sm8475-dispcc.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) create mode 120000 include/dt-bindings/clock/qcom,sm8475-dispcc.h