diff mbox series

crypto: arm64/poly1305 - move data to rodata section

Message ID 20240715072023.61032-1-justin.he@arm.com (mailing list archive)
State New, archived
Headers show
Series crypto: arm64/poly1305 - move data to rodata section | expand

Commit Message

Jia He July 15, 2024, 7:20 a.m. UTC 
When objtool gains support for ARM in the future, it may encounter issues
disassembling the following data in the .text section: 
> .Lzeros:
> .long   0,0,0,0,0,0,0,0
> .asciz  "Poly1305 for ARMv8, CRYPTOGAMS by \@dot-asm"
> .align  2

Move it to .rodata which is a more appropriate section for read-only data.

Signed-off-by: Jia He <justin.he@arm.com>
---
Inspired by commit 1253cab8a352, although currently objtool hasn't been
supported on Arm, we should do some preparation(this patch) firstly.

 arch/arm64/crypto/poly1305-armv8.pl | 3 +++
 1 file changed, 3 insertions(+)

Comments

Herbert Xu Aug. 2, 2024, 1:15 p.m. UTC | #1 
On Mon, Jul 15, 2024 at 07:20:23AM +0000, Jia He wrote:
> When objtool gains support for ARM in the future, it may encounter issues
> disassembling the following data in the .text section: 
> > .Lzeros:
> > .long   0,0,0,0,0,0,0,0
> > .asciz  "Poly1305 for ARMv8, CRYPTOGAMS by \@dot-asm"
> > .align  2
> 
> Move it to .rodata which is a more appropriate section for read-only data.
> 
> Signed-off-by: Jia He <justin.he@arm.com>
> ---
> Inspired by commit 1253cab8a352, although currently objtool hasn't been
> supported on Arm, we should do some preparation(this patch) firstly.
> 
>  arch/arm64/crypto/poly1305-armv8.pl | 3 +++
>  1 file changed, 3 insertions(+)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/arch/arm64/crypto/poly1305-armv8.pl b/arch/arm64/crypto/poly1305-armv8.pl
index cbc980fb02e3..bcb70c9541e9 100644
--- a/arch/arm64/crypto/poly1305-armv8.pl
+++ b/arch/arm64/crypto/poly1305-armv8.pl
@@ -885,10 +885,13 @@  poly1305_blocks_neon:
 	ret
 .size	poly1305_blocks_neon,.-poly1305_blocks_neon
 
+.pushsection .rodata
 .align	5
 .Lzeros:
 .long	0,0,0,0,0,0,0,0
 .asciz	"Poly1305 for ARMv8, CRYPTOGAMS by \@dot-asm"
+.popsection
+
 .align	2
 #if !defined(__KERNEL__) && !defined(_WIN64)
 .comm	OPENSSL_armcap_P,4,4