| Message ID | 20240801160915.2505610-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] arm64: dts: imx93: add lpi2c1 and child node | expand |
On 01/08/2024 18:09, Frank Li wrote: > From: Clark Wang <xiaoning.wang@nxp.com> > > Add lpi2c1 and child node for imx93-11x11-evk board. Why? What for? What are these? We see all this from the diff, so commit msg should explain why and what do you want to achieve. > > Signed-off-by: Clark Wang <xiaoning.wang@nxp.com> > Reviewed-by: Haibo Chen <haibo.chen@nxp.com> > Signed-off-by: Li Yang <leoyang.li@nxp.com> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../boot/dts/freescale/imx93-11x11-evk.dts | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > index a15987f49e8d6..dd387b820831a 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > @@ -145,6 +145,20 @@ ethphy2: ethernet-phy@2 { > }; > }; > > +&lpi2c1 { > + #address-cells = <1>; > + #size-cells = <0>; > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lpi2c1>; > + status = "okay"; > + > + lsm6dsm@6a { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof
On Fri, Aug 02, 2024 at 09:25:54AM +0200, Krzysztof Kozlowski wrote: > On 01/08/2024 18:09, Frank Li wrote: > > From: Clark Wang <xiaoning.wang@nxp.com> > > > > Add lpi2c1 and child node for imx93-11x11-evk board. > > Why? What for? What are these? We see all this from the diff, so commit > msg should explain why and what do you want to achieve. I really don't know how to explain why/what for these straing forward thing, hardware board has such component, just add it dts file. > > > > > Signed-off-by: Clark Wang <xiaoning.wang@nxp.com> > > Reviewed-by: Haibo Chen <haibo.chen@nxp.com> > > Signed-off-by: Li Yang <leoyang.li@nxp.com> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > .../boot/dts/freescale/imx93-11x11-evk.dts | 21 +++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > index a15987f49e8d6..dd387b820831a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > @@ -145,6 +145,20 @@ ethphy2: ethernet-phy@2 { > > }; > > }; > > > > +&lpi2c1 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + clock-frequency = <400000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_lpi2c1>; > > + status = "okay"; > > + > > + lsm6dsm@6a { > > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation I really sorry, I forget it again. Frank > > > > > Best regards, > Krzysztof >
Am 02.08.24 um 16:31 schrieb Frank Li: > On Fri, Aug 02, 2024 at 09:25:54AM +0200, Krzysztof Kozlowski wrote: >> On 01/08/2024 18:09, Frank Li wrote: >>> From: Clark Wang <xiaoning.wang@nxp.com> >>> >>> Add lpi2c1 and child node for imx93-11x11-evk board. >> Why? What for? What are these? We see all this from the diff, so commit >> msg should explain why and what do you want to achieve. > I really don't know how to explain why/what for these straing forward > thing, hardware board has such component, just add it dts file. The i.MX93 11x11 EVK has a ST LSM6DSO connected to I2C, which a is 6-axis IMU (inertial measurement unit = accelerometer & gyroscope). So add the missing parts to the DTS file.
On 02/08/2024 16:31, Frank Li wrote: > On Fri, Aug 02, 2024 at 09:25:54AM +0200, Krzysztof Kozlowski wrote: >> On 01/08/2024 18:09, Frank Li wrote: >>> From: Clark Wang <xiaoning.wang@nxp.com> >>> >>> Add lpi2c1 and child node for imx93-11x11-evk board. >> >> Why? What for? What are these? We see all this from the diff, so commit >> msg should explain why and what do you want to achieve. > > I really don't know how to explain why/what for these straing forward > thing, hardware board has such component, just add it dts file. You can explain what you are adding in terms of hardware. "child node" is really useless description. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts index a15987f49e8d6..dd387b820831a 100644 --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts @@ -145,6 +145,20 @@ ethphy2: ethernet-phy@2 { }; }; +&lpi2c1 { + #address-cells = <1>; + #size-cells = <0>; + clock-frequency = <400000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpi2c1>; + status = "okay"; + + lsm6dsm@6a { + compatible = "st,lsm6dso"; + reg = <0x6a>; + }; +}; + &lpi2c2 { #address-cells = <1>; #size-cells = <0>; @@ -508,6 +522,13 @@ MX93_PAD_DAP_TCLK_SWCLK__LPUART5_CTS_B 0x31e >; }; + pinctrl_lpi2c1: lpi2c1grp { + fsl,pins = < + MX93_PAD_I2C1_SCL__LPI2C1_SCL 0x40000b9e + MX93_PAD_I2C1_SDA__LPI2C1_SDA 0x40000b9e + >; + }; + pinctrl_lpi2c2: lpi2c2grp { fsl,pins = < MX93_PAD_I2C2_SCL__LPI2C2_SCL 0x40000b9e