| Message ID | Zqy4wY0Of8noDqxt@shell.armlinux.org.uk (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: stmmac: convert stmmac "pcs" to phylink | expand |
On Fri, Aug 02, 2024 at 11:45:21AM GMT, Russell King (Oracle) wrote: > Hi, > > This is version 3 of the series switching stmmac to use phylink PCS > isntead of going behind phylink's back. > > Changes since version 2: > - Adopted some of Serge's feedback. > - New patch: adding ethqos_pcs_set_inband() for qcom-ethqos so we > have one place to modify for AN control rather than many. > - New patch: pass the stmmac_priv structure into the pcs_set_ane() > method. > - New patch: remove pcs_get_adv_lp() early, as this is only for TBI > and RTBI, support for which we dropped in an already merged patch. > - Provide stmmac_pcs structure to encapsulate the pointer to > stmmac_priv, PCS MMIO address pointer and phylink_pcs structure. > - Restructure dwmac_pcs_config() so we can eventually share code > with dwmac_ctrl_ane(). > - New patch: move dwmac_ctrl_ane() into stmmac_pcs.c, and share code. > - New patch: pass the stmmac_pcs structure into dwmac_pcs_isr(). > - New patch: similar to Serge's patch, rename the PCS registers, but > use STMMAC_PCS_ as the prefix rather than just PCS_ which is too > generic. > - New patch: incorporate "net: stmmac: Activate Inband/PCS flag > based on the selected iface" from Serge. > > On the subject of whether we should have two PCS instances, I > experimented with that and have now decided against it. Instead, > dwmac_pcs_config() now tests whether we need to fiddle with the > PCS control register or not. > > Note that I prefer not to have multiple layers of indirection, but > instead prefer a library-style approach, which is why I haven't > turned the PCS support into something that's self contained with > a method in the MAC driver to grab the RGSMII status. > Tested-by: Andrew Halaney <ahalaney@redhat.com> # sa8775p-ride Note, I also tested with setting sa8775p-ride to: managed = "in-band-status"; and noticed no issues either when signalling was done in-band. Just highlighting that since there's some comments referencing the lack of in-band signalling with dwmac-qcom-ethqos usage in the series, but it seems that's ok in either case. I know there's the "sa8775p-ride-r3.dts" that was recently added, running with "OCSGMII" (hacked up 2.5GHz SGMII IIUC), I can't test that since I don't have that hardware. I think some of the remaining interesting bits in the dwmac-qcom-ethqos driver are to handle that (like the usage of ethqos_pcs_set_inband). Thanks, Andrew
On Fri, 2 Aug 2024 11:45:21 +0100 Russell King (Oracle) wrote:
> Subject: [PATCH RFC v3 0/14] net: stmmac: convert stmmac "pcs" to phylink
we have a build error here inside the tasty layered cake that is the op
handling in this driver (from patch 2 to 13, inclusive):
In file included from drivers/net/ethernet/stmicro/stmmac/common.h:26,
from drivers/net/ethernet/stmicro/stmmac/stmmac.h:20,
from drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:19:
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c: In function ‘stmmac_ethtool_set_link_ksettings’:
drivers/net/ethernet/stmicro/stmmac/hwif.h:15:17: error: too many arguments to function ‘priv->hw->mac->pcs_ctrl_ane’
15 | (__priv)->hw->__module->__cname((__arg0), ##__args); \
| ^
drivers/net/ethernet/stmicro/stmmac/hwif.h:485:9: note: in expansion of macro ‘stmmac_do_void_callback’
485 | stmmac_do_void_callback(__priv, mac, pcs_ctrl_ane, __priv, __args)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:419:17: note: in expansion of macro ‘stmmac_pcs_ctrl_ane’
419 | stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, priv->hw->ps, 0);
| ^~~~~~~~~~~~~~~~~~~
On Fri, Aug 2, 2024 at 12:45 PM Russell King (Oracle) <linux@armlinux.org.uk> wrote: > > Hi, > > This is version 3 of the series switching stmmac to use phylink PCS > isntead of going behind phylink's back. > Tested-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> # sa8775p-ride-r3 (The board is a more recent revision of the one Andrew tested this series on)
On Fri, 2 Aug 2024 12:45:21 +0200, "Russell King (Oracle)" <linux@armlinux.org.uk> said: > Hi, > > This is version 3 of the series switching stmmac to use phylink PCS > isntead of going behind phylink's back. > Sorry for the noise but I had the line wrapping on. Here's the tag once again: Tested-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> # sa8775p-ride-r3 (The board is a more recent revision of the one Andrew tested this series on)