| Message ID | 20240801064448.29626-3-quic_jkona@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Drop required-opps from required list on SM8650 videocc, camcc | expand |
On 01/08/2024 08:44, Jagadeesh Kona wrote: > On SM8650, the minimum voltage corner supported on MMCX from cmd-db is > sufficient for clock controllers to operate and there is no need to specify > the required-opps. Hence remove the required-opps property from the list of > required properties for SM8650 camcc bindings. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 8/1/24 09:44, Jagadeesh Kona wrote: > On SM8650, the minimum voltage corner supported on MMCX from cmd-db is > sufficient for clock controllers to operate and there is no need to specify > the required-opps. Hence remove the required-opps property from the list of > required properties for SM8650 camcc bindings. > > This fixes: > > arch/arm64/boot/dts/qcom/sm8650-hdk.dtb: clock-controller@ade0000: > 'required-opps' is a required property > > arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@ade0000: > 'required-opps' is a required property > > arch/arm64/boot/dts/qcom/sm8650-qrd.dtb: clock-controller@ade0000: > 'required-opps' is a required property > > Fixes: 1ae3f0578e0e ("dt-bindings: clock: qcom: Add SM8650 camera clock controller") > Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > Closes: https://lore.kernel.org/all/0f13ab6b-dff1-4b26-9707-704ae2e2b535@linaro.org/ > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202407070147.C9c3oTqS-lkp@intel.com/ > Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> -- Best wishes, Vladimir
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml index f58edfc10f4c..26afbbe65511 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml @@ -21,9 +21,6 @@ description: | include/dt-bindings/clock/qcom,sm8650-camcc.h include/dt-bindings/clock/qcom,x1e80100-camcc.h -allOf: - - $ref: qcom,gcc.yaml# - properties: compatible: enum: @@ -57,7 +54,21 @@ required: - compatible - clocks - power-domains - - required-opps + +allOf: + - $ref: qcom,gcc.yaml# + - if: + properties: + compatible: + contains: + enum: + - qcom,sc8280xp-camcc + - qcom,sm8450-camcc + - qcom,sm8550-camcc + - qcom,x1e80100-camcc + then: + required: + - required-opps unevaluatedProperties: false
On SM8650, the minimum voltage corner supported on MMCX from cmd-db is sufficient for clock controllers to operate and there is no need to specify the required-opps. Hence remove the required-opps property from the list of required properties for SM8650 camcc bindings. This fixes: arch/arm64/boot/dts/qcom/sm8650-hdk.dtb: clock-controller@ade0000: 'required-opps' is a required property arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@ade0000: 'required-opps' is a required property arch/arm64/boot/dts/qcom/sm8650-qrd.dtb: clock-controller@ade0000: 'required-opps' is a required property Fixes: 1ae3f0578e0e ("dt-bindings: clock: qcom: Add SM8650 camera clock controller") Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> Closes: https://lore.kernel.org/all/0f13ab6b-dff1-4b26-9707-704ae2e2b535@linaro.org/ Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407070147.C9c3oTqS-lkp@intel.com/ Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> --- .../bindings/clock/qcom,sm8450-camcc.yaml | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-)