| Message ID | cover.1722842066.git.stano.jakubek@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Cleanup Spreadtum/Unisoc ARM64 DT | expand |
On Mon, 05 Aug 2024 09:23:25 +0200, Stanislav Jakubek wrote: > This series contains various minor cleanups for Spreadtum/Unisoc ARM64 > DeviceTrees. Also contains the 2nd patch from the SC2731 MFD cleanup series > to reduce unnecessary noise and make these easier to apply. > > Changes in V2: > - add 2nd patch from the SC2731 MFD cleanup series (1st patch was dropped > due to not being correct, dt-bindings will have to get fixed up instead) > - add Baolin's R-b > - rebase on next-20240805 > > Link to original V1: https://lore.kernel.org/lkml/cover.1720112081.git.stano.jakubek@gmail.com/ > Link to SC2731 MFD cleanup V1: https://lore.kernel.org/lkml/cover.1720957783.git.stano.jakubek@gmail.com/ > > Stanislav Jakubek (4): > arm64: dts: sprd: rename SDHCI nodes to mmc > arm64: dts: sprd: reorder clock-names after clocks > arm64: dts: sprd: move/add SPDX license to top of the file > arm64: dts: sprd: sc2731: rename fuel gauge node to be generic > > arch/arm64/boot/dts/sprd/sc2731.dtsi | 5 +-- > arch/arm64/boot/dts/sprd/sc9836-openphone.dts | 3 +- > arch/arm64/boot/dts/sprd/sc9836.dtsi | 3 +- > arch/arm64/boot/dts/sprd/sc9860.dtsi | 3 +- > arch/arm64/boot/dts/sprd/sc9863a.dtsi | 8 ++-- > arch/arm64/boot/dts/sprd/sharkl64.dtsi | 3 +- > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 3 +- > arch/arm64/boot/dts/sprd/ums512.dtsi | 4 +- > arch/arm64/boot/dts/sprd/whale2.dtsi | 43 ++++++++++--------- > 9 files changed, 36 insertions(+), 39 deletions(-) > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y sprd/sc9836-openphone.dtb sprd/sp9860g-1h10.dtb' for cover.1722842066.git.stano.jakubek@gmail.com: arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'battery-detect-gpios' is a required property from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml# arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'sprd,calib-resistance-micro-ohms' is a required property from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml# arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'bat-detect-gpio', 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml#
Hi all, On Mon, Aug 05, 2024 at 09:00:20AM -0600, Rob Herring (Arm) wrote: > [snip] > > New warnings running 'make CHECK_DTBS=y sprd/sc9836-openphone.dtb sprd/sp9860g-1h10.dtb' for cover.1722842066.git.stano.jakubek@gmail.com: > > arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'battery-detect-gpios' is a required property > from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml# This is a straigtforward fix, the sc2731.dtsi has ...-gpio instead of ...-gpios I can fix this in another patch, I'd like to get this series merged first. > arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'sprd,calib-resistance-micro-ohms' is a required property > from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml# SPRD folks will have to chime in here as I do not have the board or any other source of information about it, so I cannot add this property. > arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'bat-detect-gpio', 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml# Looking at the driver, it seems to me that the interrupts are required, and thus should be added to the bindings. I can send a patch. Looking at the sc2731-fgu dtsi again, it seems like there's some further fixes/improvements that could be made (disable by default, move the monitored-battery to board DTS, etc.). Either way, this series should be good to go. Thanks, Stanislav
On Mon, 05 Aug 2024 09:23:25 +0200, Stanislav Jakubek wrote: > This series contains various minor cleanups for Spreadtum/Unisoc ARM64 > DeviceTrees. Also contains the 2nd patch from the SC2731 MFD cleanup series > to reduce unnecessary noise and make these easier to apply. > > Changes in V2: > - add 2nd patch from the SC2731 MFD cleanup series (1st patch was dropped > due to not being correct, dt-bindings will have to get fixed up instead) > - add Baolin's R-b > - rebase on next-20240805 > > [...] No one took this patchset and it waits on the list for very long. Applied, thanks! [1/4] arm64: dts: sprd: rename SDHCI nodes to mmc https://git.kernel.org/krzk/linux-dt/c/0dcc203956537696e6f936eef886fde70e049f54 [2/4] arm64: dts: sprd: reorder clock-names after clocks https://git.kernel.org/krzk/linux-dt/c/e2e0d4554de7182f4843415343b8888dac8a4f72 [3/4] arm64: dts: sprd: move/add SPDX license to top of the file https://git.kernel.org/krzk/linux-dt/c/a4b3f197bcd17ea81605f3121a459dece448e877 [4/4] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic https://git.kernel.org/krzk/linux-dt/c/0dcc203956537696e6f936eef886fde70e049f54 Best regards,
This series contains various minor cleanups for Spreadtum/Unisoc ARM64 DeviceTrees. Also contains the 2nd patch from the SC2731 MFD cleanup series to reduce unnecessary noise and make these easier to apply. Changes in V2: - add 2nd patch from the SC2731 MFD cleanup series (1st patch was dropped due to not being correct, dt-bindings will have to get fixed up instead) - add Baolin's R-b - rebase on next-20240805 Link to original V1: https://lore.kernel.org/lkml/cover.1720112081.git.stano.jakubek@gmail.com/ Link to SC2731 MFD cleanup V1: https://lore.kernel.org/lkml/cover.1720957783.git.stano.jakubek@gmail.com/ Stanislav Jakubek (4): arm64: dts: sprd: rename SDHCI nodes to mmc arm64: dts: sprd: reorder clock-names after clocks arm64: dts: sprd: move/add SPDX license to top of the file arm64: dts: sprd: sc2731: rename fuel gauge node to be generic arch/arm64/boot/dts/sprd/sc2731.dtsi | 5 +-- arch/arm64/boot/dts/sprd/sc9836-openphone.dts | 3 +- arch/arm64/boot/dts/sprd/sc9836.dtsi | 3 +- arch/arm64/boot/dts/sprd/sc9860.dtsi | 3 +- arch/arm64/boot/dts/sprd/sc9863a.dtsi | 8 ++-- arch/arm64/boot/dts/sprd/sharkl64.dtsi | 3 +- arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 3 +- arch/arm64/boot/dts/sprd/ums512.dtsi | 4 +- arch/arm64/boot/dts/sprd/whale2.dtsi | 43 ++++++++++--------- 9 files changed, 36 insertions(+), 39 deletions(-)