| Message ID | 20240805094012.1843247-1-leitao@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 45160cebd6ac84fe8cc2b7f6fec2550398e144cd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: veth: Disable netpoll support | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 5 Aug 2024 02:40:11 -0700 you wrote: > The current implementation of netpoll in veth devices leads to > suboptimal behavior, as it triggers warnings due to the invocation of > __netif_rx() within a softirq context. This is not compliant with > expected practices, as __netif_rx() has the following statement: > > lockdep_assert_once(hardirq_count() | softirq_count()); > > [...] Here is the summary with links: - [net-next] net: veth: Disable netpoll support https://git.kernel.org/netdev/net-next/c/45160cebd6ac You are awesome, thank you!
diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 426e68a95067..34499b91a8bd 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -1696,6 +1696,7 @@ static void veth_setup(struct net_device *dev) dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; dev->priv_flags |= IFF_NO_QUEUE; dev->priv_flags |= IFF_PHONY_HEADROOM; + dev->priv_flags |= IFF_DISABLE_NETPOLL; dev->netdev_ops = &veth_netdev_ops; dev->xdp_metadata_ops = &veth_xdp_metadata_ops;
The current implementation of netpoll in veth devices leads to suboptimal behavior, as it triggers warnings due to the invocation of __netif_rx() within a softirq context. This is not compliant with expected practices, as __netif_rx() has the following statement: lockdep_assert_once(hardirq_count() | softirq_count()); Given that veth devices typically do not benefit from the functionalities provided by netpoll, Disable netpoll for veth interfaces. Signed-off-by: Breno Leitao <leitao@debian.org> --- drivers/net/veth.c | 1 + 1 file changed, 1 insertion(+)