| Message ID | CACZJ9cX2R_=qgvLdaqbB_DUJhv08c674b67Ln_Qb9yyVwgE16w@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V2] KVM:x86:Fix an interrupt injection logic error during PIC interrupt simulation | expand |
frendly ping On Tue, 30 Jul 2024 at 21:59, Liam Ni <zhiguangni01@gmail.com> wrote: > > The input parameter level to the pic_irq_request function indicates > whether there are interrupts to be injected, > a level value of 1 indicates that there are interrupts to be injected, > and a level value of 0 indicates that there are no interrupts to be injected. > And the value of level will be assigned to s->output, > so we should set s->wakeup_needed to true when s->output is true. > > Signed-off-by: Liam Ni <zhiguangni01@gmail.com> > --- > arch/x86/kvm/i8259.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c > index 8dec646e764b..ec9d6ee7d33d 100644 > --- a/arch/x86/kvm/i8259.c > +++ b/arch/x86/kvm/i8259.c > @@ -567,7 +567,7 @@ static void pic_irq_request(struct kvm *kvm, int level) > { > struct kvm_pic *s = kvm->arch.vpic; > > - if (!s->output) > + if (!s->output && level) > s->wakeup_needed = true; > s->output = level; > } > -- > 2.34.1
diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c index 8dec646e764b..ec9d6ee7d33d 100644 --- a/arch/x86/kvm/i8259.c +++ b/arch/x86/kvm/i8259.c @@ -567,7 +567,7 @@ static void pic_irq_request(struct kvm *kvm, int level) { struct kvm_pic *s = kvm->arch.vpic; - if (!s->output) + if (!s->output && level) s->wakeup_needed = true; s->output = level; }
The input parameter level to the pic_irq_request function indicates whether there are interrupts to be injected, a level value of 1 indicates that there are interrupts to be injected, and a level value of 0 indicates that there are no interrupts to be injected. And the value of level will be assigned to s->output, so we should set s->wakeup_needed to true when s->output is true. Signed-off-by: Liam Ni <zhiguangni01@gmail.com> --- arch/x86/kvm/i8259.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1