diff mbox series

[v3,9/9] arm64: dts: ti: Add support for J742S2 EVM board

Message ID 20240731-b4-upstream-j742s2-v3-9-da7fe3aa9e90@ti.com (mailing list archive)
State New, archived
Headers show
Series Introduce J742S2 SoC and EVM | expand

Commit Message

Manorit Chawdhry July 31, 2024, 5:10 p.m. UTC
J742S2 EVM board is designed for TI J742S2 SoC. It supports the following
interfaces:
* 16 GB DDR4 RAM
* x2 Gigabit Ethernet interfaces capable of working in Switch and MAC mode
* x1 Input Audio Jack, x1 Output Audio Jack
* x1 USB2.0 Hub with two Type A host and x1 USB 3.1 Type-C Port
* x1 4L PCIe connector
* x1 UHS-1 capable micro-SD card slot
* 512 Mbit OSPI flash, 1 Gbit Octal NAND flash, 512 Mbit QSPI flash,
  UFS flash.
* x6 UART through UART-USB bridge
* XDS110 for onboard JTAG debug using USB
* Temperature sensors, user push buttons and LEDs
* x1 GESI expander, x2 Display connector
* x1 15-pin CSI header
* x6 MCAN instances

Link: https://www.ti.com/lit/ug/sprujd8/sprujd8.pdf (EVM user guide)
Link: https://www.ti.com/lit/zip/SPAC001 (Schematics)
Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
---
 arch/arm64/boot/dts/ti/Makefile                    |  4 ++++
 arch/arm64/boot/dts/ti/k3-j742s2-evm.dts           | 26 ++++++++++++++++++++++
 .../boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi   |  3 ++-
 3 files changed, 32 insertions(+), 1 deletion(-)

Comments

Beleswar Prasad Padhi Aug. 7, 2024, 9:41 a.m. UTC | #1
Hi Manorit,

On 31/07/24 22:40, Manorit Chawdhry wrote:
> J742S2 EVM board is designed for TI J742S2 SoC. It supports the following
> interfaces:
> * 16 GB DDR4 RAM
> * x2 Gigabit Ethernet interfaces capable of working in Switch and MAC mode
> * x1 Input Audio Jack, x1 Output Audio Jack
> * x1 USB2.0 Hub with two Type A host and x1 USB 3.1 Type-C Port
> * x1 4L PCIe connector
> * x1 UHS-1 capable micro-SD card slot
> * 512 Mbit OSPI flash, 1 Gbit Octal NAND flash, 512 Mbit QSPI flash,
>    UFS flash.
> * x6 UART through UART-USB bridge
> * XDS110 for onboard JTAG debug using USB
> * Temperature sensors, user push buttons and LEDs
> * x1 GESI expander, x2 Display connector
> * x1 15-pin CSI header
> * x6 MCAN instances
>
> Link: https://www.ti.com/lit/ug/sprujd8/sprujd8.pdf (EVM user guide)
> Link: https://www.ti.com/lit/zip/SPAC001 (Schematics)
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>


For series,
Reviewed-By: Beleswar Padhi <b-padhi@ti.com>

> ---
>   arch/arm64/boot/dts/ti/Makefile                    |  4 ++++
>   arch/arm64/boot/dts/ti/k3-j742s2-evm.dts           | 26 ++++++++++++++++++++++
>   .../boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi   |  3 ++-
>   3 files changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index e20b27ddf901..1bf645726a10 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -119,6 +119,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm-pcie0-pcie1-ep.dtbo
>   dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm-quad-port-eth-exp1.dtbo
>   dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm-usxgmii-exp1-exp2.dtbo
>   
> +# Boards with J742S2 SoC
> +dtb-$(CONFIG_ARCH_K3) += k3-j742s2-evm.dtb
> +
>   # Build time test only, enabled by CONFIG_OF_ALL_DTBS
>   k3-am625-beagleplay-csi2-ov5640-dtbs := k3-am625-beagleplay.dtb \
>   	k3-am625-beagleplay-csi2-ov5640.dtbo
> @@ -240,3 +243,4 @@ DTC_FLAGS_k3-j721e-common-proc-board += -@
>   DTC_FLAGS_k3-j721e-sk += -@
>   DTC_FLAGS_k3-j721s2-common-proc-board += -@
>   DTC_FLAGS_k3-j784s4-evm += -@
> +DTC_FLAGS_k3-j742s2-evm += -@
> diff --git a/arch/arm64/boot/dts/ti/k3-j742s2-evm.dts b/arch/arm64/boot/dts/ti/k3-j742s2-evm.dts
> new file mode 100644
> index 000000000000..ac683bcbfe97
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j742s2-evm.dts
> @@ -0,0 +1,26 @@
> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> +/*
> + * Copyright (C) 2024 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * EVM Board Schematics: https://www.ti.com/lit/zip/SPAC001
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/net/ti-dp83867.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include "k3-j742s2.dtsi"
> +#include "k3-j784s4-j742s2-evm-common.dtsi"
> +
> +/ {
> +	model = "Texas Instruments J742S2 EVM";
> +	compatible = "ti,j742s2-evm", "ti,j742s2";
> +
> +	memory@80000000 {
> +		device_type = "memory";
> +		bootph-all;
> +		/* 16G RAM */
> +		reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
> +		      <0x00000008 0x80000000 0x00000003 0x80000000>;
> +	};
> +};
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi
> index 068ceed4ea15..a7bb1857b4e8 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi
> @@ -2,7 +2,8 @@
>   /*
>    * Copyright (C) 2022-2024 Texas Instruments Incorporated - https://www.ti.com/
>    *
> - * EVM Board Schematics: https://www.ti.com/lit/zip/sprr458
> + * EVM Board Schematics(j784s4): https://www.ti.com/lit/zip/sprr458
> + * EVM Board Schematics(j742s2): https://www.ti.com/lit/zip/SPAC001
>    */
>   / {
>   	chosen {
>
Nishanth Menon Aug. 7, 2024, 11:51 a.m. UTC | #2
On 15:11-20240807, Beleswar Prasad Padhi wrote:
> Hi Manorit,
> 
> On 31/07/24 22:40, Manorit Chawdhry wrote:
> > J742S2 EVM board is designed for TI J742S2 SoC. It supports the following
> > interfaces:
> > * 16 GB DDR4 RAM
> > * x2 Gigabit Ethernet interfaces capable of working in Switch and MAC mode
> > * x1 Input Audio Jack, x1 Output Audio Jack
> > * x1 USB2.0 Hub with two Type A host and x1 USB 3.1 Type-C Port
> > * x1 4L PCIe connector
> > * x1 UHS-1 capable micro-SD card slot
> > * 512 Mbit OSPI flash, 1 Gbit Octal NAND flash, 512 Mbit QSPI flash,
> >    UFS flash.
> > * x6 UART through UART-USB bridge
> > * XDS110 for onboard JTAG debug using USB
> > * Temperature sensors, user push buttons and LEDs
> > * x1 GESI expander, x2 Display connector
> > * x1 15-pin CSI header
> > * x6 MCAN instances
> > 
> > Link: https://www.ti.com/lit/ug/sprujd8/sprujd8.pdf (EVM user guide)
> > Link: https://www.ti.com/lit/zip/SPAC001 (Schematics)
> > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> 
> 
> For series,
> Reviewed-By: Beleswar Padhi <b-padhi@ti.com>

Please follow the convention - if you are acking the series, reply to
the cover-letter such that tools like b4 can pick it up, else this ack
belongs to the current patch.
Nishanth Menon Aug. 7, 2024, 12:06 p.m. UTC | #3
On 15:11-20240807, Beleswar Prasad Padhi wrote:
> For series,
> Reviewed-By: Beleswar Padhi <b-padhi@ti.com>
[...]
> > +/ {
> > +	model = "Texas Instruments J742S2 EVM";
> > +	compatible = "ti,j742s2-evm", "ti,j742s2";
> > +
> > +	memory@80000000 {
> > +		device_type = "memory";
> > +		bootph-all;
> > +		/* 16G RAM */
> > +		reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
> > +		      <0x00000008 0x80000000 0x00000003 0x80000000>;

Sigh.. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117

1. "compatible" <- not present
2. "reg" <- present
3. "ranges" <- not present
4. Standard/common properties (defined by common bindings, e.g. without
   vendor-prefixes) <- bootph-all and device_type
5. Vendor-specific properties -> not present
6. "status" (if applicable) -> not present
7. Child nodes, where each node is preceded with a blank line -> not
present

So:

	/* 16G RAM */
	reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
	      <0x00000008 0x80000000 0x00000003 0x80000000>;
	device_type = "memory";
	bootph-all;

??
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
index e20b27ddf901..1bf645726a10 100644
--- a/arch/arm64/boot/dts/ti/Makefile
+++ b/arch/arm64/boot/dts/ti/Makefile
@@ -119,6 +119,9 @@  dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm-pcie0-pcie1-ep.dtbo
 dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm-quad-port-eth-exp1.dtbo
 dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm-usxgmii-exp1-exp2.dtbo
 
+# Boards with J742S2 SoC
+dtb-$(CONFIG_ARCH_K3) += k3-j742s2-evm.dtb
+
 # Build time test only, enabled by CONFIG_OF_ALL_DTBS
 k3-am625-beagleplay-csi2-ov5640-dtbs := k3-am625-beagleplay.dtb \
 	k3-am625-beagleplay-csi2-ov5640.dtbo
@@ -240,3 +243,4 @@  DTC_FLAGS_k3-j721e-common-proc-board += -@
 DTC_FLAGS_k3-j721e-sk += -@
 DTC_FLAGS_k3-j721s2-common-proc-board += -@
 DTC_FLAGS_k3-j784s4-evm += -@
+DTC_FLAGS_k3-j742s2-evm += -@
diff --git a/arch/arm64/boot/dts/ti/k3-j742s2-evm.dts b/arch/arm64/boot/dts/ti/k3-j742s2-evm.dts
new file mode 100644
index 000000000000..ac683bcbfe97
--- /dev/null
+++ b/arch/arm64/boot/dts/ti/k3-j742s2-evm.dts
@@ -0,0 +1,26 @@ 
+// SPDX-License-Identifier: GPL-2.0-only OR MIT
+/*
+ * Copyright (C) 2024 Texas Instruments Incorporated - https://www.ti.com/
+ *
+ * EVM Board Schematics: https://www.ti.com/lit/zip/SPAC001
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/net/ti-dp83867.h>
+#include <dt-bindings/gpio/gpio.h>
+#include "k3-j742s2.dtsi"
+#include "k3-j784s4-j742s2-evm-common.dtsi"
+
+/ {
+	model = "Texas Instruments J742S2 EVM";
+	compatible = "ti,j742s2-evm", "ti,j742s2";
+
+	memory@80000000 {
+		device_type = "memory";
+		bootph-all;
+		/* 16G RAM */
+		reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
+		      <0x00000008 0x80000000 0x00000003 0x80000000>;
+	};
+};
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi
index 068ceed4ea15..a7bb1857b4e8 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi
@@ -2,7 +2,8 @@ 
 /*
  * Copyright (C) 2022-2024 Texas Instruments Incorporated - https://www.ti.com/
  *
- * EVM Board Schematics: https://www.ti.com/lit/zip/sprr458
+ * EVM Board Schematics(j784s4): https://www.ti.com/lit/zip/sprr458
+ * EVM Board Schematics(j742s2): https://www.ti.com/lit/zip/SPAC001
  */
 / {
 	chosen {