| Message ID | 20240807121215.3178964-1-matthias.schiffer@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | eb3ab13d997a2f12ec9d557b6ae2aea4e28e2bc3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ti: icssg_prueth: populate netdev of_node | expand |
On 07/08/24 5:42 pm, Matthias Schiffer wrote: > Allow of_find_net_device_by_node() to find icssg_prueth ports and make > the individual ports' of_nodes available in sysfs. > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
On Wed, Aug 07, 2024 at 02:12:15PM +0200, Matthias Schiffer wrote: > Allow of_find_net_device_by_node() to find icssg_prueth ports and make > the individual ports' of_nodes available in sysfs. > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 7 Aug 2024 14:12:15 +0200 you wrote: > Allow of_find_net_device_by_node() to find icssg_prueth ports and make > the individual ports' of_nodes available in sysfs. > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > --- > > Tested on a TI AM64x SoC. I don't have a device using the icssg_prueth_sr1 > variant of the driver, but as this part of icssg_prueth.c and > icssg_prueth_sr1.c is identical, it seems like a good idea to make the > same change in both variants. > > [...] Here is the summary with links: - [net-next] net: ti: icssg_prueth: populate netdev of_node https://git.kernel.org/netdev/net-next/c/eb3ab13d997a You are awesome, thank you!
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c index 9dc9de39bb8f0..53a3e44b99a20 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c @@ -857,6 +857,7 @@ static int prueth_netdev_init(struct prueth *prueth, } ether_addr_copy(emac->mac_addr, ndev->dev_addr); + ndev->dev.of_node = eth_node; ndev->min_mtu = PRUETH_MIN_PKT_SIZE; ndev->max_mtu = PRUETH_MAX_MTU; ndev->netdev_ops = &emac_netdev_ops; diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c index 54b7e27608ce8..292f04d29f4f7 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c @@ -847,6 +847,7 @@ static int prueth_netdev_init(struct prueth *prueth, } ether_addr_copy(emac->mac_addr, ndev->dev_addr); + ndev->dev.of_node = eth_node; ndev->min_mtu = PRUETH_MIN_PKT_SIZE; ndev->max_mtu = PRUETH_MAX_MTU; ndev->netdev_ops = &emac_netdev_ops;
Allow of_find_net_device_by_node() to find icssg_prueth ports and make the individual ports' of_nodes available in sysfs. Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> --- Tested on a TI AM64x SoC. I don't have a device using the icssg_prueth_sr1 variant of the driver, but as this part of icssg_prueth.c and icssg_prueth_sr1.c is identical, it seems like a good idea to make the same change in both variants. drivers/net/ethernet/ti/icssg/icssg_prueth.c | 1 + drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c | 1 + 2 files changed, 2 insertions(+)