mbox series

[0/2] Trivial double space style fix

Message ID 20240807130516.491053-1-andi.shyti@linux.intel.com (mailing list archive)
Headers show
Series Trivial double space style fix | expand

Message

Andi Shyti Aug. 7, 2024, 1:05 p.m. UTC
Hi,

I was bothered a few times to see the double space in the
parameters list so that I decided to replace once and for all all
the double spaces that are not added on purpose to maintain some
visual alignment in the code.

Checkpatch doesn't have any rules for that because, indeed, this
is used also to put in columns parameters in repetitive function
calls or declarations. Nevertheless, it doesn't mean it's
stylistically correct.

Thanks,
Andi

Andi Shyti (2):
  drm/i915: Replace double blank with single blank after comma in gem/ and gt/
  drm/i915: Replace double blank with single blank after comma

 drivers/gpu/drm/i915/display/i9xx_wm.c               | 2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c             | 2 +-
 drivers/gpu/drm/i915/display/intel_display.c         | 2 +-
 drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +-
 drivers/gpu/drm/i915/display/intel_dp_hdcp.c         | 2 +-
 drivers/gpu/drm/i915/gem/i915_gem_object_types.h     | 2 +-
 drivers/gpu/drm/i915/gt/selftest_migrate.c           | 2 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c                | 2 +-
 drivers/gpu/drm/i915/gvt/trace.h                     | 2 +-
 drivers/gpu/drm/i915/i915_driver.c                   | 6 +++---
 drivers/gpu/drm/i915/i915_sysfs.c                    | 4 ++--
 drivers/gpu/drm/i915/selftests/intel_memory_region.c | 2 +-
 12 files changed, 15 insertions(+), 15 deletions(-)

Comments

Jani Nikula Aug. 7, 2024, 1:08 p.m. UTC | #1
On Wed, 07 Aug 2024, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi,
>
> I was bothered a few times to see the double space in the
> parameters list so that I decided to replace once and for all all
> the double spaces that are not added on purpose to maintain some
> visual alignment in the code.
>
> Checkpatch doesn't have any rules for that because, indeed, this
> is used also to put in columns parameters in repetitive function
> calls or declarations. Nevertheless, it doesn't mean it's
> stylistically correct.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>
> Thanks,
> Andi
>
> Andi Shyti (2):
>   drm/i915: Replace double blank with single blank after comma in gem/ and gt/
>   drm/i915: Replace double blank with single blank after comma
>
>  drivers/gpu/drm/i915/display/i9xx_wm.c               | 2 +-
>  drivers/gpu/drm/i915/display/intel_ddi.c             | 2 +-
>  drivers/gpu/drm/i915/display/intel_display.c         | 2 +-
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_dp_hdcp.c         | 2 +-
>  drivers/gpu/drm/i915/gem/i915_gem_object_types.h     | 2 +-
>  drivers/gpu/drm/i915/gt/selftest_migrate.c           | 2 +-
>  drivers/gpu/drm/i915/gt/uc/intel_uc.c                | 2 +-
>  drivers/gpu/drm/i915/gvt/trace.h                     | 2 +-
>  drivers/gpu/drm/i915/i915_driver.c                   | 6 +++---
>  drivers/gpu/drm/i915/i915_sysfs.c                    | 4 ++--
>  drivers/gpu/drm/i915/selftests/intel_memory_region.c | 2 +-
>  12 files changed, 15 insertions(+), 15 deletions(-)