| Message ID | 20240807084642.742-1-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC,1/2] dt-bindings: arm: rockchip: add Radxa E52C | expand |
Hello Fukaumi, On 2024-08-07 10:46, FUKAUMI Naoki wrote: > Add devicetree binding for the Radxa E52C. > > Radxa E52C is a compact network computer using the Rockchip RK3582 > chip. > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- > how should we handle RK3582? as far as I know, it's just an another > version of RK3588S. Could you, please, provide links to downstream kernel code from Rockchip that shows the CPU and GPU OPPs for the RK3582? By the way, is the schematic of Radxa E52C available? > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml > b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 2ad835f4068e..ba6d03b37bef 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -759,6 +759,12 @@ properties: > - const: radxa,cm3i > - const: rockchip,rk3568 > > + - description: Radxa E52C > + items: > + - enum: > + - radxa,e52c > + - const: rockchip,rk3588s > + > - description: Radxa Rock > items: > - const: radxa,rock
On Wed, 07 Aug 2024 17:46:41 +0900, FUKAUMI Naoki wrote: > Add devicetree binding for the Radxa E52C. > > Radxa E52C is a compact network computer using the Rockchip RK3582 > chip. > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- > how should we handle RK3582? as far as I know, it's just an another > version of RK3588S. > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-radxa-e52c.dtb' for 20240807084642.742-1-naoki@radxa.com: arch/arm64/boot/dts/rockchip/rk3588s-radxa-e52c.dtb: leds: led-2:linux,default-trigger: 'oneOf' conditional failed, one must be fixed: 'r8169-4-4100:00:link' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', 'usb-host', 'usbport'] 'r8169-4-4100:00:link' does not match '^cpu[0-9]*$' 'r8169-4-4100:00:link' does not match '^hci[0-9]+-power$' 'r8169-4-4100:00:link' does not match '^mmc[0-9]+$' 'r8169-4-4100:00:link' does not match '^phy[0-9]+tx$' from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml# arch/arm64/boot/dts/rockchip/rk3588s-radxa-e52c.dtb: leds: led-2: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected) from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml#
Hi, On 8/7/24 23:50, Dragan Simic wrote: > Hello Fukaumi, > > On 2024-08-07 10:46, FUKAUMI Naoki wrote: >> Add devicetree binding for the Radxa E52C. >> >> Radxa E52C is a compact network computer using the Rockchip RK3582 >> chip. >> >> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> >> --- >> how should we handle RK3582? as far as I know, it's just an another >> version of RK3588S. > > Could you, please, provide links to downstream kernel code from > Rockchip that shows the CPU and GPU OPPs for the RK3582? https://github.com/radxa/kernel/commits/linux-6.1-stan-rkr1/ I noticed there are some differences between source and schematic. I guess there are some copy & paste work, both are not so reliable... > By the way, is the schematic of Radxa E52C available? it's not yet available in public. everything, include hardware, is WIP. but it will be available before end of this month. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. >> --- >> Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml >> b/Documentation/devicetree/bindings/arm/rockchip.yaml >> index 2ad835f4068e..ba6d03b37bef 100644 >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >> @@ -759,6 +759,12 @@ properties: >> - const: radxa,cm3i >> - const: rockchip,rk3568 >> >> + - description: Radxa E52C >> + items: >> + - enum: >> + - radxa,e52c >> + - const: rockchip,rk3588s >> + >> - description: Radxa Rock >> items: >> - const: radxa,rock >
On 2024-08-07 19:59, FUKAUMI Naoki wrote: > On 8/7/24 23:50, Dragan Simic wrote: >> On 2024-08-07 10:46, FUKAUMI Naoki wrote: >>> Add devicetree binding for the Radxa E52C. >>> >>> Radxa E52C is a compact network computer using the Rockchip RK3582 >>> chip. >>> >>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> >>> --- >>> how should we handle RK3582? as far as I know, it's just an another >>> version of RK3588S. >> >> Could you, please, provide links to downstream kernel code from >> Rockchip that shows the CPU and GPU OPPs for the RK3582? > > https://github.com/radxa/kernel/commits/linux-6.1-stan-rkr1/ In fact, we'd need downstream source code from Rockchip as a reference, instead of downstream source code from Radxa. The link avaliable below seems to provide the required downstream information about the RK3582, straight from Rockchip. I'll go through it and come back with an update. https://raw.githubusercontent.com/rockchip-linux/kernel/develop-5.10/arch/arm64/boot/dts/rockchip/rk3528.dtsi > I noticed there are some differences between source and schematic. I > guess there are some copy & paste work, both are not so reliable... > >> By the way, is the schematic of Radxa E52C available? > > it's not yet available in public. everything, include hardware, is WIP. > but it will be available before end of this month. I see, thanks for the clarification. Then it's the best to wait until the actual public release of this new board. >>> --- >>> Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml >>> b/Documentation/devicetree/bindings/arm/rockchip.yaml >>> index 2ad835f4068e..ba6d03b37bef 100644 >>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >>> @@ -759,6 +759,12 @@ properties: >>> - const: radxa,cm3i >>> - const: rockchip,rk3568 >>> >>> + - description: Radxa E52C >>> + items: >>> + - enum: >>> + - radxa,e52c >>> + - const: rockchip,rk3588s >>> + >>> - description: Radxa Rock >>> items: >>> - const: radxa,rock
On 2024-08-07 20:10, Dragan Simic wrote: > On 2024-08-07 19:59, FUKAUMI Naoki wrote: >> On 8/7/24 23:50, Dragan Simic wrote: >>> On 2024-08-07 10:46, FUKAUMI Naoki wrote: >>>> Add devicetree binding for the Radxa E52C. >>>> >>>> Radxa E52C is a compact network computer using the Rockchip RK3582 >>>> chip. >>>> >>>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> >>>> --- >>>> how should we handle RK3582? as far as I know, it's just an another >>>> version of RK3588S. >>> >>> Could you, please, provide links to downstream kernel code from >>> Rockchip that shows the CPU and GPU OPPs for the RK3582? >> >> https://github.com/radxa/kernel/commits/linux-6.1-stan-rkr1/ > > In fact, we'd need downstream source code from Rockchip as a reference, > instead of downstream source code from Radxa. > > The link avaliable below seems to provide the required downstream > information about the RK3582, straight from Rockchip. I'll go through > it and come back with an update. > > https://raw.githubusercontent.com/rockchip-linux/kernel/develop-5.10/arch/arm64/boot/dts/rockchip/rk3528.dtsi Oops, my bad, somehow I got RK3582 and RK3528 mixed up, sorry for that. There have been quite a few similar yet different SoCs from Rockchip recently, so mixing them up has become rather easy. :) AFAICT, there's no information about the RK3582 available from the Rockchip downstream kernel code in the GitHub repository linked above, so we'll have to wait for that to also become publicly available from Rockchip. >> I noticed there are some differences between source and schematic. I >> guess there are some copy & paste work, both are not so reliable... >> >>> By the way, is the schematic of Radxa E52C available? >> >> it's not yet available in public. everything, include hardware, is >> WIP. >> but it will be available before end of this month. > > I see, thanks for the clarification. Then it's the best to wait until > the actual public release of this new board. > >>>> --- >>>> Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml >>>> b/Documentation/devicetree/bindings/arm/rockchip.yaml >>>> index 2ad835f4068e..ba6d03b37bef 100644 >>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >>>> @@ -759,6 +759,12 @@ properties: >>>> - const: radxa,cm3i >>>> - const: rockchip,rk3568 >>>> >>>> + - description: Radxa E52C >>>> + items: >>>> + - enum: >>>> + - radxa,e52c >>>> + - const: rockchip,rk3588s >>>> + >>>> - description: Radxa Rock >>>> items: >>>> - const: radxa,rock
On 07/08/2024 10:46, FUKAUMI Naoki wrote: > Add devicetree binding for the Radxa E52C. > > Radxa E52C is a compact network computer using the Rockchip RK3582 > chip. > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- > how should we handle RK3582? as far as I know, it's just an another > version of RK3588S. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 2ad835f4068e..ba6d03b37bef 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -759,6 +759,12 @@ properties: - const: radxa,cm3i - const: rockchip,rk3568 + - description: Radxa E52C + items: + - enum: + - radxa,e52c + - const: rockchip,rk3588s + - description: Radxa Rock items: - const: radxa,rock
Add devicetree binding for the Radxa E52C. Radxa E52C is a compact network computer using the Rockchip RK3582 chip. Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- how should we handle RK3582? as far as I know, it's just an another version of RK3588S. --- Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ 1 file changed, 6 insertions(+)