| Message ID | 20240730111535.135301-2-k.son@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dpum clock support for Exynos Auto v9 SoC | expand |
On 30/07/2024 13:15, Kwanghoon Son wrote: > Add dpum clock definitions and compatibles. > > Signed-off-by: Kwanghoon Son <k.son@samsung.com> > --- > .../clock/samsung,exynosautov9-clock.yaml | 19 +++++++++++++++++++ > .../dt-bindings/clock/samsung,exynosautov9.h | 11 +++++++++++ > 2 files changed, 30 insertions(+) > + > + then: > + properties: > + clocks: > + items: > + - description: External reference clock (26 MHz) > + - description: CMU_DPUM bus clock (from CMU_TOP) > + > + clock-names: > + items: > + - const: oscclk > + - const: dout_clkcmu_dpum_bus We need to stop calling input clocks by full name. Rob already pointed it out for GS101 and we fixed the approach there. This binding already uses above syntax, but I think we can start with proper approach even if it leads to inconsistency. So please come with description of this clock (not clock name - see GS101) and name, e.g. "bus". BTW, in the future, please ping after two weeks or better even: relax, and help out by reviewing other patches on the mailing lists in order to relieve the burden of maintainers and move your patches higher up the list. Best regards, Krzysztof
On Thu, 2024-08-08 at 09:57 +0200, Krzysztof Kozlowski wrote: > On 30/07/2024 13:15, Kwanghoon Son wrote: > > Add dpum clock definitions and compatibles. > > > > Signed-off-by: Kwanghoon Son <k.son@samsung.com> > > --- > > .../clock/samsung,exynosautov9-clock.yaml | 19 +++++++++++++++++++ > > .../dt-bindings/clock/samsung,exynosautov9.h | 11 +++++++++++ > > 2 files changed, 30 insertions(+) > > > + > > + then: > > + properties: > > + clocks: > > + items: > > + - description: External reference clock (26 MHz) > > + - description: CMU_DPUM bus clock (from CMU_TOP) > > + > > + clock-names: > > + items: > > + - const: oscclk > > + - const: dout_clkcmu_dpum_bus > > We need to stop calling input clocks by full name. Rob already pointed > it out for GS101 and we fixed the approach there. This binding already > uses above syntax, but I think we can start with proper approach even if > it leads to inconsistency. So please come with description of this clock > (not clock name - see GS101) and name, e.g. "bus". True. I'll look over GS101 more and work in v3. > > BTW, in the future, please ping after two weeks or better even: relax, > and help out by reviewing other patches on the mailing lists in order to > relieve the burden of maintainers and move your patches higher up the list. I'll keep in mind. Thanks for advice. Kwang. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml index 55c4f94a14d1..9c8041fc9d4b 100644 --- a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml @@ -35,6 +35,7 @@ properties: - samsung,exynosautov9-cmu-top - samsung,exynosautov9-cmu-busmc - samsung,exynosautov9-cmu-core + - samsung,exynosautov9-cmu-dpum - samsung,exynosautov9-cmu-fsys0 - samsung,exynosautov9-cmu-fsys1 - samsung,exynosautov9-cmu-fsys2 @@ -109,6 +110,24 @@ allOf: - const: oscclk - const: dout_clkcmu_core_bus + - if: + properties: + compatible: + contains: + const: samsung,exynosautov9-cmu-dpum + + then: + properties: + clocks: + items: + - description: External reference clock (26 MHz) + - description: CMU_DPUM bus clock (from CMU_TOP) + + clock-names: + items: + - const: oscclk + - const: dout_clkcmu_dpum_bus + - if: properties: compatible: diff --git a/include/dt-bindings/clock/samsung,exynosautov9.h b/include/dt-bindings/clock/samsung,exynosautov9.h index 3065375c2d8b..ce8fb8f7d718 100644 --- a/include/dt-bindings/clock/samsung,exynosautov9.h +++ b/include/dt-bindings/clock/samsung,exynosautov9.h @@ -179,6 +179,17 @@ #define CLK_GOUT_CORE_CCI_PCLK 4 #define CLK_GOUT_CORE_CMU_CORE_PCLK 5 +/* CMU_DPUM */ +#define CLK_MOUT_DPUM_BUS_USER 1 +#define CLK_DOUT_DPUM_BUSP 2 +#define CLK_GOUT_DPUM_ACLK_DECON 3 +#define CLK_GOUT_DPUM_ACLK_DMA 4 +#define CLK_GOUT_DPUM_ACLK_DPP 5 +#define CLK_GOUT_DPUM_SYSMMU_D0_CLK 6 +#define CLK_GOUT_DPUM_SYSMMU_D1_CLK 7 +#define CLK_GOUT_DPUM_SYSMMU_D2_CLK 8 +#define CLK_GOUT_DPUM_SYSMMU_D3_CLK 9 + /* CMU_FSYS0 */ #define CLK_MOUT_FSYS0_BUS_USER 1 #define CLK_MOUT_FSYS0_PCIE_USER 2
Add dpum clock definitions and compatibles. Signed-off-by: Kwanghoon Son <k.son@samsung.com> --- .../clock/samsung,exynosautov9-clock.yaml | 19 +++++++++++++++++++ .../dt-bindings/clock/samsung,exynosautov9.h | 11 +++++++++++ 2 files changed, 30 insertions(+)