diff mbox series

net: pse-pd: tps23881: include missing bitfield.h header

Message ID 20240807075455.2055224-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit a70b637db15b4de25af3c5946c4399144b3bc241
Delegated to: Netdev Maintainers
Headers show
Series net: pse-pd: tps23881: include missing bitfield.h header | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 29 this patch: 29
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 29 this patch: 29
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes fail Problems with Fixes tag: 1
netdev/build_allmodconfig_warn success Errors and warnings before: 29 this patch: 29
netdev/checkpatch warning WARNING: Unknown commit id '89108cb5c285', maybe rebased or not pulled?
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-08-07--09-00 (tests: 707)

Commit Message

Arnd Bergmann Aug. 7, 2024, 7:54 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Using FIELD_GET() fails in configurations that don't already include
the header file indirectly:

drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
  755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
      |             ^~~~~~~~~

Fixes: 89108cb5c285 ("net: pse-pd: tps23881: Fix the device ID check")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/pse-pd/tps23881.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Oleksij Rempel Aug. 7, 2024, 9:13 a.m. UTC | #1 
Hi Arnd,

Thank you for your patch.

I acked already other one:
https://lore.kernel.org/all/20240807071538.569784-1-guanjun@linux.alibaba.com/

On Wed, Aug 07, 2024 at 09:54:22AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Using FIELD_GET() fails in configurations that don't already include
> the header file indirectly:
> 
> drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
> drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
>   755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
>       |             ^~~~~~~~~
> 
> Fixes: 89108cb5c285 ("net: pse-pd: tps23881: Fix the device ID check")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Regards,
Oleksij
Jakub Kicinski Aug. 8, 2024, 3:36 p.m. UTC | #2 
On Wed, 7 Aug 2024 11:13:48 +0200 Oleksij Rempel wrote:
> I acked already other one:
> https://lore.kernel.org/all/20240807071538.569784-1-guanjun@linux.alibaba.com/

Thanks for the note, I totally missed the other patch scanning for just
fixes before the downstream PR.

I prefer Arnd's fix TBH, apart from not having the wrong tree in the
subject - the fixes tag is correctly formatted and includes are kept
alphabetical.

I'll "move" your ack here, hope that's fine.
patchwork-bot+netdevbpf@kernel.org Aug. 8, 2024, 4:20 p.m. UTC | #3 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  7 Aug 2024 09:54:22 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Using FIELD_GET() fails in configurations that don't already include
> the header file indirectly:
> 
> drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
> drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
>   755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
>       |             ^~~~~~~~~
> 
> [...]

Here is the summary with links:
  - net: pse-pd: tps23881: include missing bitfield.h header
    https://git.kernel.org/netdev/net/c/a70b637db15b

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/pse-pd/tps23881.c b/drivers/net/pse-pd/tps23881.c
index f90db758554b..2ea75686a319 100644
--- a/drivers/net/pse-pd/tps23881.c
+++ b/drivers/net/pse-pd/tps23881.c
@@ -5,6 +5,7 @@ 
  * Copyright (c) 2023 Bootlin, Kory Maincent <kory.maincent@bootlin.com>
  */
 
+#include <linux/bitfield.h>
 #include <linux/delay.h>
 #include <linux/firmware.h>
 #include <linux/i2c.h>