| Message ID | 20240807084539.304014-7-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/{amdgpu,nouveau}: Remove old fbdev hooks | expand |
On Wed, Aug 07, 2024 at 10:41:38AM +0200, Thomas Zimmermann wrote: > The function is unused. Remove it. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Without the next patch to remove ->lastclose there's some confusion text left in the DOC: section in drm_fb_helper.c, but no point to split that up perfectly imo. Was just trying to find it and didn't find it only looking at the poll_changed patches ... -Sima > --- > drivers/gpu/drm/drm_fb_helper.c | 15 --------------- > include/drm/drm_fb_helper.h | 6 ------ > 2 files changed, 21 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index f6667dfba8a2..3cafb28236f7 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -2015,18 +2015,3 @@ void drm_fb_helper_lastclose(struct drm_device *dev) > > } > EXPORT_SYMBOL(drm_fb_helper_lastclose); > - > -/** > - * drm_fb_helper_output_poll_changed - DRM mode config \.output_poll_changed > - * helper for fbdev emulation > - * @dev: DRM device > - * > - * This function can be used as the > - * &drm_mode_config_funcs.output_poll_changed callback for drivers that only > - * need to call drm_fbdev.hotplug_event(). > - */ > -void drm_fb_helper_output_poll_changed(struct drm_device *dev) > -{ > - drm_fb_helper_hotplug_event(dev->fb_helper); > -} > -EXPORT_SYMBOL(drm_fb_helper_output_poll_changed); > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 375737fd6c36..699f2790b9ac 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -271,9 +271,7 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper); > int drm_fb_helper_initial_config(struct drm_fb_helper *fb_helper); > int drm_fb_helper_debug_enter(struct fb_info *info); > int drm_fb_helper_debug_leave(struct fb_info *info); > - > void drm_fb_helper_lastclose(struct drm_device *dev); > -void drm_fb_helper_output_poll_changed(struct drm_device *dev); > #else > static inline void drm_fb_helper_prepare(struct drm_device *dev, > struct drm_fb_helper *helper, > @@ -401,10 +399,6 @@ static inline int drm_fb_helper_debug_leave(struct fb_info *info) > static inline void drm_fb_helper_lastclose(struct drm_device *dev) > { > } > - > -static inline void drm_fb_helper_output_poll_changed(struct drm_device *dev) > -{ > -} > #endif > > #endif > -- > 2.46.0 >
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index f6667dfba8a2..3cafb28236f7 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -2015,18 +2015,3 @@ void drm_fb_helper_lastclose(struct drm_device *dev) } EXPORT_SYMBOL(drm_fb_helper_lastclose); - -/** - * drm_fb_helper_output_poll_changed - DRM mode config \.output_poll_changed - * helper for fbdev emulation - * @dev: DRM device - * - * This function can be used as the - * &drm_mode_config_funcs.output_poll_changed callback for drivers that only - * need to call drm_fbdev.hotplug_event(). - */ -void drm_fb_helper_output_poll_changed(struct drm_device *dev) -{ - drm_fb_helper_hotplug_event(dev->fb_helper); -} -EXPORT_SYMBOL(drm_fb_helper_output_poll_changed); diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 375737fd6c36..699f2790b9ac 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -271,9 +271,7 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper); int drm_fb_helper_initial_config(struct drm_fb_helper *fb_helper); int drm_fb_helper_debug_enter(struct fb_info *info); int drm_fb_helper_debug_leave(struct fb_info *info); - void drm_fb_helper_lastclose(struct drm_device *dev); -void drm_fb_helper_output_poll_changed(struct drm_device *dev); #else static inline void drm_fb_helper_prepare(struct drm_device *dev, struct drm_fb_helper *helper, @@ -401,10 +399,6 @@ static inline int drm_fb_helper_debug_leave(struct fb_info *info) static inline void drm_fb_helper_lastclose(struct drm_device *dev) { } - -static inline void drm_fb_helper_output_poll_changed(struct drm_device *dev) -{ -} #endif #endif
The function is unused. Remove it. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/drm_fb_helper.c | 15 --------------- include/drm/drm_fb_helper.h | 6 ------ 2 files changed, 21 deletions(-)