| Message ID | 20240809-fp5-dp-sound-v1-1-d7ba2c24f6b9@fairphone.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add DisplayPort sound support for Fairphone 5 smartphone | expand |
On 09/08/2024 10:33, Luca Weiss wrote: > Document the bindings for the Qualcomm QCM6490 sound card. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > index c9076dcd44c1..0a31be6d917f 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > @@ -31,6 +31,7 @@ properties: > - qcom,apq8096-sndcard > - qcom,msm8916-qdsp6-sndcard > - qcom,qcm6490-idp-sndcard > + - qcom,qcm6490-sndcard I think it would be better to make it a board-compatible and also followed by qcom,qcm6490-idp-sndcard fallback, thus no need for driver changes. Best regards, Krzysztof
On Fri Aug 9, 2024 at 11:09 AM CEST, Krzysztof Kozlowski wrote: > On 09/08/2024 10:33, Luca Weiss wrote: > > Document the bindings for the Qualcomm QCM6490 sound card. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > > index c9076dcd44c1..0a31be6d917f 100644 > > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > > @@ -31,6 +31,7 @@ properties: > > - qcom,apq8096-sndcard > > - qcom,msm8916-qdsp6-sndcard > > - qcom,qcm6490-idp-sndcard > > + - qcom,qcm6490-sndcard > > I think it would be better to make it a board-compatible and also > followed by qcom,qcm6490-idp-sndcard fallback, thus no need for driver > changes. Hi Krzysztof, So that we get "fairphone,fp5-sndcard", "qcom,qcm6490-idp-sndcard"? I can change it to that in v2. Regards Luca > > Best regards, > Krzysztof
On 09/08/2024 11:12, Luca Weiss wrote: > On Fri Aug 9, 2024 at 11:09 AM CEST, Krzysztof Kozlowski wrote: >> On 09/08/2024 10:33, Luca Weiss wrote: >>> Document the bindings for the Qualcomm QCM6490 sound card. >>> >>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >>> --- >>> Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>> index c9076dcd44c1..0a31be6d917f 100644 >>> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>> @@ -31,6 +31,7 @@ properties: >>> - qcom,apq8096-sndcard >>> - qcom,msm8916-qdsp6-sndcard >>> - qcom,qcm6490-idp-sndcard >>> + - qcom,qcm6490-sndcard >> >> I think it would be better to make it a board-compatible and also >> followed by qcom,qcm6490-idp-sndcard fallback, thus no need for driver >> changes. > > Hi Krzysztof, > > So that we get "fairphone,fp5-sndcard", "qcom,qcm6490-idp-sndcard"? Yes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index c9076dcd44c1..0a31be6d917f 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -31,6 +31,7 @@ properties: - qcom,apq8096-sndcard - qcom,msm8916-qdsp6-sndcard - qcom,qcm6490-idp-sndcard + - qcom,qcm6490-sndcard - qcom,qcs6490-rb3gen2-sndcard - qcom,qrb5165-rb5-sndcard - qcom,sc7180-qdsp6-sndcard
Document the bindings for the Qualcomm QCM6490 sound card. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 + 1 file changed, 1 insertion(+)