| Message ID | 20240809-mptcp-pm-avail-v7-0-3d0916ba39b4@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: pm: more fixes around the ID 0 | expand |
Hi Matthieu,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/10319599535
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/0d9537940d3c
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=878199
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
On Fri, 9 Aug 2024, Matthieu Baerts (NGI0) wrote: > The 8 first patches from the previous version have already been applied. > > Last fix: the subflow is not closed when receiving a TCP+FIN, when there > are other available subflows. > > The last patch is not for -next. Something that sounds better to do. > > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> > --- > Changes in v7: > - See the individual changelog. > - Link to v6: https://lore.kernel.org/r/20240802-mptcp-pm-avail-v6-0-964ba9ce279f@kernel.org > Thanks Matthieu, series LGTM (see #3 for responses to your questions there): Reviewed-by: Mat Martineau <martineau@kernel.org> > --- > Matthieu Baerts (NGI0) (3): > mptcp: close subflow when receiving TCP+FIN > selftests: mptcp: join: cannot rm sf if closed > mptcp: pm: send ACK on non stale subflows > > net/mptcp/pm_netlink.c | 14 +++++++++++--- > net/mptcp/protocol.c | 5 ++++- > net/mptcp/subflow.c | 8 ++++++-- > tools/testing/selftests/net/mptcp/mptcp_join.sh | 11 ++++------- > 4 files changed, 25 insertions(+), 13 deletions(-) > --- > base-commit: beede3e0f15d8869512b5b51e580829ab6939f92 > change-id: 20240620-mptcp-pm-avail-f5e3957be441 > > Best regards, > -- > Matthieu Baerts (NGI0) <matttbe@kernel.org> > >
Hi Mat, On 09/08/2024 14:37, Matthieu Baerts (NGI0) wrote: > The 8 first patches from the previous version have already been applied. > > Last fix: the subflow is not closed when receiving a TCP+FIN, when there > are other available subflows. > > The last patch is not for -next. Something that sounds better to do. > > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> > --- > Changes in v7: > - See the individual changelog. > - Link to v6: https://lore.kernel.org/r/20240802-mptcp-pm-avail-v6-0-964ba9ce279f@kernel.org Thank you for the review, and your comment! Now in our tree: New patches for t/upstream-net and t/upstream: - 45e7e7bb1d53: mptcp: close subflow when receiving TCP+FIN - 4dff13e9b19e: selftests: mptcp: join: cannot rm sf if closed - Results: 479b0f0c640c..c025238d573a (export-net) - Results: a6b7b898cddd..8d90262870c8 (export) New patches for t/upstream: - cee0b5912a36: mptcp: pm: send ACK on non stale subflows - Results: 8d90262870c8..a2eeb886f736 (export) Tests are now in progress: - export-net: https://github.com/multipath-tcp/mptcp_net-next/commit/e9099bcf17a9d3c1b60dddc620e47c4307b8bb99/checks - export: https://github.com/multipath-tcp/mptcp_net-next/commit/2c2279cec7af565f971bfe2805b325af05cc6039/checks - export: https://github.com/multipath-tcp/mptcp_net-next/commit/133016fd5500a67dd98db80bf60e300367431966/checks Cheers, Matt
The 8 first patches from the previous version have already been applied. Last fix: the subflow is not closed when receiving a TCP+FIN, when there are other available subflows. The last patch is not for -next. Something that sounds better to do. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Changes in v7: - See the individual changelog. - Link to v6: https://lore.kernel.org/r/20240802-mptcp-pm-avail-v6-0-964ba9ce279f@kernel.org --- Matthieu Baerts (NGI0) (3): mptcp: close subflow when receiving TCP+FIN selftests: mptcp: join: cannot rm sf if closed mptcp: pm: send ACK on non stale subflows net/mptcp/pm_netlink.c | 14 +++++++++++--- net/mptcp/protocol.c | 5 ++++- net/mptcp/subflow.c | 8 ++++++-- tools/testing/selftests/net/mptcp/mptcp_join.sh | 11 ++++------- 4 files changed, 25 insertions(+), 13 deletions(-) --- base-commit: beede3e0f15d8869512b5b51e580829ab6939f92 change-id: 20240620-mptcp-pm-avail-f5e3957be441 Best regards,