mbox series

[v2,0/2] Fix system resume for SCSI devices

Message ID 20240809193115.1222737-1-bvanassche@acm.org (mailing list archive)
Headers show
Series Fix system resume for SCSI devices | expand

Message

Bart Van Assche Aug. 9, 2024, 7:31 p.m. UTC
Hi Martin,

This patch series fixes a particular type of system resume failure for
SCSI devices. Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v1:
 - Renamed SCMD_RETRY_PASST_ON_UA into SCMD_RETRY_PASSTHROUGH.

Bart Van Assche (2):
  scsi: core: Retry passthrough commands if SCMD_RETRY_PASSTHROUGH is
    set
  sd: Retry START STOP UNIT commands

 drivers/scsi/scsi_error.c | 5 ++++-
 drivers/scsi/sd.c         | 1 +
 include/scsi/scsi_cmnd.h  | 5 ++++-
 3 files changed, 9 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen Aug. 9, 2024, 10:13 p.m. UTC | #1
Hi Bart!

> This patch series fixes a particular type of system resume failure for
> SCSI devices. Please consider this patch series for the next merge
> window.

I have been working on several tricky regressions where the remedy is
similar in nature to yours. I.e. retrying in some situations. I ended up
using the scsi_failure infrastructure to handle the cases I care about
but now wonder if a more generic approach is warranted. I'll contemplate
a bit and try to reconcile my changes with yours.