| Message ID | 20240624-mtk_disp_ovl_adaptor_scoped-v1-2-9fa1e074d881@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/mediatek: fixes for ovl_adaptor | expand |
Hi, Javier: On Mon, 2024-06-24 at 18:43 +0200, Javier Carrasco wrote: > > External email : Please do not click links or open attachments until you have verified the sender or the content. > Error paths that exit for_each_child_of_node() need to call > of_node_put() to decerement the child refcount and avoid memory leaks. > > Add the missing of_node_put(). Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Cc: stable@vger.kernel.org > Fixes: 453c3364632a ("drm/mediatek: Add ovl_adaptor support for MT8195") > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > index 1418992311c4..3faf26a55e77 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > @@ -522,8 +522,10 @@ static int ovl_adaptor_comp_init(struct device *dev, struct component_match **ma > } > > comp_pdev = of_find_device_by_node(node); > -if (!comp_pdev) > +if (!comp_pdev) { > +of_node_put(node); > return -EPROBE_DEFER; > +} > > priv->ovl_adaptor_comp[id] = &comp_pdev->dev; > > > -- > 2.40.1 > >
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c index 1418992311c4..3faf26a55e77 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c @@ -522,8 +522,10 @@ static int ovl_adaptor_comp_init(struct device *dev, struct component_match **ma } comp_pdev = of_find_device_by_node(node); - if (!comp_pdev) + if (!comp_pdev) { + of_node_put(node); return -EPROBE_DEFER; + } priv->ovl_adaptor_comp[id] = &comp_pdev->dev;
Error paths that exit for_each_child_of_node() need to call of_node_put() to decerement the child refcount and avoid memory leaks. Add the missing of_node_put(). Cc: stable@vger.kernel.org Fixes: 453c3364632a ("drm/mediatek: Add ovl_adaptor support for MT8195") Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)