| Message ID | 20240809-unicode-const-v1-1-69968a258092@weissschuh.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | unicode: constify utf8 data table | expand |
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
On Fri, 09 Aug 2024 17:38:53 +0200, Thomas Weißschuh wrote: > All users already handle the table as const data. > Move the table itself into .rodata to guard against accidental or > malicious modifications. Applied, thanks! [1/1] unicode: constify utf8 data table commit: 43bf9d9755bd21970d8382dc88f071f74fc18fbf Best regards,
diff --git a/fs/unicode/mkutf8data.c b/fs/unicode/mkutf8data.c index 77b685db8275..57e0e290ce6f 100644 --- a/fs/unicode/mkutf8data.c +++ b/fs/unicode/mkutf8data.c @@ -3338,7 +3338,7 @@ static void write_file(void) } fprintf(file, "};\n"); fprintf(file, "\n"); - fprintf(file, "struct utf8data_table utf8_data_table = {\n"); + fprintf(file, "const struct utf8data_table utf8_data_table = {\n"); fprintf(file, "\t.utf8agetab = utf8agetab,\n"); fprintf(file, "\t.utf8agetab_size = ARRAY_SIZE(utf8agetab),\n"); fprintf(file, "\n"); diff --git a/fs/unicode/utf8data.c_shipped b/fs/unicode/utf8data.c_shipped index dafa5fed761d..73a93d49b3ba 100644 --- a/fs/unicode/utf8data.c_shipped +++ b/fs/unicode/utf8data.c_shipped @@ -4107,7 +4107,7 @@ static const unsigned char utf8data[64256] = { 0x81,0x80,0xcf,0x86,0x85,0x84,0xcf,0x86,0xcf,0x06,0x02,0x00,0x00,0x00,0x00,0x00 }; -struct utf8data_table utf8_data_table = { +const struct utf8data_table utf8_data_table = { .utf8agetab = utf8agetab, .utf8agetab_size = ARRAY_SIZE(utf8agetab), diff --git a/fs/unicode/utf8n.h b/fs/unicode/utf8n.h index bd00d587747a..fc703aa4b28e 100644 --- a/fs/unicode/utf8n.h +++ b/fs/unicode/utf8n.h @@ -78,6 +78,6 @@ struct utf8data_table { const unsigned char *utf8data; }; -extern struct utf8data_table utf8_data_table; +extern const struct utf8data_table utf8_data_table; #endif /* UTF8NORM_H */
All users already handle the table as const data. Move the table itself into .rodata to guard against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- fs/unicode/mkutf8data.c | 2 +- fs/unicode/utf8data.c_shipped | 2 +- fs/unicode/utf8n.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) --- base-commit: ee9a43b7cfe2d8a3520335fea7d8ce71b8cabd9d change-id: 20240809-unicode-const-2cd2295d3df3 Best regards,