diff mbox series

[1/1] dt-bindings: extcon: ptn5150: add child node port

Message ID 20240812231820.3838925-1-Frank.Li@nxp.com (mailing list archive)
State Superseded
Headers show
Series [1/1] dt-bindings: extcon: ptn5150: add child node port | expand

Commit Message

Frank Li Aug. 12, 2024, 11:18 p.m. UTC
Add child node 'port' to allow connect to usb controller to do role-switch.

Fix below warning:
arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Aug. 13, 2024, 5:39 a.m. UTC | #1
On 13/08/2024 01:18, Frank Li wrote:
> Add child node 'port' to allow connect to usb controller to do role-switch.
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml
> 

This looks reasonable however intention was to switch to connector node,
wasn't it? I actually wonder how the commit 095b96b2b adding connector
could fix that warning...

The binding and device driver might be incomplete. There should be a
connector somewhere.

Anyway, in any case, please extend the example.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
index d5cfa32ea52dd..28c34d78708cb 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
+++ b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
@@ -37,6 +37,11 @@  properties:
       GPIO pin (output) used to control VBUS. If skipped, no such control
       takes place.
 
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    description:
+      A port node to link the usb controller for the dual role switch.
+
 required:
   - compatible
   - interrupts