| Message ID | 20240813074233.2473876-4-danishanwar@ti.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Introduce HSR offload support for ICSSG | expand |
On Tue, Aug 13, 2024 at 01:12:29PM +0530, MD Danish Anwar wrote: > The def_inc is stored in icss_iep structure. Currently default increment > (ns per clock tick) is hardcoded to 4 (Clock frequency being 250 MHz). > Change this to use the iep->def_inc variable as the iep structure is now > accessible to the driver files. > > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > --- Thanks for breaking this out into a separate patch and removing the unused spinlock. I don't necessarily feel qualified to review this patchset but I didn't have any other issues with it. regards, dan carpenter
On 13/08/2024 10:42, MD Danish Anwar wrote: > The def_inc is stored in icss_iep structure. Currently default increment > (ns per clock tick) is hardcoded to 4 (Clock frequency being 250 MHz). > Change this to use the iep->def_inc variable as the iep structure is now > accessible to the driver files. > > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> Reviewed-by: Roger Quadros <rogerq@kernel.org>
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c index 613bd8de6eb8..c93071e05c37 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c @@ -365,7 +365,8 @@ static void prueth_iep_settime(void *clockops_data, u64 ns) sc_desc.cyclecounter0_set = cyclecount & GENMASK(31, 0); sc_desc.cyclecounter1_set = (cyclecount & GENMASK(63, 32)) >> 32; sc_desc.iepcount_set = ns % cycletime; - sc_desc.CMP0_current = cycletime - 4; //Count from 0 to (cycle time)-4 + /* Count from 0 to (cycle time) - emac->iep->def_inc */ + sc_desc.CMP0_current = cycletime - emac->iep->def_inc; memcpy_toio(sc_descp, &sc_desc, sizeof(sc_desc));
The def_inc is stored in icss_iep structure. Currently default increment (ns per clock tick) is hardcoded to 4 (Clock frequency being 250 MHz). Change this to use the iep->def_inc variable as the iep structure is now accessible to the driver files. Signed-off-by: MD Danish Anwar <danishanwar@ti.com> --- drivers/net/ethernet/ti/icssg/icssg_prueth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)