| Message ID | 20240813-imx_warning-v1-15-3494426aea09@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: imx: 3rd dtb warning clearn up | expand |
Am Dienstag, 13. August 2024, 06:35:10 CEST schrieb Frank Li: > Rename hub to usb to fix below warning: > arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?' > > Signed-off-by: Frank Li <Frank.Li@nxp.com> Thanks. Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts | 2 +- > arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts > index 852dd3d2eac74..325d8097bf7fc 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts > @@ -533,7 +533,7 @@ &usbotg2 { > samsung,picophy-dc-vol-level-adjust = <7>; > status = "okay"; > > - hub_2_0: hub@1 { > + hub_2_0: usb@1 { > compatible = "usb424,2517"; > reg = <1>; > reset-gpios = <&expander1 2 GPIO_ACTIVE_LOW>; > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts > index da8f19a646a98..b1fcbc12bd882 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts > @@ -486,7 +486,7 @@ &usbotg2 { > samsung,picophy-dc-vol-level-adjust = <7>; > status = "okay"; > > - hub_2_0: hub@1 { > + hub_2_0: usb@1 { > compatible = "usb424,2517"; > reg = <1>; > reset-gpios = <&expander1 2 GPIO_ACTIVE_LOW>; > >
Am Dienstag, 13. August 2024, 10:40:04 CEST schrieb Alexander Stein: > Am Dienstag, 13. August 2024, 06:35:10 CEST schrieb Frank Li: > > Rename hub to usb to fix below warning: > > arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?' > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > Thanks. > > Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> Still valid, but there is already https://lore.kernel.org/all/20240808123206.192906-1-festevam@gmail.com/ > > --- > > arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts | 2 +- > > arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts > > index 852dd3d2eac74..325d8097bf7fc 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts > > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts > > @@ -533,7 +533,7 @@ &usbotg2 { > > samsung,picophy-dc-vol-level-adjust = <7>; > > status = "okay"; > > > > - hub_2_0: hub@1 { > > + hub_2_0: usb@1 { > > compatible = "usb424,2517"; > > reg = <1>; > > reset-gpios = <&expander1 2 GPIO_ACTIVE_LOW>; > > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts > > index da8f19a646a98..b1fcbc12bd882 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts > > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts > > @@ -486,7 +486,7 @@ &usbotg2 { > > samsung,picophy-dc-vol-level-adjust = <7>; > > status = "okay"; > > > > - hub_2_0: hub@1 { > > + hub_2_0: usb@1 { > > compatible = "usb424,2517"; > > reg = <1>; > > reset-gpios = <&expander1 2 GPIO_ACTIVE_LOW>; > > > > > > >
On 13/08/2024 06:35, Frank Li wrote: > Rename hub to usb to fix below warning: > arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?' > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts | 2 +- > arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts | 2 +- No, synchronize your work with other TQ, so we won't have to do the same review. That's not really correct. See other thread. Best regards, Krzysztof
On 13/08/2024 10:49, Alexander Stein wrote: > Am Dienstag, 13. August 2024, 10:40:04 CEST schrieb Alexander Stein: >> Am Dienstag, 13. August 2024, 06:35:10 CEST schrieb Frank Li: >>> Rename hub to usb to fix below warning: >>> arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?' >>> >>> Signed-off-by: Frank Li <Frank.Li@nxp.com> >> >> Thanks. >> >> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > Still valid, but there is already https://lore.kernel.org/all/20240808123206.192906-1-festevam@gmail.com/ > Fix the schema instead... Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts index 852dd3d2eac74..325d8097bf7fc 100644 --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts @@ -533,7 +533,7 @@ &usbotg2 { samsung,picophy-dc-vol-level-adjust = <7>; status = "okay"; - hub_2_0: hub@1 { + hub_2_0: usb@1 { compatible = "usb424,2517"; reg = <1>; reset-gpios = <&expander1 2 GPIO_ACTIVE_LOW>; diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts index da8f19a646a98..b1fcbc12bd882 100644 --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts @@ -486,7 +486,7 @@ &usbotg2 { samsung,picophy-dc-vol-level-adjust = <7>; status = "okay"; - hub_2_0: hub@1 { + hub_2_0: usb@1 { compatible = "usb424,2517"; reg = <1>; reset-gpios = <&expander1 2 GPIO_ACTIVE_LOW>;
Rename hub to usb to fix below warning: arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?' Signed-off-by: Frank Li <Frank.Li@nxp.com> --- arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts | 2 +- arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)