| Message ID | 20240715084701.42478-1-r.smirnov@omp.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b752f760da474c53d66cc4b137db0838aee3c953 |
| Headers | show |
| Series | [BlueZ,v1] tools/rctest: add NULL checks to main() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING tools/rctest.c:627:33: warning: non-ANSI function declaration of function 'automated_send_recv' |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=871273 ---Test result--- Test Summary: CheckPatch PASS 0.43 seconds GitLint PASS 0.29 seconds BuildEll PASS 24.76 seconds BluezMake PASS 1633.82 seconds MakeCheck PASS 12.95 seconds MakeDistcheck PASS 177.47 seconds CheckValgrind PASS 251.61 seconds CheckSmatch WARNING 355.07 seconds bluezmakeextell PASS 119.84 seconds IncrementalBuild PASS 1551.92 seconds ScanBuild PASS 1024.58 seconds Details ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: tools/rctest.c:627:33: warning: non-ANSI function declaration of function 'automated_send_recv' --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 15 Jul 2024 11:47:01 +0300 you wrote: > It is necessary to prevent dereferencing of a NULL pointer. > > Found with the SVACE static analysis tool. > --- > tools/rctest.c | 30 +++++++++++++++++++++++------- > 1 file changed, 23 insertions(+), 7 deletions(-) Here is the summary with links: - [BlueZ,v1] tools/rctest: add NULL checks to main() https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b752f760da47 You are awesome, thank you!
diff --git a/tools/rctest.c b/tools/rctest.c index b72be917c..367e41e3c 100644 --- a/tools/rctest.c +++ b/tools/rctest.c @@ -742,6 +742,9 @@ int main(int argc, char *argv[]) break; case 'a': + if (!optarg) + break; + mode = AUTO; if (!strncasecmp(optarg, "hci", 3)) @@ -756,6 +759,9 @@ int main(int argc, char *argv[]) break; case 'i': + if (!optarg) + break; + if (!strncasecmp(optarg, "hci", 3)) hci_devba(atoi(optarg + 3), &bdaddr); else @@ -763,10 +769,14 @@ int main(int argc, char *argv[]) break; case 'P': - channel = atoi(optarg); + if (optarg) + channel = atoi(optarg); break; case 'U': + if (!optarg) + break; + if (!strcasecmp(optarg, "spp")) uuid = SERIAL_PORT_SVCLASS_ID; else if (!strncasecmp(optarg, "0x", 2)) @@ -792,11 +802,13 @@ int main(int argc, char *argv[]) break; case 'L': - linger = atoi(optarg); + if (optarg) + linger = atoi(optarg); break; case 'W': - defer_setup = atoi(optarg); + if (optarg) + defer_setup = atoi(optarg); break; case 'B': @@ -808,19 +820,23 @@ int main(int argc, char *argv[]) break; case 'N': - num_frames = atoi(optarg); + if (optarg) + num_frames = atoi(optarg); break; case 'C': - count = atoi(optarg); + if (optarg) + count = atoi(optarg); break; case 'D': - delay = atoi(optarg) * 1000; + if (optarg) + delay = atoi(optarg) * 1000; break; case 'Y': - priority = atoi(optarg); + if (optarg) + priority = atoi(optarg); break; case 'T':