| Message ID | 20240813-bnxt-str-v2-1-872050a157e7@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ffff7ee843c351ce71d6e0d52f0f20bea35e18c9 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | bnxt_en: address string truncation | expand |
On Tue, Aug 13, 2024 at 7:33 AM Simon Horman <horms@kernel.org> wrote: > > This corrects an out-by-one error in the maximum length of the package > version string. The size argument of snprintf includes space for the > trailing '\0' byte, so there is no need to allow extra space for it by > reducing the value of the size argument by 1. > > Found by inspection. > Compile tested only. > > Signed-off-by: Simon Horman <horms@kernel.org> Thanks. Reviewed-by: Michael Chan <michael.chan@broadcom.com>
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 61d6afc3cacb..39eed5831e3a 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -4161,7 +4161,7 @@ static void bnxt_get_pkgver(struct net_device *dev) if (!bnxt_get_pkginfo(dev, buf, sizeof(buf))) { len = strlen(bp->fw_ver_str); - snprintf(bp->fw_ver_str + len, FW_VER_STR_LEN - len - 1, + snprintf(bp->fw_ver_str + len, FW_VER_STR_LEN - len, "/pkg %s", buf); } }
This corrects an out-by-one error in the maximum length of the package version string. The size argument of snprintf includes space for the trailing '\0' byte, so there is no need to allow extra space for it by reducing the value of the size argument by 1. Found by inspection. Compile tested only. Signed-off-by: Simon Horman <horms@kernel.org> --- v2: New patch --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)