mbox series

[0/3] arm64: dts: qcom: sc8280xp: enable WLAN and Bluetooth

Message ID 20240813190639.154983-1-brgl@bgdev.pl (mailing list archive)
Headers show
Series arm64: dts: qcom: sc8280xp: enable WLAN and Bluetooth | expand

Message

Bartosz Golaszewski Aug. 13, 2024, 7:06 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This enables WLAN and Bluetooth on two boards using the sc8280xp SoC.
For the sc8280xp-crd we add the PMU, wifi and bluetooth nodes with the
correctly modelled wiring between them. For the X13s, we rework existing
nodes so that they align with the new DT bindings contract.

Bartosz Golaszewski (2):
  arm64: dts: qcom: sc8280xp-crd: enable bluetooth
  arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855

Konrad Dybcio (1):
  arm64: dts: qcom: sc8280xp-crd: enable wifi

 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 169 ++++++++++++++++++
 .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  98 ++++++++--
 2 files changed, 255 insertions(+), 12 deletions(-)

Comments

Steev Klimaszewski Aug. 13, 2024, 8:11 p.m. UTC | #1
Hi Bartosz,

On Tue, Aug 13, 2024 at 2:07 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This enables WLAN and Bluetooth on two boards using the sc8280xp SoC.
> For the sc8280xp-crd we add the PMU, wifi and bluetooth nodes with the
> correctly modelled wiring between them. For the X13s, we rework existing
> nodes so that they align with the new DT bindings contract.
>
> Bartosz Golaszewski (2):
>   arm64: dts: qcom: sc8280xp-crd: enable bluetooth
>   arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855
>
> Konrad Dybcio (1):
>   arm64: dts: qcom: sc8280xp-crd: enable wifi
>
>  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 169 ++++++++++++++++++
>  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  98 ++++++++--
>  2 files changed, 255 insertions(+), 12 deletions(-)
>
> --
> 2.43.0
>
>
What does this patchset depend on?  I'm assuming I'm missing something
in my config as I've tried to test this patchset and I end up with the
wifi and bluetooth being deferred on my Thinkpad X13s

[   18.655330] pci 0006:01:00.0: deferred probe pending: pci: wait for
supplier /wcn6855-pmu/regulators/ldo9
[   18.655347] serial serial0-0: deferred probe pending: serial: wait
for supplier /wcn6855-pmu/regulators/ldo9
steev@finn:~$ sudo cat /sys/kernel/debug/devices_deferred
0006:01:00.0    pci: wait for supplier /wcn6855-pmu/regulators/ldo9
serial0-0    serial: wait for supplier /wcn6855-pmu/regulators/ldo9
Bartosz Golaszewski Aug. 13, 2024, 8:38 p.m. UTC | #2
On Tue, Aug 13, 2024 at 10:12 PM Steev Klimaszewski <steev@kali.org> wrote:
>
> Hi Bartosz,
>
> On Tue, Aug 13, 2024 at 2:07 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > This enables WLAN and Bluetooth on two boards using the sc8280xp SoC.
> > For the sc8280xp-crd we add the PMU, wifi and bluetooth nodes with the
> > correctly modelled wiring between them. For the X13s, we rework existing
> > nodes so that they align with the new DT bindings contract.
> >
> > Bartosz Golaszewski (2):
> >   arm64: dts: qcom: sc8280xp-crd: enable bluetooth
> >   arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855
> >
> > Konrad Dybcio (1):
> >   arm64: dts: qcom: sc8280xp-crd: enable wifi
> >
> >  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 169 ++++++++++++++++++
> >  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  98 ++++++++--
> >  2 files changed, 255 insertions(+), 12 deletions(-)
> >
> > --
> > 2.43.0
> >
> >
> What does this patchset depend on?  I'm assuming I'm missing something
> in my config as I've tried to test this patchset and I end up with the
> wifi and bluetooth being deferred on my Thinkpad X13s
>
> [   18.655330] pci 0006:01:00.0: deferred probe pending: pci: wait for
> supplier /wcn6855-pmu/regulators/ldo9
> [   18.655347] serial serial0-0: deferred probe pending: serial: wait
> for supplier /wcn6855-pmu/regulators/ldo9
> steev@finn:~$ sudo cat /sys/kernel/debug/devices_deferred
> 0006:01:00.0    pci: wait for supplier /wcn6855-pmu/regulators/ldo9
> serial0-0    serial: wait for supplier /wcn6855-pmu/regulators/ldo9

On Tue, 13 Aug 2024 at 22:12, Steev Klimaszewski <steev@kali.org> wrote:
>
> Hi Bartosz,
>
> On Tue, Aug 13, 2024 at 2:07 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > This enables WLAN and Bluetooth on two boards using the sc8280xp SoC.
> > For the sc8280xp-crd we add the PMU, wifi and bluetooth nodes with the
> > correctly modelled wiring between them. For the X13s, we rework existing
> > nodes so that they align with the new DT bindings contract.
> >
> > Bartosz Golaszewski (2):
> >   arm64: dts: qcom: sc8280xp-crd: enable bluetooth
> >   arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855
> >
> > Konrad Dybcio (1):
> >   arm64: dts: qcom: sc8280xp-crd: enable wifi
> >
> >  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 169 ++++++++++++++++++
> >  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  98 ++++++++--
> >  2 files changed, 255 insertions(+), 12 deletions(-)
> >
> > --
> > 2.43.0
> >
> >
> What does this patchset depend on?  I'm assuming I'm missing something
> in my config as I've tried to test this patchset and I end up with the
> wifi and bluetooth being deferred on my Thinkpad X13s
>
> [   18.655330] pci 0006:01:00.0: deferred probe pending: pci: wait for
> supplier /wcn6855-pmu/regulators/ldo9
> [   18.655347] serial serial0-0: deferred probe pending: serial: wait
> for supplier /wcn6855-pmu/regulators/ldo9
> steev@finn:~$ sudo cat /sys/kernel/debug/devices_deferred
> 0006:01:00.0    pci: wait for supplier /wcn6855-pmu/regulators/ldo9
> serial0-0    serial: wait for supplier /wcn6855-pmu/regulators/ldo9

Hi Steev!

There's a bunch of driver changes and some fixes needed for this to
work that I sent later. I also sent out DT bindings updates for it. I
decided to target relevant maintainers with smaller chunks because I
have had more luck getting patches upstream this way than when sending
big series with everything in them. Given that QCom patches take ages
to get picked up, I figured the driver changes will be in next by
then.

Your best approach would be to use the public integration branch from
my tree[1] or the one rebased on top of Johan's tree[2].

Bart

[1] https://git.codelinaro.org/bartosz_golaszewski/linux/-/tree/b4/sc8280xp-pwrseq?ref_type=heads
[2] https://git.codelinaro.org/bartosz_golaszewski/linux/-/tree/sc8280xp-pwrseq-on-jhovold?ref_type=heads
Steev Klimaszewski Aug. 13, 2024, 11:57 p.m. UTC | #3
On Tue, Aug 13, 2024 at 3:38 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> On Tue, Aug 13, 2024 at 10:12 PM Steev Klimaszewski <steev@kali.org> wrote:
> >
> > Hi Bartosz,
> >
> > On Tue, Aug 13, 2024 at 2:07 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > This enables WLAN and Bluetooth on two boards using the sc8280xp SoC.
> > > For the sc8280xp-crd we add the PMU, wifi and bluetooth nodes with the
> > > correctly modelled wiring between them. For the X13s, we rework existing
> > > nodes so that they align with the new DT bindings contract.
> > >
> > > Bartosz Golaszewski (2):
> > >   arm64: dts: qcom: sc8280xp-crd: enable bluetooth
> > >   arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855
> > >
> > > Konrad Dybcio (1):
> > >   arm64: dts: qcom: sc8280xp-crd: enable wifi
> > >
> > >  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 169 ++++++++++++++++++
> > >  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  98 ++++++++--
> > >  2 files changed, 255 insertions(+), 12 deletions(-)
> > >
> > > --
> > > 2.43.0
> > >
> > >
> > What does this patchset depend on?  I'm assuming I'm missing something
> > in my config as I've tried to test this patchset and I end up with the
> > wifi and bluetooth being deferred on my Thinkpad X13s
> >
> > [   18.655330] pci 0006:01:00.0: deferred probe pending: pci: wait for
> > supplier /wcn6855-pmu/regulators/ldo9
> > [   18.655347] serial serial0-0: deferred probe pending: serial: wait
> > for supplier /wcn6855-pmu/regulators/ldo9
> > steev@finn:~$ sudo cat /sys/kernel/debug/devices_deferred
> > 0006:01:00.0    pci: wait for supplier /wcn6855-pmu/regulators/ldo9
> > serial0-0    serial: wait for supplier /wcn6855-pmu/regulators/ldo9
>
> On Tue, 13 Aug 2024 at 22:12, Steev Klimaszewski <steev@kali.org> wrote:
> >
> > Hi Bartosz,
> >
> > On Tue, Aug 13, 2024 at 2:07 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > This enables WLAN and Bluetooth on two boards using the sc8280xp SoC.
> > > For the sc8280xp-crd we add the PMU, wifi and bluetooth nodes with the
> > > correctly modelled wiring between them. For the X13s, we rework existing
> > > nodes so that they align with the new DT bindings contract.
> > >
> > > Bartosz Golaszewski (2):
> > >   arm64: dts: qcom: sc8280xp-crd: enable bluetooth
> > >   arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855
> > >
> > > Konrad Dybcio (1):
> > >   arm64: dts: qcom: sc8280xp-crd: enable wifi
> > >
> > >  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 169 ++++++++++++++++++
> > >  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  98 ++++++++--
> > >  2 files changed, 255 insertions(+), 12 deletions(-)
> > >
> > > --
> > > 2.43.0
> > >
> > >
> > What does this patchset depend on?  I'm assuming I'm missing something
> > in my config as I've tried to test this patchset and I end up with the
> > wifi and bluetooth being deferred on my Thinkpad X13s
> >
> > [   18.655330] pci 0006:01:00.0: deferred probe pending: pci: wait for
> > supplier /wcn6855-pmu/regulators/ldo9
> > [   18.655347] serial serial0-0: deferred probe pending: serial: wait
> > for supplier /wcn6855-pmu/regulators/ldo9
> > steev@finn:~$ sudo cat /sys/kernel/debug/devices_deferred
> > 0006:01:00.0    pci: wait for supplier /wcn6855-pmu/regulators/ldo9
> > serial0-0    serial: wait for supplier /wcn6855-pmu/regulators/ldo9
>
> Hi Steev!
>
> There's a bunch of driver changes and some fixes needed for this to
> work that I sent later. I also sent out DT bindings updates for it. I
> decided to target relevant maintainers with smaller chunks because I
> have had more luck getting patches upstream this way than when sending
> big series with everything in them. Given that QCom patches take ages
> to get picked up, I figured the driver changes will be in next by
> then.
>
> Your best approach would be to use the public integration branch from
> my tree[1] or the one rebased on top of Johan's tree[2].
>
> Bart
>
> [1] https://git.codelinaro.org/bartosz_golaszewski/linux/-/tree/b4/sc8280xp-pwrseq?ref_type=heads
> [2] https://git.codelinaro.org/bartosz_golaszewski/linux/-/tree/sc8280xp-pwrseq-on-jhovold?ref_type=heads

Thanks for the quick response!  With everything in place, this does
seem to allow both wifi and bluetooth to continue to work on my
Thinkpad X13s
Tested-by: Steev Klimaszewski <steev@kali.org> #Thinkpad X13s
Rob Herring Aug. 14, 2024, 3:48 p.m. UTC | #4
On Tue, 13 Aug 2024 21:06:35 +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> This enables WLAN and Bluetooth on two boards using the sc8280xp SoC.
> For the sc8280xp-crd we add the PMU, wifi and bluetooth nodes with the
> correctly modelled wiring between them. For the X13s, we rework existing
> nodes so that they align with the new DT bindings contract.
> 
> Bartosz Golaszewski (2):
>   arm64: dts: qcom: sc8280xp-crd: enable bluetooth
>   arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855
> 
> Konrad Dybcio (1):
>   arm64: dts: qcom: sc8280xp-crd: enable wifi
> 
>  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 169 ++++++++++++++++++
>  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  98 ++++++++--
>  2 files changed, 255 insertions(+), 12 deletions(-)
> 
> --
> 2.43.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/sc8280xp-crd.dtb qcom/sc8280xp-lenovo-thinkpad-x13s.dtb' for 20240813190639.154983-1-brgl@bgdev.pl:

arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb: bluetooth: 'enable-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb: bluetooth: 'swctrl-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb: bluetooth: 'vddio-supply' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb: bluetooth: 'vddbtcxmx-supply' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb: bluetooth: 'vddrfa1p7-supply' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb: bluetooth: 'enable-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb: bluetooth: 'swctrl-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb: bluetooth: 'vddio-supply' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb: bluetooth: 'vddbtcxmx-supply' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb: bluetooth: 'vddrfa1p7-supply' is a required property
	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb: wifi@0: 'vddrfa1p8-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb: wifi@0: 'vddrfa1p8-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb: /wcn6855-pmu: failed to match any schema with compatible: ['qcom,wcn6855-pmu']
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb: /wcn6855-pmu: failed to match any schema with compatible: ['qcom,wcn6855-pmu']
Bartosz Golaszewski Aug. 14, 2024, 5 p.m. UTC | #5
On Wed, 14 Aug 2024 at 17:48, Rob Herring (Arm) <robh@kernel.org> wrote:
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>

Bindings were sent separately.

Bart