| Message ID | 20240729113226.2905928-2-danishanwar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for ICSSG PA_STATS | expand |
On 29/07/2024 14:32, MD Danish Anwar wrote: > Add documentation for pa-stats node which is syscon regmap for > PA_STATS registers. This will be used to dump statistics maintained by > ICSSG firmware. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: tags should come after Author's Signed-off-by: > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> Reviewed-by: Roger Quadros <rogerq@kernel.org>
On 09:42-20240805, Roger Quadros wrote: > > > On 29/07/2024 14:32, MD Danish Anwar wrote: > > Add documentation for pa-stats node which is syscon regmap for > > PA_STATS registers. This will be used to dump statistics maintained by > > ICSSG firmware. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: tags should come after Author's Signed-off-by: > > > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > > Reviewed-by: Roger Quadros <rogerq@kernel.org> If the net maintainers are OK, they could potentially take the binding patch along with the driver mods corresponding to this - I am a bit unsure of picking up a binding if the driver implementation is heading the wrong way.
On 06/08/24 8:33 pm, Nishanth Menon wrote: > On 09:42-20240805, Roger Quadros wrote: >> >> >> On 29/07/2024 14:32, MD Danish Anwar wrote: >>> Add documentation for pa-stats node which is syscon regmap for >>> PA_STATS registers. This will be used to dump statistics maintained by >>> ICSSG firmware. >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Reviewed-by: tags should come after Author's Signed-off-by: >> >>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> >> >> Reviewed-by: Roger Quadros <rogerq@kernel.org> > > If the net maintainers are OK, they could potentially take the binding > patch along with the driver mods corresponding to this - I am a bit > unsure of picking up a binding if the driver implementation is heading > the wrong way. > Hi Jakub, Paolo, David, Andrew, Will it be okay to pick this binding patch to net-next tree. Nishant is suggesting since the driver changes are done in drivers/net/ the binding can be picked by net maintainers. Please let us know if it will be okay to take this binding to net-next. I can post a new series with just the binding and the driver patch to net-next if needed.
On Mon, 12 Aug 2024 11:20:56 +0530 MD Danish Anwar wrote: > > If the net maintainers are OK, they could potentially take the binding > > patch along with the driver mods corresponding to this - I am a bit > > unsure of picking up a binding if the driver implementation is heading > > the wrong way. > > Hi Jakub, Paolo, David, Andrew, > > Will it be okay to pick this binding patch to net-next tree. Nishant is > suggesting since the driver changes are done in drivers/net/ the binding > can be picked by net maintainers. > > Please let us know if it will be okay to take this binding to net-next. > I can post a new series with just the binding and the driver patch to > net-next if needed. Nishanth, could you send an official Ack tag? No problem with merging it via net-next. On the code itself you may want to use ethtool_puts().
On 17:22-20240812, Jakub Kicinski wrote: > On Mon, 12 Aug 2024 11:20:56 +0530 MD Danish Anwar wrote: > > > If the net maintainers are OK, they could potentially take the binding > > > patch along with the driver mods corresponding to this - I am a bit > > > unsure of picking up a binding if the driver implementation is heading > > > the wrong way. > > > > Hi Jakub, Paolo, David, Andrew, > > > > Will it be okay to pick this binding patch to net-next tree. Nishant is > > suggesting since the driver changes are done in drivers/net/ the binding > > can be picked by net maintainers. > > > > Please let us know if it will be okay to take this binding to net-next. > > I can post a new series with just the binding and the driver patch to > > net-next if needed. > > Nishanth, could you send an official Ack tag? Acked-by: Nishanth Menon <nm@ti.com> Thanks Jakub. > > No problem with merging it via net-next. > On the code itself you may want to use ethtool_puts().
On 13/08/24 5:52 am, Jakub Kicinski wrote: > On Mon, 12 Aug 2024 11:20:56 +0530 MD Danish Anwar wrote: >>> If the net maintainers are OK, they could potentially take the binding >>> patch along with the driver mods corresponding to this - I am a bit >>> unsure of picking up a binding if the driver implementation is heading >>> the wrong way. >> >> Hi Jakub, Paolo, David, Andrew, >> >> Will it be okay to pick this binding patch to net-next tree. Nishant is >> suggesting since the driver changes are done in drivers/net/ the binding >> can be picked by net maintainers. >> >> Please let us know if it will be okay to take this binding to net-next. >> I can post a new series with just the binding and the driver patch to >> net-next if needed. > > Nishanth, could you send an official Ack tag? > > No problem with merging it via net-next. > On the code itself you may want to use ethtool_puts(). Thanks Jakub, I will send out a new series with just the binding and driver patch and send it to net-next. I will take care of ethtool_puts().
diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml index c402cb2928e8..3cb1471cc6b6 100644 --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml @@ -278,6 +278,26 @@ patternProperties: additionalProperties: false + ^pa-stats@[a-f0-9]+$: + description: | + PA-STATS sub-module represented as a SysCon. PA_STATS is a set of + registers where different statistics related to ICSSG, are dumped by + ICSSG firmware. This syscon sub-module will help the device to + access/read/write those statistics. + + type: object + + additionalProperties: false + + properties: + compatible: + items: + - const: ti,pruss-pa-st + - const: syscon + + reg: + maxItems: 1 + interrupt-controller@[a-f0-9]+$: description: | PRUSS INTC Node. Each PRUSS has a single interrupt controller instance