| Message ID | 20240814072806.4107079-2-quic_jingyw@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | soc: qcom: socinfo: Add QCS8275/QCS8300 SoC ID | expand |
On 14/08/2024 09:28, Jingyi Wang wrote: > Document the QCS8275/QCS8300 SoC and its reference board QCS8300 RIDE. > QCS8300 is an Industrial Safe SoC, while QCS8275 is the Industrial > Non-Safe version which can share the same SoC dtsi and board DTS. > > Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index f08e13b61172..3952e1579767 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -42,6 +42,8 @@ description: | > msm8996 > msm8998 > qcs404 > + qcs8275 > + qcs8300 > qcs8550 > qcm2290 > qcm6490 > @@ -884,6 +886,12 @@ properties: > - const: qcom,qcs404-evb > - const: qcom,qcs404 > > + - items: > + - enum: > + - qcom,qcs8300-ride This is not used. You miss DTS patch. Look how people upstream things: such binding *never* goes separate from the DTS. Best regards, Krzysztof
On 8/14/2024 4:56 PM, Krzysztof Kozlowski wrote: > On 14/08/2024 09:28, Jingyi Wang wrote: >> Document the QCS8275/QCS8300 SoC and its reference board QCS8300 RIDE. >> QCS8300 is an Industrial Safe SoC, while QCS8275 is the Industrial >> Non-Safe version which can share the same SoC dtsi and board DTS. >> >> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index f08e13b61172..3952e1579767 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -42,6 +42,8 @@ description: | >> msm8996 >> msm8998 >> qcs404 >> + qcs8275 >> + qcs8300 >> qcs8550 >> qcm2290 >> qcm6490 >> @@ -884,6 +886,12 @@ properties: >> - const: qcom,qcs404-evb >> - const: qcom,qcs404 >> >> + - items: >> + - enum: >> + - qcom,qcs8300-ride > > This is not used. You miss DTS patch. Look how people upstream things: > such binding *never* goes separate from the DTS. > > Best regards, > Krzysztof Thanks，I will remove that. Thanks, Jingyi
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index f08e13b61172..3952e1579767 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -42,6 +42,8 @@ description: | msm8996 msm8998 qcs404 + qcs8275 + qcs8300 qcs8550 qcm2290 qcm6490 @@ -884,6 +886,12 @@ properties: - const: qcom,qcs404-evb - const: qcom,qcs404 + - items: + - enum: + - qcom,qcs8300-ride + - const: qcom,qcs8275 + - const: qcom,qcs8300 + - items: - enum: - qcom,sa8155p-adp
Document the QCS8275/QCS8300 SoC and its reference board QCS8300 RIDE. QCS8300 is an Industrial Safe SoC, while QCS8275 is the Industrial Non-Safe version which can share the same SoC dtsi and board DTS. Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)