| Message ID | 246c0c7763a432d4bebcb0e99b90dcf4cded333d.1720957783.git.stano.jakubek@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Spreadtrum SC2731 MFD cleanups | expand |
On 2024/7/14 19:57, Stanislav Jakubek wrote: > According to DT spec, node names should be generic. Rename the > sprd,sc2731-fgu node to a more generic "fuel-gauge". > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> LGTM. Thanks. Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> > --- > arch/arm64/boot/dts/sprd/sc2731.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi > index 7e55b2b31c84..48b681768f6e 100644 > --- a/arch/arm64/boot/dts/sprd/sc2731.dtsi > +++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi > @@ -95,7 +95,7 @@ pmic_adc: adc@480 { > nvmem-cells = <&adc_big_scale>, <&adc_small_scale>; > }; > > - fgu@a00 { > + fuel-gauge@a00 { > compatible = "sprd,sc2731-fgu"; > reg = <0xa00>; > bat-detect-gpio = <&pmic_eic 9 GPIO_ACTIVE_HIGH>;
On Sun, 14 Jul 2024 13:57:00 +0200, Stanislav Jakubek wrote: > According to DT spec, node names should be generic. Rename the > sprd,sc2731-fgu node to a more generic "fuel-gauge". > > This also waits for something... so I grabbed it. Applied, thanks! [2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic https://git.kernel.org/krzk/linux-dt/c/e06e908dba9fed62c9493ea5cea2e4cbd306d23c Best regards,
On Wed, Aug 14, 2024 at 04:20:29PM +0200, Krzysztof Kozlowski wrote: > > On Sun, 14 Jul 2024 13:57:00 +0200, Stanislav Jakubek wrote: > > According to DT spec, node names should be generic. Rename the > > sprd,sc2731-fgu node to a more generic "fuel-gauge". > > > > > > This also waits for something... so I grabbed it. > > Applied, thanks! > > [2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic > https://git.kernel.org/krzk/linux-dt/c/e06e908dba9fed62c9493ea5cea2e4cbd306d23c > > Best regards, > -- > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Hi Krzysztof, you already applied this change as part of [1]. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit?id=0dcc203956537696e6f936eef886fde70e049f54 Cheers, Stanislav
On 15/08/2024 10:18, Stanislav Jakubek wrote: > On Wed, Aug 14, 2024 at 04:20:29PM +0200, Krzysztof Kozlowski wrote: >> >> On Sun, 14 Jul 2024 13:57:00 +0200, Stanislav Jakubek wrote: >>> According to DT spec, node names should be generic. Rename the >>> sprd,sc2731-fgu node to a more generic "fuel-gauge". >>> >>> >> >> This also waits for something... so I grabbed it. >> >> Applied, thanks! >> >> [2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic >> https://git.kernel.org/krzk/linux-dt/c/e06e908dba9fed62c9493ea5cea2e4cbd306d23c >> >> Best regards, >> -- >> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Hi Krzysztof, > > you already applied this change as part of [1]. > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit?id=0dcc203956537696e6f936eef886fde70e049f54 Indeed, thanks. I managed to double-apply because somehow how got impression that was arm32, not arm64. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi index 7e55b2b31c84..48b681768f6e 100644 --- a/arch/arm64/boot/dts/sprd/sc2731.dtsi +++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi @@ -95,7 +95,7 @@ pmic_adc: adc@480 { nvmem-cells = <&adc_big_scale>, <&adc_small_scale>; }; - fgu@a00 { + fuel-gauge@a00 { compatible = "sprd,sc2731-fgu"; reg = <0xa00>; bat-detect-gpio = <&pmic_eic 9 GPIO_ACTIVE_HIGH>;
According to DT spec, node names should be generic. Rename the sprd,sc2731-fgu node to a more generic "fuel-gauge". Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> --- arch/arm64/boot/dts/sprd/sc2731.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)