[net,v6,0/2] Enhance network interface feature testing

Message

Abhinav Jain Aug. 14, 2024, 7:15 p.m. UTC

This small series includes fixes for creation of veth pairs for
networkless kernels & adds tests for turning the different network
interface features on and off in selftests/net/netdevice.sh script.

Changes in v6:
Use XFAIL for ethtool operations that are unsupported instead of SKIP.

Changes in v5:
https://lore.kernel.org/all/[e-mail]/

Rectify the syntax for ip add link.
Fix the veth_created condition check.

Changes in v4:
https://lore.kernel.org/all/[e-mail]/

Move veth creation/removal to the main shell script.
Tested using vng on a networkless kernel and the script works, sample
output below the changes.

Changes in v3:
https://lore.kernel.org/all/[e-mail]/

Add a check for netdev, create veth pair for testing.
Restore feature to its initial state.

Changes in v2:
https://lore.kernel.org/all/[e-mail]/

Remove tail usage; use read to parse the features from temp file.

v1:
https://lore.kernel.org/all/[e-mail]/

```
# selftests: net: netdevice.sh
# No valid network device found, creating veth pair
# PASS: veth0: set interface up
# PASS: veth0: set MAC address
# SKIP: veth0: set IP address
# PASS: veth0: ethtool list features
# PASS: veth0: Turned off feature: rx-checksumming
# PASS: veth0: Turned on feature: rx-checksumming
# PASS: veth0: Restore feature rx-checksumming to initial state on
# Actual changes:


# PASS: veth0: Restore feature rx-gro-list to initial state off
# PASS: veth0: Turned off feature: rx-udp-gro-forwarding
# PASS: veth0: Turned on feature: rx-udp-gro-forwarding
# PASS: veth0: Restore feature rx-udp-gro-forwarding to initial state off
# Cannot get register dump: Operation not supported
# XFAIL: veth0: ethtool dump not supported
# PASS: veth0: ethtool stats
# PASS: veth0: stop interface
```

Abhinav Jain (2):
  selftests: net: Create veth pair for testing in networkless kernel
  selftests: net: Add on/off checks for non-fixed features of interface

 tools/testing/selftests/net/netdevice.sh | 55 +++++++++++++++++++++++-
 1 file changed, 53 insertions(+), 2 deletions(-)

--
2.34.1

Comments

Jakub Kicinski Aug. 15, 2024, 12:56 a.m. UTC | #1

On Wed, 14 Aug 2024 19:15:15 +0000 Abhinav Jain wrote:
> Changes in v6:
> Use XFAIL for ethtool operations that are unsupported instead of SKIP.

One more:

tools/testing/selftests/net/netdevice.sh:       echo "SKIP: $netdev: set IP address"

I think the SKIP -> XFAIL conversion should be a separate patch (for
total of 3 patches in the series).

Jakub Kicinski Aug. 15, 2024, 12:57 a.m. UTC | #2

On Wed, 14 Aug 2024 17:56:51 -0700 Jakub Kicinski wrote:
> On Wed, 14 Aug 2024 19:15:15 +0000 Abhinav Jain wrote:
> > Changes in v6:
> > Use XFAIL for ethtool operations that are unsupported instead of SKIP.  
> 
> One more:
> 
> tools/testing/selftests/net/netdevice.sh:       echo "SKIP: $netdev: set IP address"
> 
> I think the SKIP -> XFAIL conversion should be a separate patch (for
> total of 3 patches in the series).

P.S. and please change the subject to [PATCH net-next], it's a net-next
change, not a net fix.

Abhinav Jain Aug. 15, 2024, 11:04 a.m. UTC | #3

On Wed, 14 Aug 2024 17:57:48 -0700, Jakub Kicinski wrote:

> On Wed, 14 Aug 2024 17:56:51 -0700 Jakub Kicinski wrote:
> > On Wed, 14 Aug 2024 19:15:15 +0000 Abhinav Jain wrote:
> > > Changes in v6:
> > > Use XFAIL for ethtool operations that are unsupported instead of SKIP.  
> >
> > One more:
> >
> > tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev: set IP address"
> >
> > I think the SKIP -> XFAIL conversion should be a separate patch (for
> > total of 3 patches in the series).
>
> P.S. and please change the subject to [PATCH net-next], it's a net-next
> change, not a net fix.

I have sent v7 now with net-next instead of net:
https://lore.kernel.org/all/[e-mail]

For set IP address part, I have added logic to XFAIL if veth pair was created 
and to SKIP if that's not the case in third patch of the series as directed above.

Right now, there is no logic to set IP address in the script for normal interfaces
either and it is a TODO as well. I will focus on it next after this one is applied.

Thank you for all the help Jakub.

Jakub Kicinski Aug. 15, 2024, 3:50 p.m. UTC | #4

On Thu, 15 Aug 2024 16:34:42 +0530 Abhinav Jain wrote:
> > > One more:
> > >
> > > tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev: set IP address"
> > >
> > > I think the SKIP -> XFAIL conversion should be a separate patch (for
> > > total of 3 patches in the series).  
> >
> > P.S. and please change the subject to [PATCH net-next], it's a net-next
> > change, not a net fix.  
> 
> I have sent v7 now with net-next instead of net:
> https://lore.kernel.org/all/[e-mail]
> 
> For set IP address part, I have added logic to XFAIL if veth pair was created 
> and to SKIP if that's not the case in third patch of the series as directed above.
> 
> Right now, there is no logic to set IP address in the script for normal interfaces
> either and it is a TODO as well. I will focus on it next after this one is applied.

Minor note, please keep your guidance on frequency of reposting in mind:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html