[0/3] drm/mediatek: fixes for ovl_adaptor

Message

Javier Carrasco June 24, 2024, 4:43 p.m. UTC

The main fix is a possible memory leak on an early exit in the
for_each_child_of_node() loop. That fix has been divided into a patch
that can be backported (a simple of_node_put()), and another one that
uses the scoped variant of the macro, removing the need for any
of_node_put(). That prevents mistakes if new break/return instructions
are added, but the macro might not be available in older kernels.

When at it, an unused header has been dropped.

Signed-off-by: Javier Carrasco <[e-mail]>
---
Javier Carrasco (3):
      drm/mediatek: ovl_adaptor: drop unused mtk_crtc.h header
      drm/mediatek: ovl_adaptor: add missing of_node_put()
      drm/mediatek: ovl_adaptor: use scoped variant of for_each_child_of_node()

 drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
---
base-commit: f76698bd9a8ca01d3581236082d786e9a6b72bb7
change-id: 20240624-mtk_disp_ovl_adaptor_scoped-0702a6b23443

Best regards,

Comments

Chun-Kuang Hu Aug. 15, 2024, 1:57 p.m. UTC | #1

Hi, Javier:

Javier Carrasco <[e-mail]> 於 2024年6月25日 週二 上午12:44寫道：
>
> The main fix is a possible memory leak on an early exit in the
> for_each_child_of_node() loop. That fix has been divided into a patch
> that can be backported (a simple of_node_put()), and another one that
> uses the scoped variant of the macro, removing the need for any
> of_node_put(). That prevents mistakes if new break/return instructions
> are added, but the macro might not be available in older kernels.
>
> When at it, an unused header has been dropped.

For this series, applied to mediatek-drm-next [1], thanks.

Regards,
CK

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

>
> Signed-off-by: Javier Carrasco <[e-mail]>
> ---
> Javier Carrasco (3):
>       drm/mediatek: ovl_adaptor: drop unused mtk_crtc.h header
>       drm/mediatek: ovl_adaptor: add missing of_node_put()
>       drm/mediatek: ovl_adaptor: use scoped variant of for_each_child_of_node()
>
>  drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> ---
> base-commit: f76698bd9a8ca01d3581236082d786e9a6b72bb7
> change-id: 20240624-mtk_disp_ovl_adaptor_scoped-0702a6b23443
>
> Best regards,
> --
> Javier Carrasco <[e-mail]>
>