[v2] clk: qcom: clk-rpmh: Fix overflow in BCM vote

Commit Message

Imran Shaik Aug. 9, 2024, 5:21 a.m. UTC

From: Mike Tipton <[e-mail]>

Valid frequencies may result in BCM votes that exceed the max HW value.
Set vote ceiling to BCM_TCS_CMD_VOTE_MASK to ensure the votes aren't
truncated, which can result in lower frequencies than desired.

Fixes: 04053f4d23a4 ("clk: qcom: clk-rpmh: Add IPA clock support")
Cc: [e-mail]
Signed-off-by: Mike Tipton <[e-mail]>
Reviewed-by: Taniya Das <[e-mail]>
Signed-off-by: Imran Shaik <[e-mail]>
---
Changes in v2:
- Updated the overflow check as per the comment from Stephen.
- Link to v1: https://lore.kernel.org/r/[e-mail]
---
 drivers/clk/qcom/clk-rpmh.c | 2 ++
 1 file changed, 2 insertions(+)


---
base-commit: 222a3380f92b8791d4eeedf7cd750513ff428adf
change-id: 20240808-clk-rpmh-bcm-vote-fix-c344e213c9bb

Best regards,

Comments

Bjorn Andersson Aug. 15, 2024, 8:40 p.m. UTC | #1

On Fri, 09 Aug 2024 10:51:29 +0530, Imran Shaik wrote:
> Valid frequencies may result in BCM votes that exceed the max HW value.
> Set vote ceiling to BCM_TCS_CMD_VOTE_MASK to ensure the votes aren't
> truncated, which can result in lower frequencies than desired.
> 
> 

Applied, thanks!

[1/1] clk: qcom: clk-rpmh: Fix overflow in BCM vote
      commit: a4e5af27e6f6a8b0d14bc0d7eb04f4a6c7291586

Best regards,

Patch

diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index bb82abeed88f..4acde937114a 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -263,6 +263,8 @@  static int clk_rpmh_bcm_send_cmd(struct clk_rpmh *c, bool enable)
 		cmd_state = 0;
 	}
 
+	cmd_state = min(cmd_state, BCM_TCS_CMD_VOTE_MASK);
+
 	if (c->last_sent_aggr_state != cmd_state) {
 		cmd.addr = c->res_addr;
 		cmd.data = BCM_TCS_CMD(1, enable, 0, cmd_state);