mbox series

[net,0/4] bonding: fix xfrm offload bugs

Message ID 20240816114813.326645-1-razor@blackwall.org (mailing list archive)
Headers show
Series bonding: fix xfrm offload bugs | expand

Message

Nikolay Aleksandrov Aug. 16, 2024, 11:48 a.m. UTC 
Hi,
I noticed these problems while reviewing a bond xfrm patch recently.
The fixes are straight-forward, please review carefully the last one
because it has side-effects. This set has passed bond's selftests
and my custom bond stress tests which crash without these fixes.

Note the first patch is not critical, but it simplifies the next fix.

Thanks,
 Nik


Nikolay Aleksandrov (4):
  bonding: fix bond_ipsec_offload_ok return type
  bonding: fix null pointer deref in bond_ipsec_offload_ok
  bonding: fix xfrm real_dev null pointer dereference
  bonding: fix xfrm state handling when clearing active slave

 drivers/net/bonding/bond_main.c    | 21 ++++++++-------------
 drivers/net/bonding/bond_options.c |  2 +-
 2 files changed, 9 insertions(+), 14 deletions(-)

Comments

Nikolay Aleksandrov Aug. 16, 2024, 11:52 a.m. UTC | #1 
On 16/08/2024 14:48, Nikolay Aleksandrov wrote:
> Hi,
> I noticed these problems while reviewing a bond xfrm patch recently.
> The fixes are straight-forward, please review carefully the last one
> because it has side-effects. This set has passed bond's selftests
> and my custom bond stress tests which crash without these fixes.
> 
> Note the first patch is not critical, but it simplifies the next fix.
> 
> Thanks,
>  Nik
> 
> 
> Nikolay Aleksandrov (4):
>   bonding: fix bond_ipsec_offload_ok return type
>   bonding: fix null pointer deref in bond_ipsec_offload_ok
>   bonding: fix xfrm real_dev null pointer dereference
>   bonding: fix xfrm state handling when clearing active slave
> 
>  drivers/net/bonding/bond_main.c    | 21 ++++++++-------------
>  drivers/net/bonding/bond_options.c |  2 +-
>  2 files changed, 9 insertions(+), 14 deletions(-)
> 

Oops forgot to CC Hangbin, sorry about that (CCed).
patchwork-bot+netdevbpf@kernel.org Aug. 20, 2024, 1:40 p.m. UTC | #2 
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Fri, 16 Aug 2024 14:48:09 +0300 you wrote:
> Hi,
> I noticed these problems while reviewing a bond xfrm patch recently.
> The fixes are straight-forward, please review carefully the last one
> because it has side-effects. This set has passed bond's selftests
> and my custom bond stress tests which crash without these fixes.
> 
> Note the first patch is not critical, but it simplifies the next fix.
> 
> [...]

Here is the summary with links:
  - [net,1/4] bonding: fix bond_ipsec_offload_ok return type
    https://git.kernel.org/netdev/net/c/fc59b9a5f720
  - [net,2/4] bonding: fix null pointer deref in bond_ipsec_offload_ok
    https://git.kernel.org/netdev/net/c/95c90e4ad89d
  - [net,3/4] bonding: fix xfrm real_dev null pointer dereference
    https://git.kernel.org/netdev/net/c/f8cde9805981
  - [net,4/4] bonding: fix xfrm state handling when clearing active slave
    https://git.kernel.org/netdev/net/c/c4c5c5d2ef40

You are awesome, thank you!