[net-next,v6,0/6] net: dsa: microchip: ksz8795: add Wake on LAN support

Message

Pieter Aug. 13, 2024, 2:27 p.m. UTC

From: Pieter Van Trappen <[e-mail]>

Add WoL support for KSZ8795 family of switches. This code was tested
with a KSZ8794 chip.

Strongly based on existing KSZ9477 code which has now been moved to
ksz_common instead of duplicating, as proposed during the review of
the v1 version of this patch.

In addition to the device-tree addition and the actual code, there's
two additional patches that fix some bugs found when further testing
DSA with this KSZ8794 chip.

Signed-off-by: Pieter Van Trappen <[e-mail]>
---
v6:
 - patch 6/6: use GENMASK macro in dedicated mask macro instead of inline

v5: https://lore.kernel.org/netdev/[e-mail]/
 - patch 5/6: split off DSA tag_ksz fix to separate patch 6/6

v4: https://lore.kernel.org/netdev/[e-mail]/
 - patch 4/5: rename KSZ8795* macros to KSZ87XX*
 - patch 5/5: rename ksz8_dev_ops to ksz88x3_dev_ops
 - patch 5/5: additional DSA tag_ksz fix

v3: https://lore.kernel.org/netdev/[e-mail]/
 - ensure each patch separately compiles & works
 - additional return value checks where possible
 - drop v2 patch 5/5 (net: dsa: microchip: check erratum workaround through indirect register read)
 - add new patch 5/5 that fixes KSZ87xx bugs wrt datasheet

v2: https://lore.kernel.org/netdev/[e-mail]/
 - generalize instead of duplicate, much improved
 - variable declaration reverse Christmas tree
 - ksz8_handle_global_errata: return -EIO in case of indirect write failure
 - ksz8_ind_read8/write8: document functions
 - ksz8_handle_wake_reason: no need for additional write to clear
 - fix wakeup_source origin comments
v1: https://lore.kernel.org/netdev/[e-mail]/

Pieter Van Trappen (6):
  dt-bindings: net: dsa: microchip: add microchip,pme-active-high flag
  net: dsa: microchip: move KSZ9477 WoL functions to ksz_common
  net: dsa: microchip: generalize KSZ9477 WoL functions at ksz_common
  net: dsa: microchip: add WoL support for KSZ87xx family
  net: dsa: microchip: fix KSZ87xx family structure wrt the datasheet
  net: dsa: microchip: fix tag_ksz egress mask for KSZ8795 family

 .../bindings/net/dsa/microchip,ksz.yaml       |   5 +
 drivers/net/dsa/microchip/ksz8.h              |   3 +
 drivers/net/dsa/microchip/ksz8795.c           |  94 +++++-
 drivers/net/dsa/microchip/ksz9477.c           | 197 +------------
 drivers/net/dsa/microchip/ksz9477.h           |   5 -
 drivers/net/dsa/microchip/ksz9477_reg.h       |  12 -
 drivers/net/dsa/microchip/ksz_common.c        | 271 ++++++++++++++++--
 drivers/net/dsa/microchip/ksz_common.h        |  31 +-
 net/dsa/tag_ksz.c                             |   6 +-
 9 files changed, 391 insertions(+), 233 deletions(-)


base-commit: dd1bf9f9df156b43e5122f90d97ac3f59a1a5621

Comments

[e-mail] Aug. 16, 2024, 5:30 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Tue, 13 Aug 2024 16:27:34 +0200 you wrote:
> From: Pieter Van Trappen <[e-mail]>
> 
> Add WoL support for KSZ8795 family of switches. This code was tested
> with a KSZ8794 chip.
> 
> Strongly based on existing KSZ9477 code which has now been moved to
> ksz_common instead of duplicating, as proposed during the review of
> the v1 version of this patch.
> 
> [...]

Here is the summary with links:
  - [net-next,v6,1/6] dt-bindings: net: dsa: microchip: add microchip,pme-active-high flag
    https://git.kernel.org/netdev/net-next/c/6a66873d820b
  - [net-next,v6,2/6] net: dsa: microchip: move KSZ9477 WoL functions to ksz_common
    https://git.kernel.org/netdev/net-next/c/f3ac6198a719
  - [net-next,v6,3/6] net: dsa: microchip: generalize KSZ9477 WoL functions at ksz_common
    https://git.kernel.org/netdev/net-next/c/fd250fed1f88
  - [net-next,v6,4/6] net: dsa: microchip: add WoL support for KSZ87xx family
    https://git.kernel.org/netdev/net-next/c/90b06ac06529
  - [net-next,v6,5/6] net: dsa: microchip: fix KSZ87xx family structure wrt the datasheet
    https://git.kernel.org/netdev/net-next/c/0d3edc90c4a0
  - [net-next,v6,6/6] net: dsa: microchip: fix tag_ksz egress mask for KSZ8795 family
    https://git.kernel.org/netdev/net-next/c/6f2b72c04d58

You are awesome, thank you!