diff mbox series

[2/5] dt-bindings: clock: cirrus,lochnagar: add top-level constraints

Message ID 20240818173014.122073-2-krzysztof.kozlowski@linaro.org (mailing list archive)
State New, archived
Headers show
Series [1/5] dt-bindings: clock: baikal,bt1-ccu-div: add top-level constraints | expand

Commit Message

Krzysztof Kozlowski Aug. 18, 2024, 5:30 p.m. UTC
Properties with variable number of items per each device are expected to
have widest constraints in top-level "properties:" block and further
customized (narrowed) in "if:then:".  Add missing top-level constraints
for clocks.  Drop also redundant assigned-clocks properties, because
core dtschema allows them if clocks are provided.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/clock/cirrus,lochnagar.yaml         | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Conor Dooley Aug. 19, 2024, 5:10 p.m. UTC | #1
On Sun, Aug 18, 2024 at 07:30:11PM +0200, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:".  Add missing top-level constraints
> for clocks.  Drop also redundant assigned-clocks properties, because
> core dtschema allows them if clocks are provided.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> ---
>  .../devicetree/bindings/clock/cirrus,lochnagar.yaml         | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml b/Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml
> index 59de125647ec..ccff74eda9fb 100644
> --- a/Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml
> +++ b/Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml
> @@ -67,9 +67,9 @@ properties:
>      minItems: 1
>      maxItems: 19
>  
> -  clocks: true
> -  assigned-clocks: true
> -  assigned-clock-parents: true
> +  clocks:
> +    minItems: 1
> +    maxItems: 19
>  
>  additionalProperties: false
>  
> -- 
> 2.43.0
>
Stephen Boyd Aug. 28, 2024, 5 p.m. UTC | #2
Quoting Krzysztof Kozlowski (2024-08-18 10:30:11)
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:".  Add missing top-level constraints
> for clocks.  Drop also redundant assigned-clocks properties, because
> core dtschema allows them if clocks are provided.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml b/Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml
index 59de125647ec..ccff74eda9fb 100644
--- a/Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml
+++ b/Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml
@@ -67,9 +67,9 @@  properties:
     minItems: 1
     maxItems: 19
 
-  clocks: true
-  assigned-clocks: true
-  assigned-clock-parents: true
+  clocks:
+    minItems: 1
+    maxItems: 19
 
 additionalProperties: false