mbox series

[0/6] dt-bindings: add serial-peripheral-props.yaml

Message ID 20240811-dt-bindings-serial-peripheral-props-v1-0-1dba258b7492@linaro.org (mailing list archive)
Headers show
Series dt-bindings: add serial-peripheral-props.yaml | expand

Message

Krzysztof Kozlowski Aug. 11, 2024, 6:17 p.m. UTC
Hi,

Add serial-peripheral-props.yaml for devices being connected over
serial/UART.

Maybe the schema should be rather called serial-common-props.yaml? Or
serial-device-common-props.yaml?

Dependencies/merging - Devicetree tree?
=======================================
Entire patchset should be taken via one tree, preferably Rob's
Devicetree because of context/hunk dependencies and dependency on
introduced serial-peripheral-props.yaml file.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (6):
      dt-bindings: serial: add missing "additionalProperties" on child nodes
      dt-bindings: serial: add common properties schema for UART children
      dt-bindings: bluetooth: move Bluetooth bindings to dedicated directory
      dt-bindings: gnss: reference serial-peripheral-props.yaml
      dt-bindings: bluetooth: reference serial-peripheral-props.yaml
      ASoC: dt-bindings: serial-midi: reference serial-peripheral-props.yaml

 .../devicetree/bindings/gnss/brcm,bcm4751.yaml     |  1 +
 .../devicetree/bindings/gnss/gnss-common.yaml      |  5 ---
 .../devicetree/bindings/gnss/mediatek.yaml         |  1 +
 .../devicetree/bindings/gnss/sirfstar.yaml         |  1 +
 .../devicetree/bindings/gnss/u-blox,neo-6m.yaml    |  1 +
 .../brcm,bluetooth.yaml}                           | 33 +++++++++--------
 .../marvell,88w8897.yaml}                          |  6 ++--
 .../mediatek,bluetooth.txt}                        |  0
 .../nokia,h4p-bluetooth.txt}                       |  0
 .../bindings/net/bluetooth/qualcomm-bluetooth.yaml |  4 +--
 .../realtek,bluetooth.yaml}                        |  5 ++-
 .../bindings/net/{ => bluetooth}/ti,bluetooth.yaml |  5 ++-
 .../bindings/serial/serial-peripheral-props.yaml   | 41 ++++++++++++++++++++++
 .../devicetree/bindings/serial/serial.yaml         | 24 ++-----------
 .../devicetree/bindings/sound/serial-midi.yaml     |  3 ++
 MAINTAINERS                                        |  2 +-
 16 files changed, 80 insertions(+), 52 deletions(-)
---
base-commit: 8626c4826dd708e05ba457c44493d575d75d375c
change-id: 20240811-dt-bindings-serial-peripheral-props-419e8f88e270

Best regards,

Comments

Conor Dooley Aug. 12, 2024, 4:05 p.m. UTC | #1
On Sun, Aug 11, 2024 at 08:17:03PM +0200, Krzysztof Kozlowski wrote:
> Hi,
> 
> Add serial-peripheral-props.yaml for devices being connected over
> serial/UART.
> 
> Maybe the schema should be rather called serial-common-props.yaml? Or
> serial-device-common-props.yaml?
> 
> Dependencies/merging - Devicetree tree?
> =======================================
> Entire patchset should be taken via one tree, preferably Rob's
> Devicetree because of context/hunk dependencies and dependency on
> introduced serial-peripheral-props.yaml file.

The whole idea seems reasonable to me, but I question whether it is
worth tagging it if Rob's gonna be the one applying it.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Rob Herring Aug. 19, 2024, 7:39 p.m. UTC | #2
On Sun, Aug 11, 2024 at 08:17:03PM +0200, Krzysztof Kozlowski wrote:
> Hi,
> 
> Add serial-peripheral-props.yaml for devices being connected over
> serial/UART.
> 
> Maybe the schema should be rather called serial-common-props.yaml? Or
> serial-device-common-props.yaml?
> 
> Dependencies/merging - Devicetree tree?
> =======================================
> Entire patchset should be taken via one tree, preferably Rob's
> Devicetree because of context/hunk dependencies and dependency on
> introduced serial-peripheral-props.yaml file.
> 
> Best regards,
> Krzysztof
> 
> ---
> Krzysztof Kozlowski (6):
>       dt-bindings: serial: add missing "additionalProperties" on child nodes
>       dt-bindings: serial: add common properties schema for UART children
>       dt-bindings: bluetooth: move Bluetooth bindings to dedicated directory
>       dt-bindings: gnss: reference serial-peripheral-props.yaml
>       dt-bindings: bluetooth: reference serial-peripheral-props.yaml
>       ASoC: dt-bindings: serial-midi: reference serial-peripheral-props.yaml
> 
>  .../devicetree/bindings/gnss/brcm,bcm4751.yaml     |  1 +
>  .../devicetree/bindings/gnss/gnss-common.yaml      |  5 ---
>  .../devicetree/bindings/gnss/mediatek.yaml         |  1 +
>  .../devicetree/bindings/gnss/sirfstar.yaml         |  1 +
>  .../devicetree/bindings/gnss/u-blox,neo-6m.yaml    |  1 +
>  .../brcm,bluetooth.yaml}                           | 33 +++++++++--------
>  .../marvell,88w8897.yaml}                          |  6 ++--
>  .../mediatek,bluetooth.txt}                        |  0
>  .../nokia,h4p-bluetooth.txt}                       |  0
>  .../bindings/net/bluetooth/qualcomm-bluetooth.yaml |  4 +--
>  .../realtek,bluetooth.yaml}                        |  5 ++-
>  .../bindings/net/{ => bluetooth}/ti,bluetooth.yaml |  5 ++-
>  .../bindings/serial/serial-peripheral-props.yaml   | 41 ++++++++++++++++++++++
>  .../devicetree/bindings/serial/serial.yaml         | 24 ++-----------
>  .../devicetree/bindings/sound/serial-midi.yaml     |  3 ++
>  MAINTAINERS                                        |  2 +-
>  16 files changed, 80 insertions(+), 52 deletions(-)

Series applied, thanks.

Rob