diff mbox series

[v3,1/1] dt-bindings: extcon: ptn5150: add child node port

Message ID 20240819185734.372469-1-Frank.Li@nxp.com (mailing list archive)
State Superseded
Headers show
Series [v3,1/1] dt-bindings: extcon: ptn5150: add child node port | expand

Commit Message

Frank Li Aug. 19, 2024, 6:57 p.m. UTC
Add child node 'port' to allow connect to usb controller to do role-switch
if id pin of ptn5150 have not connected to chip's usb ID function pin.

Fix below warning:
arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v2 to v3
- only add port to existed example.
Change from v1 to v2
- add example for id pin have not connect to main chip's id example.
- commit 095b96b2b fix "port" warning, but add new warning "connector" is
not exist. And follow commit revert this change.
690085d866f08 Revert "arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector
- I have not board in hand to debug why "connector" is not work.
---
 .../devicetree/bindings/extcon/extcon-ptn5150.yaml   | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Krzysztof Kozlowski Aug. 20, 2024, 7:44 a.m. UTC | #1
On Mon, Aug 19, 2024 at 02:57:34PM -0400, Frank Li wrote:
> Add child node 'port' to allow connect to usb controller to do role-switch
> if id pin of ptn5150 have not connected to chip's usb ID function pin.
> 

...

>  required:
>    - compatible
>    - interrupts
> @@ -58,5 +63,12 @@ examples:
>              interrupt-parent = <&msmgpio>;
>              interrupts = <78 IRQ_TYPE_LEVEL_HIGH>;
>              vbus-gpios = <&msmgpio 148 GPIO_ACTIVE_HIGH>;
> +
> +            port {
> +                    endpoint {

Indentation is mixed up here.

> +                        remote-endpoint = <&usb1_drd_sw>;
> +                 };
> +            };
> +

Drop blank line.

>          };
>      };
> -- 
> 2.34.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
index d5cfa32ea52dd..0f61cd64e4bc0 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
+++ b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
@@ -37,6 +37,11 @@  properties:
       GPIO pin (output) used to control VBUS. If skipped, no such control
       takes place.
 
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    description:
+      A port node to link the usb controller for the dual role switch.
+
 required:
   - compatible
   - interrupts
@@ -58,5 +63,12 @@  examples:
             interrupt-parent = <&msmgpio>;
             interrupts = <78 IRQ_TYPE_LEVEL_HIGH>;
             vbus-gpios = <&msmgpio 148 GPIO_ACTIVE_HIGH>;
+
+            port {
+                    endpoint {
+                        remote-endpoint = <&usb1_drd_sw>;
+                 };
+            };
+
         };
     };