| Message ID | 20240814212958.4047882-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/1] dt-binding: memory-controllers: fsl,ifc: add compatible string fsl,ifc-nand | expand |
On Wed, Aug 14, 2024 at 05:29:57PM -0400, Frank Li wrote: > ifc can connect nor, nand and fpag. Add child node "nand@" under fsl,ifc > and compatible string "fsl,ifc-nand" when ifc connect to nand flash. > > Fix below warning: > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0: > failed to match any schema with compatible: ['fsl,ifc-nand'] > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Change from v1 to v2 > - add address-cells and size-cells > --- > .../memory-controllers/fsl/fsl,ifc.yaml | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml > index d1c3421bee107..c12bb7f51db62 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml > @@ -58,6 +58,27 @@ properties: > access window as configured. > > patternProperties: > + "^nand@[a-f0-9]+(,[a-f0-9]+)+$": > + type: object > + properties: > + compatible: > + const: fsl,ifc-nand > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 These only apply to child nodes, but you've disabled any child nodes. > + > + required: > + - compatible > + - reg > + > + additionalProperties: false You could minimally make this 'type: object' instead of false. Or does this follow the nand controller and chip bindings? May not being older binding. > + > "^.*@[a-f0-9]+(,[a-f0-9]+)+$": > type: object > description: | > -- > 2.34.1 >
On 14/08/2024 23:29, Frank Li wrote: > ifc can connect nor, nand and fpag. Add child node "nand@" under fsl,ifc > and compatible string "fsl,ifc-nand" when ifc connect to nand flash. > > Fix below warning: > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0: > failed to match any schema with compatible: ['fsl,ifc-nand'] > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Change from v1 to v2 > - add address-cells and size-cells ... and since you are resending, subject prefix is dt-bindings. Best regards, Krzysztof
On Sun, Aug 18, 2024 at 09:39:14AM -0600, Rob Herring wrote: > On Wed, Aug 14, 2024 at 05:29:57PM -0400, Frank Li wrote: > > ifc can connect nor, nand and fpag. Add child node "nand@" under fsl,ifc > > and compatible string "fsl,ifc-nand" when ifc connect to nand flash. > > > > Fix below warning: > > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0: > > failed to match any schema with compatible: ['fsl,ifc-nand'] > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Change from v1 to v2 > > - add address-cells and size-cells > > --- > > .../memory-controllers/fsl/fsl,ifc.yaml | 21 +++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml > > index d1c3421bee107..c12bb7f51db62 100644 > > --- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml > > +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml > > @@ -58,6 +58,27 @@ properties: > > access window as configured. > > > > patternProperties: > > + "^nand@[a-f0-9]+(,[a-f0-9]+)+$": > > + type: object > > + properties: > > + compatible: > > + const: fsl,ifc-nand > > + > > + reg: > > + maxItems: 1 > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 1 > > These only apply to child nodes, but you've disabled any child nodes. I will add mtd partition for it. > > > + > > + required: > > + - compatible > > + - reg > > + > > + additionalProperties: false > > You could minimally make this 'type: object' instead of false. Sorry, I have not understood your means. I already set nand@*** as object. nand@[a-f0-9]+(,[a-f0-9]+)+$": type: object > > Or does this follow the nand controller and chip bindings? May not being > older binding. I check if-nand driver, which have not parse other nand controller's property yet. Frank > > > + > > "^.*@[a-f0-9]+(,[a-f0-9]+)+$": > > type: object > > description: | > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml index d1c3421bee107..c12bb7f51db62 100644 --- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml @@ -58,6 +58,27 @@ properties: access window as configured. patternProperties: + "^nand@[a-f0-9]+(,[a-f0-9]+)+$": + type: object + properties: + compatible: + const: fsl,ifc-nand + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + required: + - compatible + - reg + + additionalProperties: false + "^.*@[a-f0-9]+(,[a-f0-9]+)+$": type: object description: |
ifc can connect nor, nand and fpag. Add child node "nand@" under fsl,ifc and compatible string "fsl,ifc-nand" when ifc connect to nand flash. Fix below warning: arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0: failed to match any schema with compatible: ['fsl,ifc-nand'] Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change from v1 to v2 - add address-cells and size-cells --- .../memory-controllers/fsl/fsl,ifc.yaml | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)