| Message ID | 20240821155746.55828-1-andrealmeid@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | common/config: Correctly ignore {TEST|SCRATCH}_DEV for tmpfs | expand |
On Wed, Aug 21, 2024 at 12:57:46PM -0300, André Almeida wrote: > As per commit 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV"), > tmpfs doesn't need TEST or SCRATCH devices due to being a RAM-based > filesystem. > > Fix the check by comparing the content of the variable TEST_DEV, instead > of comparing with the string TEST_DEV. Same for SCRATCH_DEV. > > Fixes: 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV") > Signed-off-by: André Almeida <andrealmeid@igalia.com> Looks good, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > common/config | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/config b/common/config > index 22740c0a..307f93fb 100644 > --- a/common/config > +++ b/common/config > @@ -829,10 +829,10 @@ get_next_config() { > fi > > if [ "$FSTYP" == "tmpfs" ]; then > - if [ -z "TEST_DEV" ]; then > + if [ -z "$TEST_DEV" ]; then > export TEST_DEV=tmpfs_test > fi > - if [ -z "SCRATCH_DEV" ]; then > + if [ -z "$SCRATCH_DEV" ]; then > export TEST_DEV=tmpfs_scratch > fi > fi > -- > 2.46.0 > >
diff --git a/common/config b/common/config index 22740c0a..307f93fb 100644 --- a/common/config +++ b/common/config @@ -829,10 +829,10 @@ get_next_config() { fi if [ "$FSTYP" == "tmpfs" ]; then - if [ -z "TEST_DEV" ]; then + if [ -z "$TEST_DEV" ]; then export TEST_DEV=tmpfs_test fi - if [ -z "SCRATCH_DEV" ]; then + if [ -z "$SCRATCH_DEV" ]; then export TEST_DEV=tmpfs_scratch fi fi
As per commit 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV"), tmpfs doesn't need TEST or SCRATCH devices due to being a RAM-based filesystem. Fix the check by comparing the content of the variable TEST_DEV, instead of comparing with the string TEST_DEV. Same for SCRATCH_DEV. Fixes: 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV") Signed-off-by: André Almeida <andrealmeid@igalia.com> --- common/config | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)