[net] selftests: mlxsw: ethtool_lanes: Source ethtool lib from correct path

Commit Message

Petr Machata Aug. 20, 2024, 10:53 a.m. UTC

From: Ido Schimmel <[e-mail]>

Source the ethtool library from the correct path and avoid the following
error:

./ethtool_lanes.sh: line 14: ./../../../net/forwarding/ethtool_lib.sh: No such file or directory

Fixes: 40d269c000bd ("selftests: forwarding: Move several selftests")
Signed-off-by: Ido Schimmel <[e-mail]>
Signed-off-by: Petr Machata <[e-mail]>
---
 tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Simon Horman Aug. 21, 2024, 12:28 p.m. UTC | #1

On Tue, Aug 20, 2024 at 12:53:47PM +0200, Petr Machata wrote:
> From: Ido Schimmel <[e-mail]>
> 
> Source the ethtool library from the correct path and avoid the following
> error:
> 
> ./ethtool_lanes.sh: line 14: ./../../../net/forwarding/ethtool_lib.sh: No such file or directory
> 
> Fixes: 40d269c000bd ("selftests: forwarding: Move several selftests")
> Signed-off-by: Ido Schimmel <[e-mail]>
> Signed-off-by: Petr Machata <[e-mail]>

Reviewed-by: Simon Horman <[e-mail]>

[e-mail] Aug. 22, 2024, 12:30 a.m. UTC | #2

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[e-mail]>:

On Tue, 20 Aug 2024 12:53:47 +0200 you wrote:
> From: Ido Schimmel <[e-mail]>
> 
> Source the ethtool library from the correct path and avoid the following
> error:
> 
> ./ethtool_lanes.sh: line 14: ./../../../net/forwarding/ethtool_lib.sh: No such file or directory
> 
> [...]

Here is the summary with links:
  - [net] selftests: mlxsw: ethtool_lanes: Source ethtool lib from correct path
    https://git.kernel.org/netdev/net/c/f8669d7b5f5d

You are awesome, thank you!

Patch

diff --git a/tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh b/tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh
index 877cd6df94a1..fe905a7f34b3 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh
@@ -2,6 +2,7 @@ 
 # SPDX-License-Identifier: GPL-2.0
 
 lib_dir=$(dirname $0)/../../../net/forwarding
+ethtool_lib_dir=$(dirname $0)/../hw
 
 ALL_TESTS="
 	autoneg
@@ -11,7 +12,7 @@  ALL_TESTS="
 NUM_NETIFS=2
 : ${TIMEOUT:=30000} # ms
 source $lib_dir/lib.sh
-source $lib_dir/ethtool_lib.sh
+source $ethtool_lib_dir/ethtool_lib.sh
 
 setup_prepare()
 {